0

Made gdb-add-index respect TOOLCHAIN_PREFIX settings.

This allows the script to work for remote debugging cross-compiled
binaries by adding a prefix such as arm-linux-gnueabi- to all of the
binutils commands.

BUG=

Review URL: https://codereview.chromium.org/828373003

Cr-Commit-Position: refs/heads/master@{#310640}
This commit is contained in:
cleichner
2015-01-08 16:36:50 -08:00
committed by Commit bot
parent d74ace91f7
commit cdc89dff37

@ -38,10 +38,10 @@ function index_one_file {
local basename=$(basename "$file")
local should_index="${SHOULD_INDEX}"
local readelf_out=$(readelf -S "$file")
local readelf_out=$(${TOOLCHAIN_PREFIX}readelf -S "$file")
if [[ $readelf_out =~ "gdb_index" ]]; then
if [ "${REMOVE_INDEX}" = 1 ]; then
objcopy --remove-section .gdb_index "$file"
${TOOLCHAIN_PREFIX}objcopy --remove-section .gdb_index "$file"
echo "Removed index from $basename."
else
echo "Skipped $basename -- already contains index."
@ -53,14 +53,15 @@ function index_one_file {
local start=$(date +"%s%N")
echo "Adding index to $basename..."
gdb -batch "$file" -ex "save gdb-index $DIRECTORY" -ex "quit"
${TOOLCHAIN_PREFIX}gdb -batch "$file" -ex "save gdb-index $DIRECTORY" \
-ex "quit"
local index_file="$DIRECTORY/$basename.gdb-index"
if [ -f "$index_file" ]; then
objcopy --add-section .gdb_index="$index_file" \
${TOOLCHAIN_PREFIX}objcopy --add-section .gdb_index="$index_file" \
--set-section-flags .gdb_index=readonly "$file" "$file"
local finish=$(date +"%s%N")
local elappsed=$(((finish - start)/1000000))
echo " ...$basename indexed. [${elappsed}ms]"
local elapsed=$(((finish - start)/1000000))
echo " ...$basename indexed. [${elapsed}ms]"
else
echo " ...$basename unindexable."
fi