chromium/src
0
Fork 0
Code Activity

ash: Remove BootTime.Login2 trace event

Browse Source 
This CL removes the BootTime.Login2 trace event, which is now confusing
since it no longer corresponds to the timing of BootTime.Login2 metric.

Bug: b:328690294
Change-Id: I41ade1daf9a44ea510f5c95d09e8ece46af35b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5716391
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1329294}
This commit is contained in:
Jun Ishiguro
2024-07-18 02:56:24 +00:00
committed by Chromium LUCI CQ
parent 7d1376a679
commit ce7be96fcc
2 changed files with 0 additions and 11 deletions

5
ash/metrics/post_login_metrics_recorder.cc

@ -99,9 +99,6 @@ void PostLoginMetricsRecorder::AddLoginTimeMarker(
REPORT_LOGIN_THROUGHPUT_EVENT("Ash.LoginAnimation.Jank.TabletMode");
REPORT_LOGIN_THROUGHPUT_EVENT("Ash.LoginAnimation.Duration2.ClamshellMode");
REPORT_LOGIN_THROUGHPUT_EVENT("Ash.LoginAnimation.Duration2.TabletMode");
REPORT_LOGIN_THROUGHPUT_EVENT("BootTime.Login2");
REPORT_LOGIN_THROUGHPUT_EVENT("BootTime.Login3");
REPORT_LOGIN_THROUGHPUT_EVENT("BootTime.Login4");
REPORT_LOGIN_THROUGHPUT_EVENT(
"Ash.UnlockAnimation.Smoothness.ClamshellMode");
REPORT_LOGIN_THROUGHPUT_EVENT("Ash.UnlockAnimation.Smoothness.TabletMode");
@ -280,7 +277,6 @@ void PostLoginMetricsRecorder::OnShelfIconsLoadedAndSessionRestoreDone(
// TODO(b/328339021, b/323098858): This is the mitigation against a bug
// that animation observation has race condition.
// Can be in a part of better architecture.
AddLoginTimeMarker("BootTime.Login4");
base::UmaHistogramCustomTimes(
"BootTime.Login4", ts - timestamp_origin_.value(),
base::Milliseconds(100), base::Seconds(100), 100);
@ -293,7 +289,6 @@ void PostLoginMetricsRecorder::OnShelfAnimationAndCompositorAnimationDone(
/*send_to_uma=*/false,
/*write_to_file=*/false);
AddLoginTimeMarker("BootTime.Login3");
base::UmaHistogramCustomTimes(
"BootTime.Login3", ts - timestamp_origin_.value(),
base::Milliseconds(100), base::Seconds(100), 100);

6
chrome/browser/ash/boot_times_recorder.cc

@ -9,8 +9,6 @@
#include <vector>
#include "ash/metrics/login_unlock_throughput_recorder.h"
#include "ash/shell.h"
#include "base/check.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
@ -108,10 +106,6 @@ void BootTimesRecorder::LoginDone(bool is_user_new) {
login_done_ = true;
login_started_ = false;
AddLoginTimeMarker("LoginDone", false);
ash::Shell::Get()
->login_unlock_throughput_recorder()
->post_login_metrics_recorder()
->AddLoginTimeMarker(kUmaLogin);
RecordCurrentStats(kChromeFirstRender);
LoginEventRecorder::Get()->ScheduleWriteLoginTimes(
kLoginTimes, (is_user_new ? kUmaLoginNewUser : kUmaLogin),