chromium/src
0
Fork 0
Code Activity

Reenable V8MemoryDumpProviderTest.Deterministic

Browse Source 
Bug: 1342599
Change-Id: Idc2bfdb776d9a64fb3e5597024f0a8d2835d09c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4293481
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1110293}
This commit is contained in:
Omer Katz
2023-02-27 13:02:46 +00:00
committed by Chromium LUCI CQ
parent 766274f6af
commit ce817c39e5
1 changed files with 1 additions and 8 deletions

9
gin/v8_isolate_memory_dump_provider_unittest.cc

@ -191,14 +191,7 @@ TEST_F(V8MemoryDumpProviderTest, DumpCodeStatistics) {
}
// Tests that a deterministic memory dump request performs a GC.
// TODO(crbug.com/1318974): Fix the flakiness on Linux.
// TODO(crbug.com/1342599): Fix the falkiness on linux-chromeos-dbg.
#if BUILDFLAG(IS_LINUX) || (BUILDFLAG(IS_CHROMEOS) && !defined(NDEBUG))
#define MAYBE_Deterministic DISABLED_Deterministic
#else
#define MAYBE_Deterministic Deterministic
#endif
TEST_F(V8MemoryDumpProviderTest, MAYBE_Deterministic) {
TEST_F(V8MemoryDumpProviderTest, Deterministic) {
base::trace_event::MemoryDumpArgs dump_args = {
base::trace_event::MemoryDumpLevelOfDetail::LIGHT,
base::trace_event::MemoryDumpDeterminism::FORCE_GC};