chromium/src
0
Fork 0
Code Activity

Add two missing "noexcept"s

Browse Source 
C++17 requires that declaration and definition match in use of noexcept.

Bug: 752720
Change-Id: I9a9ec0a1e1257669a6fa35413b778a291a87dbd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298315
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944831}
This commit is contained in:
Nico Weber
2021-11-24 04:13:32 +00:00
committed by Chromium LUCI CQ
parent 4c6e3c6a9c
commit cf02469244
2 changed files with 3 additions and 2 deletions
chrome/browser/ash/crostini
crostini_util.cc
chromecast/common
identification_settings_manager.cc

2
chrome/browser/ash/crostini/crostini_util.cc

@ -193,7 +193,7 @@ ContainerId::ContainerId(std::string vm_name,
std::string container_name) noexcept
: vm_name(std::move(vm_name)), container_name(std::move(container_name)) {}
ContainerId::ContainerId(const base::Value& dict) {
ContainerId::ContainerId(const base::Value& dict) noexcept {
const std::string* vm = dict.FindStringKey(prefs::kVmKey);
const std::string* container = dict.FindStringKey(prefs::kContainerKey);
vm_name = vm ? *vm : "";

3
chromecast/common/identification_settings_manager.cc

@ -136,7 +136,8 @@ IdentificationSettingsManager::SubstitutableParameter::SubstitutableParameter(
const IdentificationSettingsManager::SubstitutableParameter& other) =
default;
IdentificationSettingsManager::SubstitutableParameter::SubstitutableParameter(
IdentificationSettingsManager::SubstitutableParameter&& other) = default;
IdentificationSettingsManager::SubstitutableParameter&& other) noexcept =
default;
struct IdentificationSettingsManager::RequestInfo {
RequestInfo(net::HttpRequestHeaders param_headers,