0

Add feature flag for Android accessibility text formatting feature

AX-Relnotes: N/A
Bug: 370878026
Change-Id: I67cc7da385a33d6dea3c1dfdf0d3fc8186610cae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282627
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422400}
This commit is contained in:
Mark Schillaci
2025-02-20 00:48:25 -08:00
committed by Chromium LUCI CQ
parent 8c25a5758b
commit d176dac363
10 changed files with 43 additions and 0 deletions
chrome/browser
content
browser
public
android
java
src
org
chromium
content_public
common
testing/variations
tools/metrics/histograms

@ -5791,6 +5791,10 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAccessibilityIncludeLongClickActionDescription,
kOsAndroid,
FEATURE_VALUE_TYPE(features::kAccessibilityIncludeLongClickAction)},
{"enable-accessibility-text-formatting",
flag_descriptions::kAccessibilityTextFormattingName,
flag_descriptions::kAccessibilityTextFormattingDescription, kOsAndroid,
FEATURE_VALUE_TYPE(features::kAccessibilityTextFormatting)},
{"enable-accessibility-unified-snapshots",
flag_descriptions::kAccessibilityUnifiedSnapshotsName,
flag_descriptions::kAccessibilityUnifiedSnapshotsDescription, kOsAndroid,

@ -2412,6 +2412,11 @@
"owners": [ "aluh@chromium.com", "//ash/accessibility/OWNERS" ],
"expiry_milestone": 143
},
{
"name": "enable-accessibility-text-formatting",
"owners": [ "mschillaci@google.com", "//ui/accessibility/OWNERS" ],
"expiry_milestone": 145
},
{
"name": "enable-accessibility-unified-snapshots",
"owners": [ "mschillaci@google.com", "//ui/accessibility/OWNERS" ],

@ -4165,6 +4165,11 @@ const char kAccessibilityIncludeLongClickActionDescription[] =
"When enabled, the accessibility tree for the web contents will include "
"the ACTION_LONG_CLICK action on all relevant nodes.";
const char kAccessibilityTextFormattingName[] = "Accessibility Text Formatting";
const char kAccessibilityTextFormattingDescription[] =
"When enabled, text formatting information will be included in the "
"AccessibilityNodeInfo tree on Android";
const char kAccessibilityUnifiedSnapshotsName[] =
"Accessibility Unified Snapshots";
const char kAccessibilityUnifiedSnapshotsDescription[] =

@ -2428,6 +2428,8 @@ extern const char kAccessibilityDeprecateTypeAnnounceName[];
extern const char kAccessibilityDeprecateTypeAnnounceDescription[];
extern const char kAccessibilityIncludeLongClickActionName[];
extern const char kAccessibilityIncludeLongClickActionDescription[];
extern const char kAccessibilityTextFormattingName[];
extern const char kAccessibilityTextFormattingDescription[];
extern const char kAccessibilityUnifiedSnapshotsName[];
extern const char kAccessibilityUnifiedSnapshotsDescription[];
extern const char kAccessibilityManageBroadcastReceiverOnBackgroundName[];

@ -31,6 +31,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
&features::kAccessibilityDeprecateTypeAnnounce,
&features::kAccessibilityIncludeLongClickAction,
&features::kAccessibilityPageZoomV2,
&features::kAccessibilityTextFormatting,
&features::kAccessibilityUnifiedSnapshots,
&features::kAccessibilityManageBroadcastReceiverOnBackground,
&features::kAndroidFallbackToNextSlot,

@ -23,6 +23,8 @@ public class ContentFeatureList {
public static final String ACCESSIBILITY_PAGE_ZOOM_V2 = "AccessibilityPageZoomV2";
public static final String ACCESSIBILITY_TEXT_FORMATTING = "AccessibilityTextFormatting";
public static final String ACCESSIBILITY_UNIFIED_SNAPSHOTS = "AccessibilityUnifiedSnapshots";
public static final String ACCESSIBILITY_MANAGE_BROADCAST_RECEIVER_ON_BACKGROUND =
"AccessibilityManageBroadcastReceiverOnBackground";

@ -1306,6 +1306,12 @@ BASE_FEATURE(kAccessibilityPageZoomV2,
"AccessibilityPageZoomV2",
base::FEATURE_DISABLED_BY_DEFAULT);
// Enables the addition of text formatting information to the Android
// AccessibilityNodeInfo accessibility tree.
BASE_FEATURE(kAccessibilityTextFormatting,
"AccessibilityTextFormatting",
base::FEATURE_DISABLED_BY_DEFAULT);
// Enables the use of a unified code path for AXTree snapshots.
BASE_FEATURE(kAccessibilityUnifiedSnapshots,
"AccessibilityUnifiedSnapshots",

@ -291,6 +291,7 @@ CONTENT_EXPORT BASE_DECLARE_FEATURE(kWebPermissionsApi);
CONTENT_EXPORT BASE_DECLARE_FEATURE(kAccessibilityDeprecateTypeAnnounce);
CONTENT_EXPORT BASE_DECLARE_FEATURE(kAccessibilityIncludeLongClickAction);
CONTENT_EXPORT BASE_DECLARE_FEATURE(kAccessibilityPageZoomV2);
CONTENT_EXPORT BASE_DECLARE_FEATURE(kAccessibilityTextFormatting);
CONTENT_EXPORT BASE_DECLARE_FEATURE(kAccessibilityUnifiedSnapshots);
CONTENT_EXPORT BASE_DECLARE_FEATURE(
kAccessibilityManageBroadcastReceiverOnBackground);

@ -150,6 +150,21 @@
]
}
],
"AccessibilityTextFormatting": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"AccessibilityTextFormatting"
]
}
]
}
],
"AccessibilityUnifiedSnapshots": [
{
"platforms": [

@ -18971,6 +18971,7 @@ from previous Chrome versions.
<int value="1874910934" label="(Obsolete) CrOSSuspendToDiskAllowS4:disabled"/>
<int value="1875156497" label="CaptureMode:enabled"/>
<int value="1877769074" label="PhoneHubFeatureSetupErrorHandling:enabled"/>
<int value="1877956196" label="AccessibilityTextFormatting:disabled"/>
<int value="1878331098" label="GuestViewCrossProcessFrames:enabled"/>
<int value="1880148987" label="PrivacySandboxAdTopicsContentParity:disabled"/>
<int value="1880955305" label="enable-preconnect-to-search"/>
@ -19045,6 +19046,7 @@ from previous Chrome versions.
<int value="1906901281" label="WebFilterInterstitialRefresh:enabled"/>
<int value="1906942630" label="enable-easy-unlock"/>
<int value="1907273605" label="NtpZeroSuggest:disabled"/>
<int value="1908930956" label="AccessibilityTextFormatting:enabled"/>
<int value="1909117215" label="animated-image-resume"/>
<int value="1909961759" label="SurfaceSyncFullscreenKillswitch:enabled"/>
<int value="1910240042" label="enable-experimental-fullscreen-exit-ui"/>