chromium/src
0
Fork 0
Code Activity

Revert "build: Enable async_non_linkable_deps GN flag"

Browse Source 
This reverts commit 5974f6e639.

Reason for revert: it's suspect of the android-archive-rel breakage

https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/57119/overview

https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/57116/overview

Bug: gn:413507213, chromium:415155400
Original change's description:
> build: Enable async_non_linkable_deps GN flag
>
> The new GN feature changes the Ninja build graph to be more parallelized
> to build `data_deps` and other non linkable deps. (dependencies that
> aren't used for link step)
>
> Note that this change may reveal missing deps issues. If link
> dependencies aren't specified correctly, the link step would fail or
> build a different output without the missing deps. I've tested with Mega
> CQ and fixed all known issues such as https://crrev.com/c/6520584 and
> https://crrev.com/c/6508005. But, if there is a suspicious test/build
> failure, this CL can be reverted speculatively.
>
> Cq-Exclude-Trybots: luci.chromium.try:android-cronet-asan-arm-rel
> Cq-Exclude-Trybots: luci.chromium.try:android-cronet-x64-dbg-16-tests
> Cq-Exclude-Trybots: luci.chromium.try:android-cronet-x86-dbg-marshmallow-tests
> Cq-Exclude-Trybots: luci.chromium.try:android-webview-oreo-arm64-dbg
> Cq-Exclude-Trybots: luci.chromium.try:ios-device
> Cq-Exclude-Trybots: luci.chromium.try:linux-gcc-rel
> Cq-Exclude-Trybots: luci.chromium.try:linux-gcc-rel
> Cq-Exclude-Trybots: luci.chromium.try:linux-test-selection
> Bug: gn:413507213, chromium:415155400
> Change-Id: I7b10b1ee87b26ed8e6ff071e6c5288fba408eecf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6490909
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Cr-Commit-Position: refs/heads/main@{#1462501}

Bug: gn:413507213, chromium:415155400
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Icdede642299b799fc52c2bb4738e7e63a0f154b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6564586
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Owners-Override: Wenbo Jie <wenbojie@chromium.org>
Commit-Queue: Wenbo Jie <wenbojie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462533}
This commit is contained in:
Wenbo Jie
2025-05-19 18:43:00 -07:00
committed by Chromium LUCI CQ
parent 9accca5756
commit d19712d667
1 changed files with 0 additions and 6 deletions

6
.gn

@ -12,12 +12,6 @@ buildconfig = "//build/config/BUILDCONFIG.gn"
# for python3.exe and python3.bat.
script_executable = "python3"
# TODO: crbug.com/413507213 - Remove this flag after enabling this feature by
# default.
# Changes the Ninja build graph to build data_deps and other non-linkable
# deps asynchronously.
async_non_linkable_deps = true
# These arguments override the default values for items in a declare_args
# block. "gn args" in turn can override these.
#