chromium/src
0
Fork 0
Code Activity

Revert "Document WebView flag requirement in flag_guarding_guidelines.md"

Browse Source 
This reverts commit e7f8c2b338.

Reason for revert: Will consider putting this documentation elsewhere

Original change's description:
> Document WebView flag requirement in flag_guarding_guidelines.md
>
> Bug: None
> Change-Id: I19afe75cb0b2500ca3fb096041549b09d851543c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4387340
> Commit-Queue: Andrew Williams <awillia@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1124759}

Bug: None
Change-Id: I3b9d6a82fa2645615e8b3ae7da63188e5f8dd6b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4391302
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Andrew Williams <awillia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124980}
This commit is contained in:
Andrew Williams
2023-04-01 00:12:34 +00:00
committed by Chromium LUCI CQ
parent f859a0ba9a
commit d2c9d7c6d6
1 changed files with 0 additions and 7 deletions

7
docs/flag_guarding_guidelines.md

@ -74,10 +74,3 @@ base::Feature flag, which can be remotely disabled by a server configuration.
* For code in blink, this can be as simple as using a
[Runtime Enabled Feature](/third_party/blink/renderer/platform/RuntimeEnabledFeatures.md),
which has long been common-practice for new or changed APIs.
* For any base::Feature flag guarding code that runs in (or otherwise affects)
Android WebView, a corresponding
[WebView experiment flag](/android_webview/docs/developer-ui.md#flag-ui) should
be added to provide developers with a way to identify whether a given flag is
causing breakage. For Googler committers, this requirement is enforced when
enabling or disabling any base::Feature flag via Finch
([internal link](http://go/finch-tricorder#webview-flag)).