0

Tidy some pdf/ code.

- Remove unnecessary includes and then do IWYU in various files.
- Remove deprecated DISALLOW_COPY_AND_ASSIGN usage in pdf/pdf.cc.

Change-Id: Iee84b4170a3cd73b847a8003e876ed8b6238fa67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292712
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787990}
This commit is contained in:
Lei Zhang
2020-07-14 01:12:26 +00:00
committed by Commit Bot
parent 1100f991a7
commit d58bb22831
3 changed files with 9 additions and 7 deletions

@ -30,7 +30,6 @@
#include "pdf/accessibility.h"
#include "pdf/document_layout.h"
#include "pdf/document_metadata.h"
#include "pdf/pdf.h"
#include "pdf/pdf_features.h"
#include "ppapi/c/dev/ppb_cursor_control_dev.h"
#include "ppapi/c/pp_errors.h"

@ -8,8 +8,7 @@
#include <utility>
#include "base/macros.h"
#include "pdf/out_of_process_instance.h"
#include "pdf/pdf_engine.h"
#include "pdf/pdf_init.h"
namespace chrome_pdf {
@ -22,13 +21,14 @@ class ScopedSdkInitializer {
if (!IsSDKInitializedViaPepper())
InitializeSDK(enable_v8);
}
ScopedSdkInitializer(const ScopedSdkInitializer&) = delete;
ScopedSdkInitializer& operator=(const ScopedSdkInitializer&) = delete;
~ScopedSdkInitializer() {
if (!IsSDKInitializedViaPepper())
ShutdownSDK();
}
private:
DISALLOW_COPY_AND_ASSIGN(ScopedSdkInitializer);
};
} // namespace

@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "build/build_config.h"
#include "pdf/pdf.h"
#include "pdf/pdf_engine.h"
#include "pdf/ppapi_migration/input_event_conversions.h"
#include "ppapi/c/pp_input_event.h"
@ -16,6 +15,10 @@
#include "third_party/pdfium/public/fpdfview.h"
#include "ui/events/keycodes/keyboard_codes.h"
#if defined(OS_WIN)
#include "pdf/pdf.h"
#endif
#define STATIC_ASSERT_ENUM(a, b) \
static_assert(static_cast<int>(a) == static_cast<int>(b), \
"mismatching enums: " #a)