chromium/src
0
Fork 0
Code Activity

Create flag for enabling two-up view feature in PDF viewer.

Browse Source 
Add feature flag "pdf-two-up-view", which indicates whether users
have access to two-up view toggle button inside PDF viewer.

Bug: 51472
Change-Id: Icc37e4a595348c87248dfaa57b3e175cf2d98ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023926
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737318}
This commit is contained in:
Hui Yingst
2020-01-31 14:46:56 +00:00
committed by Commit Bot
parent 35b691eb74
commit d6b981c334
7 changed files with 22 additions and 0 deletions

4
chrome/browser/about_flags.cc

@ -3312,6 +3312,10 @@ const FeatureEntry kFeatureEntries[] = {
{"pdf-form-save", flag_descriptions::kPdfFormSaveName,
flag_descriptions::kPdfFormSaveDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kSaveEditedPDFForm)},
{"pdf-two-up-view", flag_descriptions::kPdfTwoUpViewName,
flag_descriptions::kPdfTwoUpViewDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPDFTwoUpView)},
#endif // BUILDFLAG(ENABLE_PDF)
#if BUILDFLAG(ENABLE_PRINTING)

5
chrome/browser/flag-metadata.json

@ -3051,6 +3051,11 @@
"owners": [ "thestig" ],
"expiry_milestone": 82
},
{
"name": "pdf-two-up-view",
"owners": ["nigi", "thestig"],
"expiry_milestone": 86
},
{
"name": "per-method-can-make-payment-quota",
"owners": [ "rouslan" ],

4
chrome/browser/flag_descriptions.cc

@ -3747,6 +3747,10 @@ const char kPdfFormSaveName[] = "Save PDF Forms";
const char kPdfFormSaveDescription[] =
"Enable saving PDFs with filled form data.";
const char kPdfTwoUpViewName[] = "PDF Two-up View";
const char kPdfTwoUpViewDescription[] =
"Enable a new option to display two pages side by side in the PDF viewer.";
#endif // BUILDFLAG(ENABLE_PLUGINS)
#if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)

3
chrome/browser/flag_descriptions.h

@ -2218,6 +2218,9 @@ extern const char kPdfAnnotationsDescription[];
extern const char kPdfFormSaveName[];
extern const char kPdfFormSaveDescription[];
extern const char kPdfTwoUpViewName[];
extern const char kPdfTwoUpViewDescription[];
#endif // BUILDFLAG(ENABLE_PLUGINS)
#if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)

3
pdf/pdf_features.cc

@ -25,6 +25,9 @@ const base::Feature kPDFAnnotations {
#endif // defined(OS_CHROMEOS)
};
const base::Feature kPDFTwoUpView{"PDFTwoUpView",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kAccessiblePDFHighlight{"AccessiblePDFHighlight",
base::FEATURE_DISABLED_BY_DEFAULT};

1
pdf/pdf_features.h

@ -15,6 +15,7 @@ namespace features {
extern const base::Feature kSaveEditedPDFForm;
extern const base::Feature kPDFAnnotations;
extern const base::Feature kPDFTwoUpView;
extern const base::Feature kAccessiblePDFHighlight;
} // namespace features

2
tools/metrics/histograms/enums.xml

@ -38399,6 +38399,7 @@ from previous Chrome versions.
<int value="-97145978" label="DesktopPWAsStayInWindow:enabled"/>
<int value="-92116820" label="InlineUpdateFlow:enabled"/>
<int value="-91767554" label="enable-de-jelly"/>
<int value="-90521375" label="PDFTwoUpView:enabled"/>
<int value="-90032223" label="BuiltInModuleInfra:disabled"/>
<int value="-89690053" label="MaterialDesignUserManager:enabled"/>
<int value="-89567017" label="ChromeColorsCustomColorPicker:enabled"/>
@ -38620,6 +38621,7 @@ from previous Chrome versions.
<int value="155977192" label="EnableFileManagerFormatDialog:disabled"/>
<int value="157217034" label="enable-tab-for-desktop-share"/>
<int value="157318016" label="AutomaticTabDiscarding:enabled"/>
<int value="160524775" label="PDFTwoUpView:disabled"/>
<int value="160838658" label="SmartDimModelV3:enabled"/>
<int value="161409456" label="AutofillUseMobileLabelDisambiguation:disabled"/>
<int value="161694478" label="OmniboxNewAnswerLayout:enabled"/>