0

Skip generation of stats, since code is now shared across threads

The stats function was not written to be shared across threads, and
recent use by sync on a second thread is causing it to malfunction
(because it uses function level statics).


r=wtc
bug=74467
Review URL: http://codereview.chromium.org/6624023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76989 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
jar@chromium.org
2011-03-04 23:08:15 +00:00
parent 05a46357ae
commit d7a80be378

@ -21,6 +21,11 @@ namespace net {
// Each histogram has an unused bucket at the end to allow seamless future
// expansion.
void UpdateConnectionTypeHistograms(ConnectionType type) {
// TODO(wtc): Bug 74467 Move these stats up to a higher level, where the
// explicit static (shown below) and the implicit statics (inside the
// HISTOGRAM macros) will be thread safe.
#if 0 // Don't do anything for now.
static bool had_connection_type[NUM_OF_CONNECTION_TYPES];
if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) {
@ -35,6 +40,7 @@ void UpdateConnectionTypeHistograms(ConnectionType type) {
} else {
NOTREACHED(); // Someone's logging an invalid type!
}
#endif // 0
}
} // namespace net