Remove flag RemoveMobileViewportDoubleTap

This flag has been set to default since March 2021.
Link to CL: https://crrev.com/c/2757671.

Change-Id: I5c08ddd7184d0cfed6f1377a6d0cc1a4706815a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5825309
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350819}

cc/base/features.cc

@@ -38,10 +38,6 @@ BASE_FEATURE(kSynchronizedScrolling,
              base::FEATURE_ENABLED_BY_DEFAULT);
 #endif
 
-BASE_FEATURE(kRemoveMobileViewportDoubleTap,
-             "RemoveMobileViewportDoubleTap",
-             base::FEATURE_ENABLED_BY_DEFAULT);
-
 BASE_FEATURE(kScrollSnapCoveringAvoidNestedSnapAreas,
              "ScrollSnapCoveringAvoidNestedSnapAreas",
              base::FEATURE_ENABLED_BY_DEFAULT);

cc/base/features.h

@@ -18,11 +18,6 @@ CC_BASE_EXPORT BASE_DECLARE_FEATURE(kAnimatedImageResume);
 CC_BASE_EXPORT extern bool IsImpulseScrollAnimationEnabled();
 CC_BASE_EXPORT BASE_DECLARE_FEATURE(kSynchronizedScrolling);
 
-// When enabled, the double tap to zoom will be disabled when the viewport
-// meta tag is properly set for mobile using content=width=device-width
-// or content=initial-scale=1.0
-CC_BASE_EXPORT BASE_DECLARE_FEATURE(kRemoveMobileViewportDoubleTap);
-
 // When enabled, scrolling within a covering snap area avoids or snaps to inner
 // nested areas, avoiding resting on positions which do not snap the inner area.
 // E.g. when scrolling within snap area A, it will stop either before/after

cc/trees/mobile_optimized_viewport_util.cc

@@ -32,9 +32,7 @@ bool IsMobileOptimized(float min_page_scale_factor,
       content_width_css <= window_width_dip + kMobileViewportWidthEpsilon;
 
   return has_mobile_viewport || has_fixed_page_scale ||
-         (base::FeatureList::IsEnabled(
-              ::features::kRemoveMobileViewportDoubleTap) &&
-          viewport_meta_mobile_optimized);
+         viewport_meta_mobile_optimized;
 }
 
 }  // namespace util

content/browser/renderer_host/input/double_tap_to_zoom_browsertest.cc

@@ -73,12 +73,7 @@ class DoubleTapToZoomBrowserTest
       public ::testing::WithParamInterface<
           std::tuple<std::string, bool, std::string>> {
  public:
-  DoubleTapToZoomBrowserTest() {
-    std::vector<base::test::FeatureRef> enable_features;
-    enable_features.push_back(features::kRemoveMobileViewportDoubleTap);
-    feature_list_.InitWithFeatures(enable_features,
-                                   std::vector<base::test::FeatureRef>());
-  }
+  DoubleTapToZoomBrowserTest() {}
   ~DoubleTapToZoomBrowserTest() override = default;
 
  protected:
@@ -91,9 +86,6 @@ class DoubleTapToZoomBrowserTest
   void LoadURL() {
     EXPECT_TRUE(NavigateToURL(shell(), HtmlAsDataUrl(std::get<0>(GetParam()))));
   }
-
- private:
-  base::test::ScopedFeatureList feature_list_;
 };
 
 IN_PROC_BROWSER_TEST_P(DoubleTapToZoomBrowserTest, MobileOptimizedStatus) {

content/child/runtime_features.cc

@@ -325,8 +325,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
           {wf::EnableWebXRSpecParity,
            raw_ref(device::features::kWebXrIncubations)},
 #endif
-          {wf::EnableRemoveMobileViewportDoubleTap,
-           raw_ref(features::kRemoveMobileViewportDoubleTap)},
           {wf::EnableServiceWorkerStaticRouter,
            raw_ref(features::kServiceWorkerStaticRouter)},
           {wf::EnablePermissions, raw_ref(features::kWebPermissionsApi),

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -3477,12 +3477,6 @@
       name: "RemoveDataUrlInSvgUse",
       status: "stable",
     },
-    {
-      name: "RemoveMobileViewportDoubleTap",
-      public: true,
-      status: "stable",
-      base_feature: "none",
-    },
     // Remove a node if it's selected fully even though it has children. See
     // https://crbug.com/331074432
     {