0

[Chrome Stdlib] Fix presubmit

A test data file was uploaded without adding a DEPS entry. The presubmit
was only showing a message rather than an error. This change adds the
missing DEPS entry and makes the presubmit message an error.

Change-Id: I0491104ddf9ab0c9a84de1a7542354c198ab36f3
Bug: 345023320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600600
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Owners-Override: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Rasika Navarange <rasikan@google.com>
Cr-Commit-Position: refs/heads/main@{#1310513}
This commit is contained in:
Rasika Navarange
2024-06-05 10:01:27 +00:00
committed by Chromium LUCI CQ
parent e76e3547d4
commit d977df34bc
2 changed files with 8 additions and 1 deletions

7
DEPS

@ -2106,6 +2106,13 @@ deps = {
'generation': 1684336047660953,
'output_file': 'speedometer.perfetto_trace.gz'
},
{
'object_name': 'test_data/scroll_jank_with_pinch.pftrace-8587d2016fdb5d39b5f852704b6e3925e9e6527af01696396be767bed04d4a45',
'sha256sum': '8587d2016fdb5d39b5f852704b6e3925e9e6527af01696396be767bed04d4a45',
'size_bytes': 3914720,
'generation': 1717497788778335,
'output_file': 'scroll_jank_with_pinch.pftrace'
},
{
'object_name': 'test_data/cpu_powerups_1.pb-70f5511ba0cd6ce1359e3cadb4d1d9301fb6e26be85158e3384b06f41418d386',
'sha256sum': '70f5511ba0cd6ce1359e3cadb4d1d9301fb6e26be85158e3384b06f41418d386',

@ -3434,7 +3434,7 @@ def CheckEachPerfettoTestDataFileHasDepsEntry(input_api, output_api):
old_deps_entry = old_deps['src/base/tracing/test/data']
if not deps_entry:
# TODO(312895063):Add back error when .sha256 files have been moved.
return [output_api.PresubmitNotifyResult(
return [output_api.PresubmitError(
'You must update the DEPS file when you update a '
'.sha256 file in base/tracing/test/data_sha256'
)]