chromium/src
0
Fork 0
Code Activity

Add exceptions to max_cols rule.

Browse Source 
Review URL: http://codereview.chromium.org/42019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11340 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
maruel@chromium.org
2009-03-10 17:13:42 +00:00
parent fd4504be3c
commit db24f367ca
1 changed files with 8 additions and 2 deletions

10
PRESUBMIT.py

@ -64,6 +64,7 @@ def LocalChecks(input_api, output_api, max_cols=80):
Note that the whole file is checked, not only the changes.
"""
C_SOURCE_FILE_EXTENSIONS = ('.c', '.cc', '.cpp', '.h', '.inl')
cr_files = []
eof_files = []
results = []
@ -103,8 +104,13 @@ def LocalChecks(input_api, output_api, max_cols=80):
local_errors.append(output_api.PresubmitError(
'%s, line %s ends with whitespaces.' %
(path, line_num)))
# Accept lines with http:// to exceed the max_cols rule.
if max_cols and len(line) > max_cols and not 'http://' in line:
# Accept lines with http://, https:// and C #define/#pragma/#include to
# exceed the max_cols rule.
if (max_cols and
len(line) > max_cols and
not 'http://' in line and
not 'https://' in line and
not (line[0] == '#' and ext in C_SOURCE_FILE_EXTENSIONS)):
local_errors.append(output_api.PresubmitError(
'%s, line %s has %s chars, please reduce to %d chars.' %
(path, line_num, len(line), max_cols)))