chromium/src
0
Fork 0
Code Activity

Add a note to the code with pitfalls to avoid

Browse Source 
When https://crbug.com/404294118 was reverted, a comment was left in
the code noting the conditions for which a re-land would be possible.
After the revert, a second regression was reported, so update the
code comment with a pointer on the issue, so that it can be avoided
when the re-land happens.

Bug: 389067059
Bug: 404294118
Change-Id: I895e6cae81bd36115858efbd32e5648c710d6289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373059
Reviewed-by: Jayson Adams <shrike@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434861}
This commit is contained in:
Avi Drissman
2025-03-19 09:25:35 -07:00
committed by Chromium LUCI CQ
parent b691627903
commit db5d04637f
1 changed files with 7 additions and 1 deletions

8
content/app_shim_remote_cocoa/web_menu_runner_mac.mm

@ -157,7 +157,13 @@ static const char kMenuWasRunCallbackKey = 0;
// improperly truncate their contents (see https://crbug.com/401443090).
//
// This has been filed as FB16843355. TODO(https://crbug.com/389067059): When
// this FB is resolved, switch to the new API.
// this FB is resolved, switch to the new API by relanding an adapted version
// of https://crrev.com/c/6173642.
//
// In addition, note that there are web pages that use popups with a font size
// of 0. When relanding, font size will likely play a part in the calculation
// of the menu position of the reland, so be sure to not regress menu
// positioning in that case (https://crbug.com/404294118).
// Set up the button cell, converting to NSView coordinates. The menu is
// positioned such that the currently selected menu item appears over the