chromium/src
0
Fork 0
Code Activity

[DIPS] Make preserving Privacy Sandbox data the default.

Browse Source 
Make the DIPSPreservePSData feature enabled by default.

This is step 7 of go/finch-best-practices

Bug: 41488981
Change-Id: I02ae7e5c27d18a0d842a9f6fa6ac01f2199a479e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425511
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Anton Maliev <amaliev@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283203}
This commit is contained in:
Ryan Tarpine
2024-04-05 16:56:37 +00:00
committed by Chromium LUCI CQ
parent 8092ca9c82
commit db8b3ff197
3 changed files with 5 additions and 23 deletions
chrome/browser/dips
dips_service_unittest.cc
content/public/common
content_features.cc
testing/variations
fieldtrial_testing_config.json

6
chrome/browser/dips/dips_service_unittest.cc

@@ -359,7 +359,8 @@ TEST_F(DIPSServiceStateRemovalTest, BrowsingDataDeletion_Enabled) {
net::CookiePartitionKeyCollection());
delegate_.ExpectCall(
base::Time::Min(), base::Time::Max(),
chrome_browsing_data_remover::FILTERABLE_DATA_TYPES |
(chrome_browsing_data_remover::FILTERABLE_DATA_TYPES &
~content::BrowsingDataRemover::DATA_TYPE_PRIVACY_SANDBOX) |
content::BrowsingDataRemover::DATA_TYPE_AVOID_CLOSING_CONNECTIONS,
content::BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB |
content::BrowsingDataRemover::ORIGIN_TYPE_PROTECTED_WEB,
@@ -757,7 +758,8 @@ TEST_F(DIPSServiceStateRemovalTest, ImmediateEnforcement) {
net::CookiePartitionKeyCollection());
delegate_.ExpectCall(
base::Time::Min(), base::Time::Max(),
chrome_browsing_data_remover::FILTERABLE_DATA_TYPES |
(chrome_browsing_data_remover::FILTERABLE_DATA_TYPES &
~content::BrowsingDataRemover::DATA_TYPE_PRIVACY_SANDBOX) |
content::BrowsingDataRemover::DATA_TYPE_AVOID_CLOSING_CONNECTIONS,
content::BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB |
content::BrowsingDataRemover::ORIGIN_TYPE_PROTECTED_WEB,

2
content/public/common/content_features.cc

@@ -307,7 +307,7 @@ const base::FeatureParam<base::TimeDelta> kDIPSClientBounceDetectionTimeout{
// Whether DIPS deletes Privacy Sandbox data.
BASE_FEATURE(kDIPSPreservePSData,
"DIPSPreservePSData",
base::FEATURE_DISABLED_BY_DEFAULT);
base::FEATURE_ENABLED_BY_DEFAULT);
// Enables HW decode acceleration for WebRTC.
BASE_FEATURE(kWebRtcHWDecoding,

20
testing/variations/fieldtrial_testing_config.json

@@ -5359,26 +5359,6 @@
]
}
],
"DIPSPreservePSData": [
{
"platforms": [
"android",
"chromeos",
"chromeos_lacros",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"DIPSPreservePSData"
]
}
]
}
],
"DIPSStatefulBounceEnforcement": [
{
"platforms": [