chromium/src
0
Fork 0
Code Activity

Update iOS flag file path

Browse Source 
Bug: none
Change-Id: I38662785f96a963396e4dd978c329b6256817bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2893902
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#882522}
This commit is contained in:
Avi Drissman
2021-05-13 16:07:33 +00:00
committed by Chromium LUCI CQ
parent 389ed502f7
commit dbaa3cd2f8
2 changed files with 7 additions and 5 deletions

8
docs/flag_expiry.md

@ -53,8 +53,10 @@ Google employees: See more at
## Removing A Flag
If a flag is no longer used (for instance, it was used to control a feature
that has since launched), the flag should be removed. Delete the entry in
[`//chrome/browser/about_flags.cc`](../chrome/browser/about_flags.cc) (and any
corresponding entries for the flag description), and remove any references in
[`//chrome/browser/about_flags.cc`](../chrome/browser/about_flags.cc) or
[`//ios/chrome/browser/flags/about_flags.mm`](../ios/chrome/browser/flags/about_flags.mm)
for iOS (and any corresponding entries for the flag description), and remove any
references in
[`//chrome/browser/flag-metadata.json`](../chrome/browser/flag-metadata.json).
## Removed Flags
@ -76,7 +78,7 @@ there's also
* [`//chrome/browser/flag-metadata.json`](../chrome/browser/flag-metadata.json)
* [`//chrome/browser/flag-never-expire-list.json`](../chrome/browser/flag-never-expire-list.json)
* [`//chrome/browser/expired_flags_list.h`](../chrome/browser/expired_flags_list.h)
* [`//ios/chrome/browser/about_flags.mm`](../ios/chrome/browser/about_flags.mm)
* [`//ios/chrome/browser/flags/about_flags.mm`](../ios/chrome/browser/flags/about_flags.mm)
* [`//tools/flags/generate_expired_list.py`](../tools/flags/generate_expired_list.py)
* [`//tools/flags/generate_unexpire_flags.py`](../tools/flags/generate_unexpire_flags.py)

4
docs/flag_ownership.md

@ -22,7 +22,7 @@ you find, either:
- **If it is not in use:** delete the entry from the [`//chrome/browser/flag-metadata.json`](../chrome/browser/flag-metadata.json)
file, and delete it from `kFeatureEntries` in
[`//chrome/browser/about_flags.cc`](../chrome/browser/about_flags.cc) or
[`//ios/chrome/browser/about_flags.mm`](../ios/chrome/browser/about_flags.mm)
[`//ios/chrome/browser/flags/about_flags.mm`](../ios/chrome/browser/flags/about_flags.mm)
for iOS. Remember to file a cleanup bug to remove code paths that become dead.
## Wait, What Are You Doing?
@ -91,6 +91,6 @@ there's also
* [`//chrome/browser/flag-metadata.json`](../chrome/browser/flag-metadata.json)
* [`//chrome/browser/flag-never-expire-list.json`](../chrome/browser/flag-never-expire-list.json)
* [`//chrome/browser/expired_flags_list.h`](../chrome/browser/expired_flags_list.h)
* [`//ios/chrome/browser/about_flags.mm`](../ios/chrome/browser/about_flags.mm)
* [`//ios/chrome/browser/flags/about_flags.mm`](../ios/chrome/browser/flags/about_flags.mm)
* [`//tools/flags/generate_expired_list.py`](../tools/flags/generate_expired_list.py)
* [`//tools/flags/generate_unexpire_flags.py`](../tools/flags/generate_unexpire_flags.py)