Fix param name in CreateCrackedFileSystemURL()

Make it clearer that it is the virtual path which is passed in,
not the absolute path in the host.

Change-Id: I2506387a06463c0a6635e3b0ecfb3a29455268b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515428
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823693}

storage/browser/file_system/external_mount_points.cc

@@ -195,8 +195,8 @@ FileSystemURL ExternalMountPoints::CrackURL(const GURL& url) const {
 FileSystemURL ExternalMountPoints::CreateCrackedFileSystemURL(
     const url::Origin& origin,
     FileSystemType type,
-    const base::FilePath& path) const {
-  return CrackFileSystemURL(FileSystemURL(origin, type, path));
+    const base::FilePath& virtual_path) const {
+  return CrackFileSystemURL(FileSystemURL(origin, type, virtual_path));
 }
 
 void ExternalMountPoints::AddMountPointInfosTo(

storage/browser/file_system/external_mount_points.h

@@ -82,7 +82,7 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) ExternalMountPoints
   FileSystemURL CreateCrackedFileSystemURL(
       const url::Origin& origin,
       FileSystemType type,
-      const base::FilePath& path) const override;
+      const base::FilePath& virtual_path) const override;
 
   // Returns a list of registered MountPointInfos (of <mount_name, path>).
   void AddMountPointInfosTo(std::vector<MountPointInfo>* mount_points) const;

storage/browser/file_system/isolated_context.cc

@@ -398,8 +398,8 @@ FileSystemURL IsolatedContext::CrackURL(const GURL& url) const {
 FileSystemURL IsolatedContext::CreateCrackedFileSystemURL(
     const url::Origin& origin,
     FileSystemType type,
-    const base::FilePath& path) const {
-  return CrackFileSystemURL(FileSystemURL(origin, type, path));
+    const base::FilePath& virtual_path) const {
+  return CrackFileSystemURL(FileSystemURL(origin, type, virtual_path));
 }
 
 void IsolatedContext::RevokeFileSystemByPath(const base::FilePath& path_in) {

storage/browser/file_system/isolated_context.h

@@ -177,7 +177,7 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) IsolatedContext : public MountPoints {
   FileSystemURL CreateCrackedFileSystemURL(
       const url::Origin& origin,
       FileSystemType type,
-      const base::FilePath& path) const override;
+      const base::FilePath& virtual_path) const override;
 
   // Returns the virtual root path that looks like /<filesystem_id>.
   base::FilePath CreateVirtualRootPath(const std::string& filesystem_id) const;

storage/browser/file_system/mount_points.h

@@ -59,14 +59,14 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) MountPoints {
   // from |url|.
   virtual FileSystemURL CrackURL(const GURL& url) const = 0;
 
-  // Creates a FileSystemURL with the given origin, type and path and tries to
-  // crack it as a part of one of the registered mount points.
-  // If the the URL is not valid or does not belong to any of the mount points
+  // Creates a FileSystemURL with the given origin, type and virtual path and
+  // tries to crack it as a part of one of the registered mount points. If the
+  // the URL is not valid or does not belong to any of the mount points
   // registered in this context, returns empty, invalid FileSystemURL.
   virtual FileSystemURL CreateCrackedFileSystemURL(
       const url::Origin& origin,
       FileSystemType type,
-      const base::FilePath& path) const = 0;
+      const base::FilePath& virtual_path) const = 0;
 
   // Returns the mount point root path registered for a given |mount_name|.
   // Returns false if the given |mount_name| is not valid.