snap-group: Add feedback button on the divider

Demo: http://b/328459110#comment3
Fixed: b/328459110
Test: Manually
Change-Id: Ief5fa8ef7eb27b6b4efd595b418d8aaf987f5452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350710
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270340}

ash/ash_strings.grd

@@ -6358,6 +6358,9 @@ Here are some things you can try to get started.
       <message name="IDS_ASH_SNAP_GROUP_CLICK_TO_UNLOCK_WINDOWS" desc="Click to unlock the locked windows.">
         Unlock the windows
       </message>
+      <message name="IDS_ASH_SNAP_GROUP_SEND_FEEDBACK" desc="Send feedback.">
+        Send feedback
+      </message>
       <message name="IDS_ASH_SNAP_GROUP_MORE_OPTIONS" desc="Click to see more options.">
         More options
       </message>

ash/ash_strings_grd/IDS_ASH_SNAP_GROUP_SEND_FEEDBACK.png.sha1

@@ -0,0 +1 @@
+33e8ff044f804b79669d51ec1e68c50920bd3713

ash/wm/splitview/split_view_divider_view.cc

@@ -6,7 +6,10 @@
 
 #include "ash/display/screen_orientation_controller.h"
 #include "ash/public/cpp/window_properties.h"
+#include "ash/resources/vector_icons/vector_icons.h"
 #include "ash/shell.h"
+#include "ash/strings/grit/ash_strings.h"
+#include "ash/style/icon_button.h"
 #include "ash/utility/cursor_setter.h"
 #include "ash/wm/snap_group/snap_group.h"
 #include "ash/wm/splitview/split_view_constants.h"
@@ -14,6 +17,7 @@
 #include "ash/wm/splitview/split_view_divider.h"
 #include "ash/wm/splitview/split_view_divider_handler_view.h"
 #include "ash/wm/splitview/split_view_utils.h"
+#include "base/functional/callback_helpers.h"
 #include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/chromeos/styles/cros_tokens_color_mappings.h"
 #include "ui/compositor/layer.h"
@@ -27,6 +31,17 @@
 
 namespace ash {
 
+namespace {
+
+// Distance between the bottom of the feedback button and the bottom of the work
+// area.
+constexpr int kFeedbackButtonDistanceFromBottom = 58;
+
+// Size of the feedback button.
+constexpr gfx::Size kFeedbackButtonSize{40, 40};
+
+}  // namespace
+
 SplitViewDividerView::SplitViewDividerView(SplitViewController* controller,
                                            SplitViewDivider* divider)
     : split_view_controller_(controller),
@@ -43,6 +58,8 @@ SplitViewDividerView::SplitViewDividerView(SplitViewController* controller,
   SetBorder(std::make_unique<views::HighlightBorder>(
       /*corner_radius=*/0,
       views::HighlightBorder::Type::kHighlightBorderNoShadow));
+
+  RefreshFeedbackButton(false);
 }
 
 SplitViewDividerView::~SplitViewDividerView() = default;
@@ -93,6 +110,18 @@ void SplitViewDividerView::Layout(PassKey) {
   SetBoundsRect(GetLocalBounds());
   divider_handler_view_->Refresh(
       split_view_controller_->IsResizingWithDivider());
+
+  if (feedback_button_) {
+    // TODO(michelefan): Calculate the bounds for the feedback button for
+    // vertical layout.
+    const gfx::Size feedback_button_size = feedback_button_->GetPreferredSize();
+    const gfx::Rect feedback_button_bounds(
+        (width() - feedback_button_size.width()) / 2.f,
+        height() - feedback_button_size.height() -
+            kFeedbackButtonDistanceFromBottom,
+        feedback_button_size.width(), feedback_button_size.height());
+    feedback_button_->SetBoundsRect(feedback_button_bounds);
+  }
 }
 
 void SplitViewDividerView::OnMouseEntered(const ui::MouseEvent& event) {
@@ -102,12 +131,18 @@ void SplitViewDividerView::OnMouseEntered(const ui::MouseEvent& event) {
   // Set cursor type as the resize cursor when it's on the split view divider.
   cursor_setter_.UpdateCursor(split_view_controller_->root_window(),
                               ui::mojom::CursorType::kColumnResize);
+
+  // Show `feedback_button_` on mouse entered.
+  RefreshFeedbackButton(/*visible=*/true);
 }
 
 void SplitViewDividerView::OnMouseExited(const ui::MouseEvent& event) {
   // Since `notify_enter_exit_on_child_` in view.h is default to false, on mouse
   // exit `this` the cursor will be reset.
   cursor_setter_.ResetCursor();
+
+  // Hide `feedback_button_` on mouse exited.
+  RefreshFeedbackButton(/*visible=*/false);
 }
 
 bool SplitViewDividerView::OnMousePressed(const ui::MouseEvent& event) {
@@ -237,6 +272,35 @@ void SplitViewDividerView::StartResizing(gfx::Point location) {
   }
 }
 
+void SplitViewDividerView::RefreshFeedbackButton(bool visible) {
+  if (!IsSnapGroupEnabledInClamshellMode()) {
+    return;
+  }
+
+  if (!feedback_button_) {
+    feedback_button_ = AddChildView(std::make_unique<IconButton>(
+        base::BindRepeating(&SplitViewDividerView::OnFeedbackButtonPressed,
+                            base::Unretained(this)),
+        IconButton::Type::kMediumFloating, &kFeedbackIcon,
+        IDS_ASH_SNAP_GROUP_SEND_FEEDBACK,
+        /*is_togglable=*/false,
+        /*has_border=*/false));
+    feedback_button_->SetPaintToLayer();
+    feedback_button_->layer()->SetFillsBoundsOpaquely(false);
+    feedback_button_->SetPreferredSize(kFeedbackButtonSize);
+    // TODO(michelefan): Apply `cros.sys.inverse-whiteblack` as the icon color
+    // currently it's not available in the system yet.
+    feedback_button_->SetVisible(true);
+    feedback_button_->SetBackground(views::CreateThemedRoundedRectBackground(
+        cros_tokens::kCrosSysSystemBaseElevated,
+        kFeedbackButtonSize.height() / 2.f));
+    feedback_button_->SetVisible(/*visible=*/false);
+    return;
+  }
+
+  feedback_button_->SetVisible(visible);
+}
+
 void SplitViewDividerView::EndResizing(gfx::Point location, bool swap_windows) {
   // `EndResizeWithDivider()` may cause this view to be destroyed.
   auto weak_ptr = weak_ptr_factory_.GetWeakPtr();
@@ -250,6 +314,11 @@ void SplitViewDividerView::EndResizing(gfx::Point location, bool swap_windows) {
   }
 }
 
+void SplitViewDividerView::OnFeedbackButtonPressed() {
+  // TODO(michelefan): Implement the callback for the feedback button.
+  base::DoNothing();
+}
+
 BEGIN_METADATA(SplitViewDividerView)
 END_METADATA
 

ash/wm/splitview/split_view_divider_view.h

@@ -12,6 +12,7 @@
 
 namespace ash {
 
+class IconButton;
 class SplitViewController;
 class SplitViewDivider;
 class SplitViewDividerHandlerView;
@@ -55,6 +56,13 @@ class SplitViewDividerView : public views::View,
   // `swap_windows` is true, swaps the windows after resizing.
   void EndResizing(gfx::Point location, bool swap_windows);
 
+  // Initializes or refreshes the visibility of the `feedback_button_` on the
+  // divider.
+  void RefreshFeedbackButton(bool visible);
+
+  // Triggered when the feedback button is pressed to open feedback form.
+  void OnFeedbackButtonPressed();
+
   // TODO(b/314018158): Replace with `LayoutDividerController`.
   raw_ptr<SplitViewController, DanglingUntriaged> split_view_controller_;
   raw_ptr<SplitViewDividerHandlerView> divider_handler_view_ = nullptr;
@@ -63,6 +71,8 @@ class SplitViewDividerView : public views::View,
   // Securely updates the cursor.
   CursorSetter cursor_setter_;
 
+  raw_ptr<IconButton> feedback_button_ = nullptr;
+
   base::WeakPtrFactory<SplitViewDividerView> weak_ptr_factory_{this};
 };