chromium/src
0
Fork 0
Code Activity

Undeprecate PPAPI WebSocket

Browse Source 
Remove the deprecation console message and documentation comments for
PPAPI WebSocket. This is mostly a straightforward revert of
https://chromium-review.googlesource.com/c/chromium/src/+/1161712/
except that the enums have been left behind.

See
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lWNvY56OAYs/9IoQx_ncDQAJ
for the background and justification for undoing the deprecation.

BUG=870586

Change-Id: I436e016b98e5e6224fca420ed769420f016bf6ac
Reviewed-on: https://chromium-review.googlesource.com/c/1402306
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622756}
This commit is contained in:
Adam Rice
2019-01-15 06:00:39 +00:00
committed by Commit Bot
parent cb56afc460
commit dfc22b6813
6 changed files with 2 additions and 17 deletions
ppapi
api
ppb_websocket.idl
c
ppb_websocket.h
cpp
websocket.h
utility
websocket
websocket_api.h
third_party/blink/renderer
core
frame
deprecation.cc
modules
websockets
web_pepper_socket_impl.cc

2
ppapi/api/ppb_websocket.idl

@ -177,8 +177,6 @@ enum PP_WebSocketCloseCode {
/**
* The <code>PPB_WebSocket</code> interface provides bi-directional,
* full-duplex, communications over a single TCP socket.
*
* This interface is deprecated and scheduled to be removed in mid-2019.
*/
interface PPB_WebSocket {
/**

4
ppapi/c/ppb_websocket.h

@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
/* From ppb_websocket.idl modified Fri Aug 3 14:53:49 2018. */
/* From ppb_websocket.idl modified Thu May 31 15:47:38 2012. */
#ifndef PPAPI_C_PPB_WEBSOCKET_H_
#define PPAPI_C_PPB_WEBSOCKET_H_
@ -178,8 +178,6 @@ PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_WebSocketCloseCode, 4);
/**
* The <code>PPB_WebSocket</code> interface provides bi-directional,
* full-duplex, communications over a single TCP socket.
*
* This interface is deprecated and scheduled to be removed in mid-2019.
*/
struct PPB_WebSocket_1_0 {
/**

1
ppapi/cpp/websocket.h

@ -27,7 +27,6 @@ class Var;
/// The <code>WebSocket</code> class providing bi-directional,
/// full-duplex, communications over a single TCP socket.
/// This class is deprecated and will be removed in mid 2019.
class WebSocket : public Resource {
public:
/// Constructs a WebSocket object.

3
ppapi/utility/websocket/websocket_api.h

@ -17,8 +17,7 @@ namespace pp {
class Instance;
class Var;
/// The <code>WebSocketAPI</code> class.
/// This class is deprecated and will be removed in mid-2019.
/// The <code>WebSocketAPI</code> class
class WebSocketAPI {
public:
/// Constructs a WebSocketAPI object.

6
third_party/blink/renderer/core/frame/deprecation.cc vendored

@ -592,12 +592,6 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
"5687444770914304 for more details",
MilestoneString(kM71))};
case WebFeature::kPPAPIWebSocket:
// TODO(ricea): Update once we have an expected release date for M74.
return {"PPAPIWebSocket", kUnknown,
"The Native Client Pepper WebSocket API is deprecated and will "
"be disabled in M74, mid-2019"};
case WebFeature::kCacheStorageAddAllSuccessWithDuplicate:
return {"CacheStorageAddAllSuccessWithDuplicate", kM72,
WillBeRemoved("Cache.addAll() with duplicate requests", kM72,

3
third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.cc vendored

@ -32,12 +32,10 @@
#include <stddef.h>
#include <memory>
#include "third_party/blink/public/platform/web_feature.mojom-shared.h"
#include "third_party/blink/public/platform/web_url.h"
#include "third_party/blink/public/web/web_array_buffer.h"
#include "third_party/blink/public/web/web_document.h"
#include "third_party/blink/renderer/core/dom/document.h"
#include "third_party/blink/renderer/core/frame/deprecation.h"
#include "third_party/blink/renderer/core/inspector/console_types.h"
#include "third_party/blink/renderer/core/typed_arrays/dom_array_buffer.h"
#include "third_party/blink/renderer/modules/websockets/web_pepper_socket_channel_client_proxy.h"
@ -66,7 +64,6 @@ WebPepperSocketImpl::WebPepperSocketImpl(const WebDocument& document,
Document* core_document = document;
private_ = WebSocketChannelImpl::Create(core_document, channel_proxy_.Get(),
SourceLocation::Capture());
Deprecation::CountDeprecation(*core_document, WebFeature::kPPAPIWebSocket);
DCHECK(private_);
}