chromium/src
0
Fork 0
Code Activity

Include Graphics.Pipeline trace event to 'graphics.pipeline' category.

Browse Source 
This would aid in performing scroll jank analysis with low-overhead
tracing and help with category management for tracing.

Bug: b/292050130
Change-Id: If6858484b8f9ebedca90ec9e1ea847c63512e5f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4748732
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Aman Verma <amanvr@google.com>
Cr-Commit-Position: refs/heads/main@{#1181495}
This commit is contained in:
Aman Verma
2023-08-09 15:30:19 +00:00
committed by Chromium LUCI CQ
parent b48228e443
commit e40f108410
8 changed files with 17 additions and 15 deletions

2
base/trace_event/builtin_categories.h

@ -94,6 +94,7 @@
X("gpu.angle") \
X("gpu.angle.texture_metrics") \
X("gpu.capture") \
X("graphics.pipeline") \
X("headless") \
/* Traces for //components/history. */ \
X("history") \
@ -372,6 +373,7 @@
X("v8,devtools.timeline") \
X("v8,devtools.timeline," TRACE_DISABLED_BY_DEFAULT("v8.compile")) \
X("viz,benchmark") \
X("viz,benchmark,graphics.pipeline") \
X("WebCore,benchmark,rail") \
X(TRACE_DISABLED_BY_DEFAULT("cc.debug") "," TRACE_DISABLED_BY_DEFAULT( \
"viz.quads") "," TRACE_DISABLED_BY_DEFAULT("devtools.timeline.layers")) \

8
cc/mojo_embedder/async_layer_tree_frame_sink.cc

@ -174,7 +174,7 @@ void AsyncLayerTreeFrameSink::SubmitCompositorFrame(
DCHECK(frame.metadata.begin_frame_ack.frame_id.IsSequenceValid());
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(frame.metadata.begin_frame_ack.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -255,7 +255,7 @@ void AsyncLayerTreeFrameSink::DidNotProduceFrame(const viz::BeginFrameAck& ack,
DCHECK(!ack.has_damage);
DCHECK(ack.frame_id.IsSequenceValid());
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(ack.trace_id), [&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
auto* data = event->set_chrome_graphics_pipeline();
@ -313,7 +313,7 @@ void AsyncLayerTreeFrameSink::OnBeginFrame(
if (!needs_begin_frames_) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(adjusted_args.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -329,7 +329,7 @@ void AsyncLayerTreeFrameSink::OnBeginFrame(
return;
}
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(adjusted_args.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();

4
cc/slim/frame_sink_impl.cc

@ -313,7 +313,7 @@ bool FrameSinkImpl::DoBeginFrame(const viz::BeginFrameArgs& begin_frame_args) {
{
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(begin_frame_args.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -337,7 +337,7 @@ bool FrameSinkImpl::DoBeginFrame(const viz::BeginFrameArgs& begin_frame_args) {
void FrameSinkImpl::SendDidNotProduceFrame(
const viz::BeginFrameArgs& begin_frame_args) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(begin_frame_args.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();

2
cc/slim/layer_tree_impl.cc

@ -443,7 +443,7 @@ void LayerTreeImpl::GenerateCompositorFrame(
base::flat_set<viz::ResourceId>& out_resource_ids,
viz::HitTestRegionList& out_hit_test_region_list) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(args.trace_id), [&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
auto* data = event->set_chrome_graphics_pipeline();

4
cc/trees/layer_tree_host_impl.cc

@ -1545,7 +1545,7 @@ DrawResult LayerTreeHostImpl::PrepareToDraw(FrameData* frame) {
TRACE_EVENT1("cc", "LayerTreeHostImpl::PrepareToDraw", "SourceFrameNumber",
active_tree_->source_frame_number());
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(CurrentBeginFrameArgs().trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -2601,7 +2601,7 @@ absl::optional<LayerTreeHostImpl::SubmitInfo> LayerTreeHostImpl::DrawLayers(
viz::CompositorFrame LayerTreeHostImpl::GenerateCompositorFrame(
FrameData* frame) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(CurrentBeginFrameArgs().trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();

2
cc/trees/proxy_impl.cc

@ -702,7 +702,7 @@ void ProxyImpl::ScheduledActionSendBeginMainFrame(
host_impl_->WillSendBeginMainFrame();
{
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::TerminatingFlow::Global(args.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();

4
components/viz/service/display/surface_aggregator.cc

@ -868,7 +868,7 @@ void SurfaceAggregator::EmitSurfaceContent(
extra_content_scale_y);
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(frame.metadata.begin_frame_ack.trace_id),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -2184,7 +2184,7 @@ AggregatedFrame SurfaceAggregator::Aggregate(
const CompositorFrame& root_surface_frame =
surface->GetActiveOrInterpolatedFrame();
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(
root_surface_frame.metadata.begin_frame_ack.trace_id),
[&](perfetto::EventContext ctx) {

6
components/viz/service/frame_sinks/compositor_frame_sink_support.cc

@ -506,7 +506,7 @@ bool CompositorFrameSinkSupport::IsRoot() const {
void CompositorFrameSinkSupport::DidNotProduceFrame(const BeginFrameAck& ack) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global(ack.trace_id), [&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
auto* data = event->set_chrome_graphics_pipeline();
@ -569,7 +569,7 @@ SubmitResult CompositorFrameSinkSupport::MaybeSubmitCompositorFrame(
uint64_t submit_time,
mojom::CompositorFrameSink::SubmitCompositorFrameSyncCallback callback) {
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global((frame.metadata.begin_frame_ack.trace_id)),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
@ -936,7 +936,7 @@ void CompositorFrameSinkSupport::OnBeginFrame(const BeginFrameArgs& args) {
adjusted_args.trace_id = ComputeTraceId();
TRACE_EVENT(
"viz,benchmark", "Graphics.Pipeline",
"viz,benchmark,graphics.pipeline", "Graphics.Pipeline",
perfetto::Flow::Global((adjusted_args.trace_id)),
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();