chromium/src
0
Fork 0
Code Activity

Remove use of FPDF_NO_CATCH in PDFium integration code.

Browse Source 
The flag is a no-op and will be deprecated/removed in the future.

Change-Id: I51532a2bc2b8e03f0489b2ac05589101d709d0c1
Reviewed-on: https://chromium-review.googlesource.com/c/1312310
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604585}
This commit is contained in:
Lei Zhang
2018-11-01 15:00:11 +00:00
committed by Commit Bot
parent b16aeb4251
commit e4f9ce4776
3 changed files with 4 additions and 4 deletions

2
pdf/pdfium/pdfium_engine.cc

@ -3221,7 +3221,7 @@ void PDFiumEngine::GetPDFiumRect(int page_index,
}
int PDFiumEngine::GetRenderingFlags() const {
int flags = FPDF_LCD_TEXT | FPDF_NO_CATCH;
int flags = FPDF_LCD_TEXT;
if (render_grayscale_)
flags |= FPDF_GRAYSCALE;
if (client_->IsPrintPreview())

4
pdf/pdfium/pdfium_engine_exports.cc

@ -192,7 +192,7 @@ bool PDFiumEngineExports::RenderPDFPageToDC(
settings.bounds.x() + settings.bounds.width(),
settings.bounds.y() + settings.bounds.height());
int flags = FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH;
int flags = FPDF_ANNOT | FPDF_PRINTING;
if (!settings.use_color)
flags |= FPDF_GRAYSCALE;
@ -272,7 +272,7 @@ bool PDFiumEngineExports::RenderPDFPageToBitmap(
// Shift top-left corner of bounds to (0, 0) if it's not there.
dest.set_point(dest.point() - settings.bounds.point());
int flags = FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH;
int flags = FPDF_ANNOT | FPDF_PRINTING;
if (!settings.use_color)
flags |= FPDF_GRAYSCALE;

2
pdf/pdfium/pdfium_print.cc

@ -413,7 +413,7 @@ ScopedFPDFDocument PDFiumPrint::CreateSinglePageRasterPdf(
FPDF_RenderPageBitmap(bitmap.get(), page_to_print, 0, 0, bitmap_size.width(),
bitmap_size.height(), print_settings.orientation,
FPDF_PRINTING | FPDF_NO_CATCH);
FPDF_PRINTING);
unsigned char* bitmap_data =
static_cast<unsigned char*>(FPDFBitmap_GetBuffer(bitmap.get()));