chromium/src
0
Fork 0
Code Activity

Remove usage of base::make_span(): ppapi/

Browse Source 
Replace with span() CTAD use, or more targeted helpers.

Bug: 341907909
Change-Id: If26e3397f8b9022185bb18f4930dbbc9ef33e3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6058258
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1390456}
This commit is contained in:
Peter Kasting
2024-12-02 18:15:15 +00:00
committed by Chromium LUCI CQ
parent 4672dfdbe6
commit e51e0cb73b
1 changed files with 4 additions and 5 deletions

9
ppapi/shared_impl/private/ppb_x509_util_shared.cc

@ -53,9 +53,8 @@ bool PPB_X509Util_Shared::GetCertificateFields(
PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME,
base::Value(base::JoinString(subject.organization_unit_names, "\n")));
fields->SetField(
PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER,
base::Value(base::as_bytes(base::make_span(cert.serial_number()))));
fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER,
base::Value(base::as_byte_span(cert.serial_number())));
fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE,
base::Value(cert.valid_start().InSecondsFSinceUnixEpoch()));
fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER,
@ -63,7 +62,7 @@ bool PPB_X509Util_Shared::GetCertificateFields(
std::string_view cert_der =
net::x509_util::CryptoBufferAsStringPiece(cert.cert_buffer());
fields->SetField(PP_X509CERTIFICATE_PRIVATE_RAW,
base::Value(base::as_bytes(base::make_span(cert_der))));
base::Value(base::as_byte_span(cert_der)));
return true;
}
@ -73,7 +72,7 @@ bool PPB_X509Util_Shared::GetCertificateFields(
ppapi::PPB_X509Certificate_Fields* fields) {
scoped_refptr<net::X509Certificate> cert =
net::X509Certificate::CreateFromBytes(
base::as_bytes(base::make_span(der, length)));
base::as_bytes(base::span(der, length)));
if (!cert)
return false;
return GetCertificateFields(*cert, fields);