chromium/src
0
Fork 0
Code Activity

[CrOS Hotspot] Capitalizing hotspot consistently across all surfaces

Browse Source 
As per UXW, hotspot should only be capitalized when it is the first word
of the sentence. This change modifies strings as per their
recommendation.

Bug: b/303925197
Change-Id: I85cb05827dd86b55715a753539c84bae593ab1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988969
Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com>
Reviewed-by: Jeffrey Young <cowmoo@google.com>
Cr-Commit-Position: refs/heads/main@{#1218956}
This commit is contained in:
Nikhil Nayunigari
2023-11-02 17:55:33 +00:00
committed by Chromium LUCI CQ
parent 8c45f7b243
commit e54b12e862
10 changed files with 23 additions and 23 deletions

12
ash/ash_strings.grd

@ -2966,16 +2966,16 @@ Some features are limited to increase battery life.
Show hotspot details. Hotspot is off.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_OFF" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is off and is allowed to turn on.">
Toggle Hotspot. Hotspot is off.
Toggle hotspot. Hotspot is off.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_NO_DEVICE_CONNECTED" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is on and no device connected.">
Toggle Hotspot. Hotspot is on, no device connected.
Toggle hotspot. Hotspot is on, no device connected.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_ONE_DEVICE_CONNECTED" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is on and one device connected.">
Toggle Hotspot. Hotspot is on, 1 device connected.
Toggle hotspot. Hotspot is on, 1 device connected.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_MULTIPLE_DEVICES_CONNECTED" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is on and multiple devices connected.">
Toggle Hotspot. Hotspot is on, <ph name="DEVICECOUNT">$1</ph> devices connected.
Toggle hotspot. Hotspot is on, <ph name="DEVICECOUNT">$1</ph> devices connected.
</message>
<message name="IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_NO_MOBILE_DATA" desc="The tooltip for the hotspot feature tile of quick settings when hotspot is off and not allowed to turn on due to no mobile data connection.">
Show hotspot details. Connect to mobile network to use hotspot.
@ -3050,10 +3050,10 @@ Some features are limited to increase battery life.
Turn on WiFi instead
</message>
<message name="IDS_ASH_HOTSPOT_WIFI_TURNED_ON_MESSAGE" desc="Message displayed in the system notification shown when hotspot is disabled due to WiFi being turned on.">
Hotspot has been turned off to use WiFi. To use Hotspot, turn WiFi off.
Hotspot has been turned off to use WiFi. To use hotspot, turn WiFi off.
</message>
<message name="IDS_ASH_HOTSPOT_ADMIN_RESTRICTED_MESSAGE" desc="Message displayed in the system notification shown when the hotspot is turned off by the administrator.">
Your administrator has turned Hotspot off.
Your administrator has turned hotspot off.
</message>
<message name="IDS_ASH_HOTSPOT_AUTO_DISABLED_MESSAGE" desc="Message displayed in the system notification shown when the hotspot is turned off due to inactivity.">
Due to inactivity, hotspot has been turned off.

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_ADMIN_RESTRICTED_MESSAGE.png.sha1

@ -1 +1 @@
75fbfe3701728a1fce39c3ce3f064b258d456936
67c404d5dd84346ea0d6a8d807f73069642d2d67

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_WIFI_TURNED_ON_MESSAGE.png.sha1

@ -1 +1 @@
6e5e4264f14a3000f4ca776dcf237888efdfaf6f
edb136c3d871f125f26a56dadd1c3ffdf4bdfc92

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_OFF.png.sha1

@ -1 +1 @@
64b741721332364c5d2a5d951898933993fcdda7
3062eb2613bb1e81fb0209c931213678a5040f38

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_MULTIPLE_DEVICES_CONNECTED.png.sha1

@ -1 +1 @@
6c134e3c9cb6714996a0d2794300c1bb095e0a39
13ddace12a7cfd1282a7143d09ef7ebf0f97cde4

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_NO_DEVICE_CONNECTED.png.sha1

@ -1 +1 @@
bf72ac7d49653af5475f0ce49f7d3c83574e57e0
e3dbf43465573f5138715432efbc02366f8cc486

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_HOTSPOT_FEATURE_TILE_TOOLTIP_STATUS_ON_ONE_DEVICE_CONNECTED.png.sha1

@ -1 +1 @@
c4b92a5cb8784878a33c00417d1405629269b920
cc2e50195e61545a6031d2fe03b33e51298b0e66

18
ash/system/hotspot/hotspot_feature_pod_controller_unittest.cc

@ -150,12 +150,12 @@ TEST_F(HotspotFeaturePodControllerTest, PressLabelWhenHotspotEnabled) {
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"On", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is on, no device connected.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, no device connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is on.",
hotspot_feature_tile_->GetTooltipText());
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed, 2);
EXPECT_EQ(u"Toggle Hotspot. Hotspot is on, 2 devices connected.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, 2 devices connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_STREQ(kHotspotOnIcon.name, GetVectorIconName());
@ -175,7 +175,7 @@ TEST_F(HotspotFeaturePodControllerTest, PressIconWhenHotspotEnabled) {
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"On", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is on, no device connected.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, no device connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is on.",
hotspot_feature_tile_->GetTooltipText());
@ -252,9 +252,9 @@ TEST_F(HotspotFeaturePodControllerTest,
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_STREQ(kHotspotOffIcon.name, GetVectorIconName());
@ -276,9 +276,9 @@ TEST_F(HotspotFeaturePodControllerTest,
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_STREQ(kHotspotOffIcon.name, GetVectorIconName());
@ -384,9 +384,9 @@ TEST_F(HotspotFeaturePodControllerTest, LockScreen) {
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle Hotspot. Hotspot is off.",
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_STREQ(kHotspotOffIcon.name, GetVectorIconName());

2
chrome/app/os_settings_strings.grdp

@ -4003,7 +4003,7 @@ Press an assigned switch or key to remove assignment.
When no devices are connected
</message>
<message name="IDS_SETTINGS_INTERNET_HOTSPOT_SETTINGS_TITLE" desc="Settings > Network > Hotspot > Configure hotspot dialog: Title for the hotspot configuration dialog.">
Configure <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> Hotspot
Configure <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> hotspot
</message>
<message name="IDS_SETTINGS_INTERNET_HOTSPOT_SETTINGS_SUBTITLE_WITH_LEARN_MORE_LINK" desc="Subtitle of the hotspot configuration dialog which explains that creating a WiFi hotspot to provide internet to other devices.">
Create a Wi-Fi hotspot using your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>'s mobile data to provide internet to other devices. <ph name="BEGIN_LINK_LEARN_MORE">&lt;a target="_blank" href="$2"&gt;</ph>Learn more<ph name="END_LINK_LEARN_MORE">&lt;/a&gt;</ph>

2
chrome/app/os_settings_strings_grdp/IDS_SETTINGS_INTERNET_HOTSPOT_SETTINGS_TITLE.png.sha1

@ -1 +1 @@
fcbb66faad6e8c836c74bae2113fe0a430e4ea66
813304d9d33135d331851cbfb97b57097801e4f9