0

Move inactive GPU testers to separate console

Moves inactive GPU experimental testers to the new
chromium.gpu.experimental console. This console is intended to be used
for parking inactive GPU experimental testers until they are needed
again in order to declutter the chromium.gpu.fyi console.

These testers have already been paused.

Bug: 1280441
Change-Id: If035c502b40a88c3dd54da5dd6236c6e88dcfb57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345549
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#955514}
This commit is contained in:
Brian Sheedy
2022-01-05 02:03:09 +00:00
committed by Chromium LUCI CQ
parent 34809a93b6
commit e5afe42b31
6 changed files with 102 additions and 75 deletions

@ -412,8 +412,9 @@ Builder].
don't run on certain Win bots because of missing OpenGL extensions.
1. Run [`generate_buildbot_json.py`][generate_buildbot_json.py] to
regenerate `src/testing/buildbot/chromium.gpu.fyi.json`.
1. Updates [`ci.star`][ci.star] and its related generated files
[`cr-buildbucket.cfg`][cr-buildbucket.cfg],
1. Updates [`chromium.gpu.star`][chromium.gpu.star] or
[`chromium.gpu.fyi.star`][chromium.gpu.fyi.star] and its related
generated files [`cr-buildbucket.cfg`][cr-buildbucket.cfg],
[`luci-scheduler.cfg`][luci-scheduler.cfg], and
[`luci-milo.cfg`][luci-milo.cfg]:
* Use the appropriate definition for the type of the bot being added,
@ -484,9 +485,8 @@ breaking as seen in [this bug][misconfigured builder bug].
[How to add a new manually-triggered trybot]: https://chromium.googlesource.com/chromium/src/+/main/docs/gpu/gpu_testing_bot_details.md#How-to-add-a-new-manually_triggered-trybot
[ci.star]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/subprojects/ci.star
[chromium.gpu.star]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/consoles/chromium.gpu.star
[chromium.gpu.fyi.star]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/consoles/chromium.gpu.fyi.star
[chromium.gpu.star]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/subprojects/ci/chromium.gpu.star
[chromium.gpu.fyi.star]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/subprojects/ci/chromium.gpu.fyi.star
[cr-buildbucket.cfg]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/generated/cr-buildbucket.cfg
[luci-scheduler.cfg]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/generated/luci-scheduler.cfg
[luci-milo.cfg]: https://chromium.googlesource.com/chromium/src/+/main/infra/config/generated/luci-milo.cfg
@ -683,10 +683,12 @@ or OS update. To do this:
waterfall](#How-to-add-a-new-tester-bot-to-the-chromium_gpu_fyi-waterfall)
to deploy one. However, you do not need to request additional GCE resources
since there should be enough spare capacity in the GPU builderless pool to
handle them.
1. If an "experimental" version does already exist, move it from the
`chromium.gpu.experimental` console to its default console in
[`ci.star`][ci.star] and unpause it in the [luci scheduler].
handle them. Additionally, ensure that the bot definition in
[`chromium.gpu.fyi.star`][chromium.gpu.fyi.star] includes a `list_view`
argument specifying `chromium.gpu.experimental`.
1. If an "experimental" version does already exist, re-add it to its default
console in [`chromium.gpu.fyi.star`][chromium.gpu.fyi.star] by uncommenting
its `console_view_entry` argument and unpause it in the [luci scheduler].
1. Have this experimental bot target the new version of the driver or the OS
in [`waterfalls.pyl`][waterfalls.pyl] and [`mixins.pyl`][mixins.pyl].
[Sample CL][sample driver cl].
@ -724,9 +726,8 @@ or OS update. To do this:
1. Remove the old driver or OS version from the `_stable` mixin, leaving just
the new stable version.
1. Clean up the "experimental" version of the bot by pausing it in the
[luci scheduler] and moving it to the `chromium.gpu.experimental` console in
[`ci.star`][ci.star]. This is done by adding a `console_view` argument to
its `console_view_entry`.
[luci scheduler] and commenting out its `console_view_entry` argument in
[`chromium.gpu.fyi.star`][chromium.gpu.fyi.star].
Note that we leave the experimental bot in place. We could reclaim it, but it
seems worthwhile to continuously test the "next" version of graphics drivers as

@ -5282,21 +5282,11 @@ consoles {
category: "ToT|Mac|Builder"
short_name: "x64"
}
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Experimental Release (AMD)"
category: "ToT|Mac|AMD"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Release (AMD)"
category: "ToT|Mac|AMD"
short_name: "x64"
}
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Experimental Release (Intel)"
category: "ToT|Mac|Intel"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Release (Intel)"
category: "ToT|Mac|Intel"
@ -7985,6 +7975,38 @@ consoles {
tree_status_host: "chromium-status.appspot.com"
}
}
consoles {
id: "chromium.gpu.experimental"
name: "chromium.gpu.experimental"
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Experimental Release (AMD)"
}
builders {
name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Experimental Release (Intel)"
}
builders {
name: "buildbucket/luci.chromium.ci/Linux FYI Experimental Release (Intel HD 630)"
}
builders {
name: "buildbucket/luci.chromium.ci/Linux FYI Experimental Release (NVIDIA)"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI Experimental Release (Intel)"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI Experimental Retina Release (AMD)"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI Experimental Retina Release (NVIDIA)"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 Exp Release (Intel HD 630)"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 Exp Release (NVIDIA)"
}
builder_view_only: true
}
consoles {
id: "chromium.gpu.fyi"
name: "chromium.gpu.fyi"
@ -8031,11 +8053,6 @@ consoles {
category: "Windows|10|x64|Intel"
short_name: "rel"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 Exp Release (Intel HD 630)"
category: "Windows|10|x64|Intel"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 Release (NVIDIA)"
category: "Windows|10|x64|Nvidia"
@ -8046,11 +8063,6 @@ consoles {
category: "Windows|10|x64|Nvidia"
short_name: "dbg"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 Exp Release (NVIDIA)"
category: "Windows|10|x64|Nvidia"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Win10 FYI x64 SkiaRenderer Dawn Release (NVIDIA)"
category: "Windows|10|x64|Nvidia"
@ -8151,11 +8163,6 @@ consoles {
category: "Mac|Intel"
short_name: "dbg"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI Experimental Release (Intel)"
category: "Mac|Intel"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI ASAN (Intel)"
category: "Mac|Intel"
@ -8171,11 +8178,6 @@ consoles {
category: "Mac|Nvidia"
short_name: "dbg"
}
builders {
name: "buildbucket/luci.chromium.ci/Mac FYI Experimental Retina Release (NVIDIA)"
category: "Mac|Nvidia"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Linux FYI GPU TSAN Release"
category: "Linux"
@ -8231,11 +8233,6 @@ consoles {
category: "Linux|Nvidia"
short_name: "dbg"
}
builders {
name: "buildbucket/luci.chromium.ci/Linux FYI Experimental Release (NVIDIA)"
category: "Linux|Nvidia"
short_name: "exp"
}
builders {
name: "buildbucket/luci.chromium.ci/Linux FYI SkiaRenderer Vulkan (NVIDIA)"
category: "Linux|Nvidia"

@ -135,6 +135,7 @@ exec("./ci/chromium.dawn.star")
exec("./ci/chromium.fuzz.star")
exec("./ci/chromium.fyi.star")
exec("./ci/chromium.gpu.star")
exec("./ci/chromium.gpu.experimental.star")
exec("./ci/chromium.gpu.fyi.star")
exec("./ci/chromium.linux.star")
exec("./ci/chromium.mac.star")

@ -144,19 +144,23 @@ ci.thin_tester(
ci.thin_tester(
name = "Dawn Mac x64 Experimental Release (AMD)",
console_view_entry = consoles.console_view_entry(
category = "ToT|Mac|AMD",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "ToT|Mac|AMD",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["Dawn Mac x64 Builder"],
)
ci.thin_tester(
name = "Dawn Mac x64 Experimental Release (Intel)",
console_view_entry = consoles.console_view_entry(
category = "ToT|Mac|Intel",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "ToT|Mac|Intel",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["Dawn Mac x64 Builder"],
)

@ -0,0 +1,12 @@
# Copyright 2021 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Definitions of builders in the chromium.gpu.experimental builder group."""
load("//lib/consoles.star", "consoles")
# This view is intended for parking inactive experimental testers until they are
# needed again in order to declutter chromium.gpu.fyi.
consoles.list_view(
name = "chromium.gpu.experimental",
)

@ -265,15 +265,18 @@ ci.thin_tester(
category = "Linux|Intel",
short_name = "exp",
),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Linux Builder"],
)
ci.thin_tester(
name = "Linux FYI Experimental Release (NVIDIA)",
console_view_entry = consoles.console_view_entry(
category = "Linux|Nvidia",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "Linux|Nvidia",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Linux Builder"],
)
@ -345,10 +348,12 @@ ci.thin_tester(
ci.thin_tester(
name = "Mac FYI Experimental Release (Intel)",
console_view_entry = consoles.console_view_entry(
category = "Mac|Intel",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "Mac|Intel",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Mac Builder"],
)
@ -358,15 +363,18 @@ ci.thin_tester(
category = "Mac|AMD|Retina",
short_name = "exp",
),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Mac Builder"],
)
ci.thin_tester(
name = "Mac FYI Experimental Retina Release (NVIDIA)",
console_view_entry = consoles.console_view_entry(
category = "Mac|Nvidia",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "Mac|Nvidia",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
# This bot has one machine backing its tests at the moment.
# If it gets more, this can be removed.
# See crbug.com/853307 for more context.
@ -484,19 +492,23 @@ ci.thin_tester(
ci.thin_tester(
name = "Win10 FYI x64 Exp Release (Intel HD 630)",
console_view_entry = consoles.console_view_entry(
category = "Windows|10|x64|Intel",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "Windows|10|x64|Intel",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Win x64 Builder"],
)
ci.thin_tester(
name = "Win10 FYI x64 Exp Release (NVIDIA)",
console_view_entry = consoles.console_view_entry(
category = "Windows|10|x64|Nvidia",
short_name = "exp",
),
# Uncomment this entry when this experimental tester is actually in use.
# console_view_entry = consoles.console_view_entry(
# category = "Windows|10|x64|Nvidia",
# short_name = "exp",
# ),
list_view = "chromium.gpu.experimental",
triggered_by = ["GPU FYI Win x64 Builder"],
)