chromium/src
0
Fork 0
Code Activity

Get Chrome to build & link with USE_AURA on Windows again.BUG=noneTEST=none

Browse Source 
Review URL: http://codereview.chromium.org/8174005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104382 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
ben@chromium.org
2011-10-06 22:55:28 +00:00
parent ef402c3ba1
commit e5b307fe28
18 changed files with 48 additions and 40 deletions

5
build/common.gypi

@ -309,6 +309,11 @@
'file_manager_extension%': 0,
}],
# ... except on Windows even with Aura.
['use_aura==1 and OS=="win"', {
'file_manager_extension%': 0,
}],
# Enable WebUI TaskManager only on Chrome OS, Touch or PureView.
['chromeos==1 or touchui==1 or use_only_pure_views==1 or use_aura==1', {
'webui_task_manager%': 1,

5
chrome/browser/chrome_browser_main.cc

@ -200,7 +200,8 @@
#endif
#if defined(USE_AURA)
#include "chrome/browser/ui/views/aura/aura_init.h"
#include "ui/aura/desktop.h"
#include "ui/aura_shell/shell_factory.h"
#include "ui/aura/desktop.h"
#endif
@ -1367,7 +1368,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunInternal() {
child_process_logging::SetCommandLine(CommandLine::ForCurrentProcess());
#if defined(USE_AURA)
browser::InitAuraDesktop();
aura_shell::InitDesktopWindow();
#elif defined(TOOLKIT_VIEWS)
views::Widget::SetPureViews(
CommandLine::ForCurrentProcess()->HasSwitch(switches::kUsePureViews));

2
chrome/browser/chrome_browser_main_win.cc

@ -74,11 +74,13 @@ void WarnAboutMinimumSystemRequirements() {
}
}
#if !defined(USE_AURA)
void ShowMissingLocaleMessageBox() {
ui::MessageBox(NULL, ASCIIToUTF16(chrome_browser::kMissingLocaleDataMessage),
ASCIIToUTF16(chrome_browser::kMissingLocaleDataTitle),
MB_OK | MB_ICONERROR | MB_TOPMOST);
}
#endif
void RecordBrowserStartupTime() {
// Calculate the time that has elapsed from our own process creation.

2
chrome/browser/process_singleton.h

@ -78,7 +78,7 @@ class ProcessSingleton : public base::NonThreadSafe {
int timeout_seconds);
#endif // defined(OS_LINUX)
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
// Used in specific cases to let us know that there is an existing instance
// of Chrome running with this profile. In general, you should not use this
// function. Instead consider using NotifyOtherProcessOrCreate().

2
chrome/browser/process_singleton_aura.cc

@ -7,7 +7,7 @@
// Look for a Chrome instance that uses the same profile directory.
ProcessSingleton::ProcessSingleton(const FilePath& user_data_dir)
:
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
window_(NULL),
#endif
locked_(false), foreground_window_(NULL) {

6
chrome/browser/renderer_host/render_widget_host_view_views_win.cc

@ -10,17 +10,15 @@
#endif
#include "views/widget/widget.h"
#if !defined(USE_AURA)
// static
RenderWidgetHostView* RenderWidgetHostView::CreateViewForWidget(
RenderWidgetHost* widget) {
#if !defined(USE_AURA)
if (views::Widget::IsPureViews())
#endif
return new RenderWidgetHostViewViews(widget);
#if !defined(USE_AURA)
return new RenderWidgetHostViewWin(widget);
#endif
}
#endif
void RenderWidgetHostViewViews::UpdateCursor(const WebCursor& cursor) {
}

8
chrome/browser/ui/toolbar/wrench_menu_model.cc

@ -525,9 +525,13 @@ void WrenchMenuModel::Build() {
AddSeparator();
}
#if defined(OS_MACOSX)
#if defined(USE_AURA)
#if defined(OS_WIN)
AddItemWithStringId(IDC_OPTIONS, IDS_OPTIONS);
#else
AddItemWithStringId(IDC_OPTIONS, IDS_PREFERENCES);
#elif defined(USE_AURA)
#endif
#elif defined(OS_MACOSX)
AddItemWithStringId(IDC_OPTIONS, IDS_PREFERENCES);
#elif defined(TOOLKIT_USES_GTK)
string16 preferences = gtk_util::GetStockPreferencesMenuLabel();

12
chrome/browser/ui/views/dropdown_bar_host.cc

@ -18,22 +18,22 @@
#include "views/focus/view_storage.h"
#include "views/widget/widget.h"
#if defined(OS_WIN)
#if defined(USE_AURA)
#include "ui/gfx/scoped_sk_region.h"
#elif defined(OS_WIN)
#include "base/win/scoped_gdi_object.h"
#elif defined(TOOLKIT_USES_GTK)
#include "ui/base/gtk/scoped_handle_gtk.h"
#else
#include "ui/gfx/scoped_sk_region.h"
#endif
namespace {
#if defined(OS_WIN)
#if defined(USE_AURA)
typedef gfx::ScopedSkRegion ScopedPlatformRegion;
#elif defined(OS_WIN)
typedef base::win::ScopedRegion ScopedPlatformRegion;
#elif defined(TOOLKIT_USES_GTK)
typedef ui::ScopedRegion ScopedPlatformRegion;
#else
typedef gfx::ScopedSkRegion ScopedPlatformRegion;
#endif
} // namespace

4
chrome/browser/ui/views/shell_dialogs_aura.cc

@ -10,5 +10,9 @@
// static
SelectFileDialog* SelectFileDialog::Create(Listener* listener) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
#if defined(OS_WIN)
return NULL;
#else
return new FileManagerDialog(listener);
#endif
}

10
chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

@ -96,13 +96,3 @@ gfx::NativeViewAccessible
NOTIMPLEMENTED();
return View::GetNativeViewAccessible();
}
////////////////////////////////////////////////////////////////////////////////
// NativeTabContentsContainer, public:
// static
NativeTabContentsContainer* NativeTabContentsContainer::CreateNativeContainer(
TabContentsContainer* container) {
return new NativeTabContentsContainerViews(container);
// TODO(beng): return new NativeTabContentsContainerAura(container);
}

2
content/browser/renderer_host/render_message_filter_aura.cc

@ -4,6 +4,8 @@
#include "content/browser/renderer_host/render_message_filter.h"
#include "ui/gfx/rect.h"
// TODO(shess): Provide a mapping from reply_msg->routing_id() to HWND
// so that we can eliminate the NativeViewId parameter.
#if defined(OS_WIN)

6
content/plugin/webplugin_delegate_stub.cc

@ -110,7 +110,7 @@ bool WebPluginDelegateStub::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(PluginMsg_SendJavaScriptStream,
OnSendJavaScriptStream)
IPC_MESSAGE_HANDLER(PluginMsg_SetContentAreaFocus, OnSetContentAreaFocus)
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
IPC_MESSAGE_HANDLER(PluginMsg_ImeCompositionUpdated,
OnImeCompositionUpdated)
IPC_MESSAGE_HANDLER(PluginMsg_ImeCompositionCompleted,
@ -330,7 +330,7 @@ void WebPluginDelegateStub::OnSetContentAreaFocus(bool has_focus) {
delegate_->SetContentAreaHasFocus(has_focus);
}
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
void WebPluginDelegateStub::OnImeCompositionUpdated(
const string16& text,
const std::vector<int>& clauses,
@ -338,7 +338,7 @@ void WebPluginDelegateStub::OnImeCompositionUpdated(
int cursor_position) {
if (delegate_)
delegate_->ImeCompositionUpdated(text, clauses, target, cursor_position);
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
webplugin_->UpdateIMEStatus();
#endif
}

2
content/plugin/webplugin_delegate_stub.h

@ -81,7 +81,7 @@ class WebPluginDelegateStub : public IPC::Channel::Listener,
void OnGetFormValue(string16* value, bool* success);
void OnSetContentAreaFocus(bool has_focus);
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
void OnImeCompositionUpdated(const string16& text,
const std::vector<int>& clauses,
const std::vector<int>& target,

2
content/plugin/webplugin_proxy.cc

@ -748,7 +748,7 @@ void WebPluginProxy::URLRedirectResponse(bool allow, int resource_id) {
Send(new PluginHostMsg_URLRedirectResponse(route_id_, allow, resource_id));
}
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
void WebPluginProxy::UpdateIMEStatus() {
// Retrieve the IME status from a plug-in and send it to a renderer process
// when the plug-in has updated it.

2
content/plugin/webplugin_proxy.h

@ -168,7 +168,7 @@ class WebPluginProxy : public webkit::npapi::WebPlugin {
virtual void URLRedirectResponse(bool allow, int resource_id);
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
// Retrieves the IME status from a windowless plug-in and sends it to a
// renderer process. A renderer process will convert the coordinates from
// local to the window coordinates and send the converted coordinates to a

6
printing/printed_document_aura.cc

@ -8,11 +8,13 @@
namespace printing {
void PrintedDocument::RenderPrintedPage(
const PrintedPage& page, PrintingContext* context) const {
#if defined(OS_POSIX)
void PrintedDocument::RenderPrintedPage(const PrintedPage& page,
PrintingContext* context) const {
// TODO(saintlou): This a stub to allow us to build under Aura.
// See issue: http://crbug.com/99282
NOTIMPLEMENTED();
}
#endif
} // namespace printing

4
views/views.gyp

@ -500,14 +500,14 @@
}],
['touchui==0', {
'sources!': [
'controls/menu/native_menu_views.cc',
'controls/menu/native_menu_views.h',
'touchui/touch_selection_controller_impl.cc',
'touchui/touch_selection_controller_impl.h',
],
}],
['touchui==0 and use_aura==0', {
'sources!': [
'controls/menu/native_menu_views.cc',
'controls/menu/native_menu_views.h',
'widget/tooltip_manager_views.cc',
],
}],

8
webkit/plugins/npapi/webplugin_delegate_impl.h

@ -55,7 +55,7 @@ class QuickDrawDrawingManager;
#endif // NP_NO_QUICKDRAW
#endif // OS_MACOSX
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
class WebPluginIMEWin;
#endif // OS_WIN
@ -147,7 +147,7 @@ class WebPluginDelegateImpl : public WebPluginDelegate {
// Informs the plugin that the view it is in has gained or lost focus.
void SetContentAreaHasFocus(bool has_focus);
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
// Informs the plug-in that an IME has changed its status.
void ImeCompositionUpdated(const string16& text,
const std::vector<int>& clauses,
@ -331,7 +331,7 @@ class WebPluginDelegateImpl : public WebPluginDelegate {
WebPlugin* plugin_;
scoped_refptr<PluginInstance> instance_;
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
// Original wndproc before we subclassed.
WNDPROC plugin_wnd_proc_;
@ -371,7 +371,7 @@ class WebPluginDelegateImpl : public WebPluginDelegate {
gfx::Rect clip_rect_;
int quirks_;
#if defined(OS_WIN)
#if defined(OS_WIN) && !defined(USE_AURA)
// Windowless plugins don't have keyboard focus causing issues with the
// plugin not receiving keyboard events if the plugin enters a modal
// loop like TrackPopupMenuEx or MessageBox, etc.