Remove flags for new authentication api on windows
This CL removes 2 flags that were used to rollout the new authentication api on windows. The feature is now enabled by default. Bug: 373486422 Change-Id: Ib12f8b383846306d1dc2b7466bdb69a89def2865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937071 Commit-Queue: Karol Sygiet <sygiet@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1369409}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
5c47ccf3e8
commit
e70522c318
chrome/browser
components/password_manager/core/browser/features
testing/variations
@ -11183,15 +11183,6 @@ const FeatureEntry kFeatureEntries[] = {
|
||||
FEATURE_VALUE_TYPE(fingerprinting_protection_filter::features::
|
||||
kEnableFingerprintingProtectionFilter)},
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
{"authenticate-using-user-consent-verifier-api",
|
||||
flag_descriptions::kAuthenticateUsingUserConsentVerifierApiName,
|
||||
flag_descriptions::kAuthenticateUsingUserConsentVerifierApiDescription,
|
||||
kOsWin,
|
||||
FEATURE_VALUE_TYPE(
|
||||
password_manager::features::kAuthenticateUsingUserConsentVerifierApi)},
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(IS_CHROMEOS_ASH)
|
||||
{"ash-forest-feature", flag_descriptions::kForestFeatureName,
|
||||
flag_descriptions::kForestFeatureDescription, kOsCrOS,
|
||||
@ -11416,16 +11407,6 @@ const FeatureEntry kFeatureEntries[] = {
|
||||
performance_manager::features::kPerformanceInterventionDemoMode)},
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
{"authenticate-using-user-consent-verifier-interop-api",
|
||||
flag_descriptions::kAuthenticateUsingUserConsentVerifierInteropApiName,
|
||||
flag_descriptions::
|
||||
kAuthenticateUsingUserConsentVerifierInteropApiDescription,
|
||||
kOsWin,
|
||||
FEATURE_VALUE_TYPE(password_manager::features::
|
||||
kAuthenticateUsingUserConsentVerifierInteropApi)},
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
|
||||
{"sync-enable-bookmarks-in-transport-mode",
|
||||
flag_descriptions::kSyncEnableBookmarksInTransportModeName,
|
||||
|
@ -37,7 +37,6 @@
|
||||
#include "chrome/browser/ui/browser.h"
|
||||
#include "chrome/browser/ui/browser_finder.h"
|
||||
#include "chrome/browser/ui/browser_window.h"
|
||||
#include "components/password_manager/core/browser/features/password_features.h"
|
||||
#include "ui/aura/window.h"
|
||||
#include "ui/views/win/hwnd_util.h"
|
||||
|
||||
@ -350,31 +349,19 @@ void PerformInteropWindowsHelloAuthenticationAsync(
|
||||
void PerformWin11Authentication(
|
||||
const std::u16string& message,
|
||||
base::OnceCallback<void(bool)> result_callback) {
|
||||
if (base::FeatureList::IsEnabled(
|
||||
password_manager::features::
|
||||
kAuthenticateUsingUserConsentVerifierInteropApi)) {
|
||||
PerformInteropWindowsHelloAuthenticationAsync(std::move(result_callback),
|
||||
message);
|
||||
return;
|
||||
}
|
||||
AuthenticateWithLegacyApi(message, std::move(result_callback));
|
||||
PerformInteropWindowsHelloAuthenticationAsync(std::move(result_callback),
|
||||
message);
|
||||
}
|
||||
|
||||
void PerformWin10Authentication(
|
||||
const std::u16string& message,
|
||||
base::OnceCallback<void(bool)> result_callback) {
|
||||
if (base::FeatureList::IsEnabled(
|
||||
password_manager::features::
|
||||
kAuthenticateUsingUserConsentVerifierApi)) {
|
||||
// Posting authentication using the new API on a background thread causes
|
||||
// Windows Hello dialog not to attach to Chrome's UI and instead it is
|
||||
// visible behind it. Running it on the default thread isn't that bad
|
||||
// because the thread itself is not blocked and there are operations
|
||||
// happening while the win hello dialog is visible.
|
||||
PerformWindowsHelloAuthenticationAsync(std::move(result_callback), message);
|
||||
return;
|
||||
}
|
||||
AuthenticateWithLegacyApi(message, std::move(result_callback));
|
||||
// Posting authentication using the new API on a background thread causes
|
||||
// Windows Hello dialog not to attach to Chrome's UI and instead it is
|
||||
// visible behind it. Running it on the default thread isn't that bad
|
||||
// because the thread itself is not blocked and there are operations
|
||||
// happening while the win hello dialog is visible.
|
||||
PerformWindowsHelloAuthenticationAsync(std::move(result_callback), message);
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
@ -570,16 +570,6 @@
|
||||
"owners": [ "aaronyu@chromium.org", "chromeos-audio@google.com" ],
|
||||
"expiry_milestone": 125
|
||||
},
|
||||
{
|
||||
"name": "authenticate-using-user-consent-verifier-api",
|
||||
"owners": [ "sygiet@google.com", "vasilii@chromium.org"],
|
||||
"expiry_milestone": 132
|
||||
},
|
||||
{
|
||||
"name": "authenticate-using-user-consent-verifier-interop-api",
|
||||
"owners": [ "sygiet@google.com", "vasilii@chromium.org"],
|
||||
"expiry_milestone": 134
|
||||
},
|
||||
{
|
||||
"name": "auto-framing-override",
|
||||
"owners": [ "kamesan@chromium.org", "chromeos-camera-eng@google.com" ],
|
||||
|
@ -5543,19 +5543,6 @@ const char kWebAuthenticationPermitEnterpriseAttestationDescription[] =
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
|
||||
const char kAuthenticateUsingUserConsentVerifierInteropApiName[] =
|
||||
"OS authentication will use IUserConsentVerifierInterop api if available.";
|
||||
const char kAuthenticateUsingUserConsentVerifierInteropApiDescription[] =
|
||||
"If user has Windows Hello configured, OS authentication will use "
|
||||
"IUserConsentVerifierInterop api with explicit window passing, otherwise "
|
||||
"Wincred will be used.";
|
||||
|
||||
const char kAuthenticateUsingUserConsentVerifierApiName[] =
|
||||
"OS authentication will use UserConsentVerifier api if available.";
|
||||
const char kAuthenticateUsingUserConsentVerifierApiDescription[] =
|
||||
"If user has Windows Hello configured, OS authentication will use "
|
||||
"UserConsentVerifier api, otherwise Wincred will be used.";
|
||||
|
||||
const char kCalculateNativeWinOcclusionName[] =
|
||||
"Calculate window occlusion on Windows";
|
||||
const char kCalculateNativeWinOcclusionDescription[] =
|
||||
|
@ -3200,12 +3200,6 @@ extern const char kWebAuthenticationPermitEnterpriseAttestationDescription[];
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
|
||||
extern const char kAuthenticateUsingUserConsentVerifierInteropApiName[];
|
||||
extern const char kAuthenticateUsingUserConsentVerifierInteropApiDescription[];
|
||||
|
||||
extern const char kAuthenticateUsingUserConsentVerifierApiName[];
|
||||
extern const char kAuthenticateUsingUserConsentVerifierApiDescription[];
|
||||
|
||||
extern const char kCalculateNativeWinOcclusionName[];
|
||||
extern const char kCalculateNativeWinOcclusionDescription[];
|
||||
|
||||
|
@ -24,16 +24,6 @@ BASE_FEATURE(kWebAuthnUsePasskeyFromAnotherDeviceInContextMenu,
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
BASE_FEATURE(kAuthenticateUsingUserConsentVerifierInteropApi,
|
||||
"AuthenticateUsingUserConsentVerifierInteropApi",
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kAuthenticateUsingUserConsentVerifierApi,
|
||||
"AuthenticateUsingUserConsentVerifierApi",
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
#endif
|
||||
|
||||
BASE_FEATURE(kBiometricTouchToFill,
|
||||
"BiometricTouchToFill",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
@ -34,17 +34,6 @@ BASE_DECLARE_FEATURE(kAutofillPasswordUserPerceptionSurvey);
|
||||
BASE_DECLARE_FEATURE(kWebAuthnUsePasskeyFromAnotherDeviceInContextMenu);
|
||||
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
// OS authentication will use IUserConsentVerifierInterop api to trigger Windows
|
||||
// Hello authentication. This api allows us to specify explicitly to which
|
||||
// window, the OS prompt should attach.
|
||||
BASE_DECLARE_FEATURE(kAuthenticateUsingUserConsentVerifierInteropApi);
|
||||
|
||||
// OS authentication will use UserConsentVerifier api to trigger Windows Hello
|
||||
// authentication.
|
||||
BASE_DECLARE_FEATURE(kAuthenticateUsingUserConsentVerifierApi);
|
||||
#endif // BUILDFLAG(IS_WIN)
|
||||
|
||||
// Enables Biometrics for the Touch To Fill feature. This only effects Android.
|
||||
BASE_DECLARE_FEATURE(kBiometricTouchToFill);
|
||||
|
||||
|
@ -1364,22 +1364,6 @@
|
||||
]
|
||||
}
|
||||
],
|
||||
"AuthenticateUsingUserConsentVerifierApi": [
|
||||
{
|
||||
"platforms": [
|
||||
"windows"
|
||||
],
|
||||
"experiments": [
|
||||
{
|
||||
"name": "Enabled",
|
||||
"enable_features": [
|
||||
"AuthenticateUsingUserConsentVerifierApi",
|
||||
"AuthenticateUsingUserConsentVerifierInteropApi"
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
],
|
||||
"AutoDisableAccessibility": [
|
||||
{
|
||||
"platforms": [
|
||||
|
Reference in New Issue
Block a user