Add ban rule for CreateBrowserWithTestWindow
This is a variant of TestWithBrowserView. Bug: 384547121 Change-Id: Iabff08ccc30c2e8ce452f8e467a794ca84445b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292356 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423521}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
2be7c79b63
commit
e89ebe3e2c
10
PRESUBMIT.py
10
PRESUBMIT.py
@ -2044,6 +2044,16 @@ _BANNED_CPP_FUNCTIONS: Sequence[BanRule] = (
|
||||
),
|
||||
treat_as_error=False,
|
||||
),
|
||||
BanRule(
|
||||
pattern='CreateBrowserWithTestWindow',
|
||||
explanation=
|
||||
('Do not use CreateBrowserWithTestWindow. See '
|
||||
'docs/chrome_browser_design_principles.md for details. If you want '
|
||||
'to write a test that has a Browser, create a browser_test. If you '
|
||||
'want to write a unit_test, your code must not reference Browser*.',
|
||||
),
|
||||
treat_as_error=False,
|
||||
),
|
||||
BanRule(
|
||||
pattern='RunUntilIdle',
|
||||
explanation=
|
||||
|
Reference in New Issue
Block a user