0

DanglingPointer: annotate for unittests base+linux [1/N]

The DanglingPointerDetector is configured only when the test enters the
ContentMain function. See https://crbug.com/1400059

I would like to configure it no matter the kind of test. For this to
happen, we need to annotate every pre-existing dangling pointers.

This patch annotates the ones you can find by running targets depending
on the GoogleTest library.

Statistic:

This adds 1776 new DanglingUntriaged. Among them:
- 1288 are in unittests.
- 488 are in implementation.

To produce those numbers, I used the command:
```bash
git diff annotate-linux origin/main -- "*test*" | grep "DanglingUntriaged" | wc -l
```

This patch has been generated by:

1. Apply the "auto-annotator" patch:
   https://chromium-review.googlesource.com/c/chromium/src/+/4474553

2. Compile the compiler again:
   ```bash
   ./tools/clang/scripts/build.py
   ```

3. List and run all the targets. You can use a bash script like:
   https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo

4. Concatenate output, filter by "Found dangling ptr", sort, remove
   duplicate.

5. Apply the rewriter script from:
   https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit

6. Revert the "auto-annotate" patch.

7. Apply `git cl format`

AX-Relnotes: n/a.
Bug: chromium:1400059
Change-Id: I217d5c0b925da5176fc53baf95919a3690f1e9a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570424
Reviewed-by: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151859}
This commit is contained in:
Arthur Sonzogni
2023-06-01 15:02:25 +00:00
committed by Chromium LUCI CQ
parent 0847bf8645
commit e98d214c48
1184 changed files with 2113 additions and 1774 deletions
apps
base
cc
chrome
browser
apps
app_service
background
badging
browser_switcher
browsing_data
cart
complex_tasks
component_updater
content_settings
device_identity
dips
download
engagement
enterprise
extensions
feed
feedback
first_party_sets
hid
history_clusters
media
media_galleries
metrics
net
new_tab_page
notifications
optimization_guide
page_load_metrics
password_manager
performance_manager
permissions
plugins
policy
predictors
preloading
privacy_sandbox
process_singleton_posix_unittest.cc
profiles
renderer_context_menu
resource_coordinator
safe_browsing
search
send_tab_to_self
sessions
sharing
signin
ssl
supervised_user
sync
sync_file_system
task_manager
themes
ui
autofill
bookmarks
browser.hbrowser_list_unittest.ccbrowser_unittest.cc
content_settings
cookie_controls
exclusive_access
extensions
global_media_controls
intent_picker_tab_helper.hintent_picker_tab_helper_unittest.cc
media_router
passwords
recently_audible_helper_unittest.cc
tab_contents
tabs
toolbar
views
apps
autofill
bookmarks
bubble
commerce
desktop_capture
device_chooser_content_view_unittest.cc
extensions
frame
global_media_controls
intent_picker_bubble_view_unittest.cc
layout
location_bar
media_router
omnibox
page_action
page_info
passwords
permissions
profiles
qrcode_generator
send_tab_to_self
sharing_hub
side_panel
site_data
tabs
toolbar
translate
user_education
webid
webui
updates
announcement_notification
web_applications
commands
extensions
externally_managed_app_manager.hexternally_managed_app_manager_impl_unittest.ccexternally_managed_app_manager_unittest.cc
isolated_web_apps
os_integration
policy
preinstalled_web_app_manager_unittest.cc
test
web_app_command_manager_unittest.ccweb_app_command_scheduler_unittest.ccweb_app_database.hweb_app_database_unittest.ccweb_app_icon_manager_unittest.ccweb_app_install_manager.h
webid
common
services
test
components
autofill
blocked_content
blocklist
bookmarks
browsing_data
captive_portal
commerce
consent_auditor
constrained_window
content_capture
content_settings
contextual_search
cronet
custom_handlers
device_signals
domain_reliability
download
enterprise
favicon
feature_engagement
feed
flags_ui
fullscreen_control
gcm_driver
global_media_controls
grpc_support
history
image_fetcher
invalidation
media_message_center
media_router
mirroring
no_state_prefetch
offline_pages
omnibox
open_from_clipboard
optimization_guide
origin_trials
os_crypt
page_info
page_load_metrics
password_manager
payments
performance_manager
permissions
policy
power_metrics
privacy_sandbox
proxy_config
query_tiles
reading_list
reduce_accept_language
reporting
safe_browsing
safe_search_api
search_provider_logos
security_interstitials
segmentation_platform
services
storage
dom_storage
indexed_db
sessions
signin
site_engagement
storage_monitor
subresource_filter
sync
sync_preferences
sync_sessions
system_media_controls
translate
trusted_vault
undo
unexportable_keys
unified_consent
update_client
url_formatter
user_education
visitedlink
viz
web_modal
webrtc_logging
content
browser
background_fetch
background_sync
bluetooth
browsing_data
byte_stream.cc
code_cache
compute_pressure
fenced_frame
file_system_access
geolocation
idle
indexed_db
interest_group
loader
media
notifications
permissions
picture_in_picture
plugin_list_unittest.cc
preloading
private_aggregation
push_messaging
renderer_host
screen_orientation
screenlock_monitor
service_worker
sms
speech
storage_partition_impl.h
web_package
webauth
webid
xr
public
services
test
courgette
dbus
device
extensions
google_apis/gcm/engine
gpu
ipc
media
net
remoting
services
audio
device
network
preferences
proxy_resolver
resource_coordinator
memory_instrumentation
public
cpp
memory_instrumentation
tracing
video_capture
sql
storage/browser
third_party/blink/public/platform/scheduler
ui
aura
base
compositor
events
gfx
message_center
ozone
views
accessibility
animation
bubble
color_chooser
controls
corewm
event_monitor_unittest.cc
focus
interaction
layout
test
touchui
view.hview_unittest.cc
widget
window
wm

@ -84,7 +84,7 @@ class SavedFilesServiceUnitTest : public testing::Test {
}
extensions::TestExtensionEnvironment env_;
raw_ptr<const extensions::Extension> extension_;
raw_ptr<const extensions::Extension, DanglingUntriaged> extension_;
raw_ptr<SavedFilesService> service_;
base::FilePath path_;
};

@ -315,7 +315,7 @@ GSourceFuncs g_observer_funcs = {ObserverPrepare, ObserverCheck, nullptr,
struct FdWatchSource : public GSource {
raw_ptr<MessagePumpGlib> pump;
raw_ptr<MessagePumpGlib::FdWatchController> controller;
raw_ptr<MessagePumpGlib::FdWatchController, DanglingUntriaged> controller;
};
gboolean FdWatchSourcePrepare(GSource* source, gint* timeout_ms) {

@ -88,7 +88,7 @@ class SamplesCollector : public PoissonAllocationSampler::SamplesObserver {
private:
size_t watch_size_;
raw_ptr<void> sample_address_ = nullptr;
raw_ptr<void, DanglingUntriaged> sample_address_ = nullptr;
};
TEST_F(SamplingHeapProfilerTest, SampleObserver) {

@ -37,7 +37,8 @@ class BASE_EXPORT PooledParallelTaskRunner : public TaskRunner {
~PooledParallelTaskRunner() override;
const TaskTraits traits_;
const raw_ptr<PooledTaskRunnerDelegate> pooled_task_runner_delegate_;
const raw_ptr<PooledTaskRunnerDelegate, DanglingUntriaged>
pooled_task_runner_delegate_;
};
} // namespace internal

@ -54,7 +54,8 @@ class ScopedPowerMonitorTestSource {
private:
// Owned by PowerMonitor.
raw_ptr<PowerMonitorTestSource> power_monitor_test_source_ = nullptr;
raw_ptr<PowerMonitorTestSource, DanglingUntriaged>
power_monitor_test_source_ = nullptr;
};
class PowerMonitorTestObserver : public PowerSuspendObserver,

@ -506,7 +506,7 @@ class TaskEnvironment {
#endif
// Owned by the ThreadPoolInstance.
raw_ptr<TestTaskTracker> task_tracker_ = nullptr;
raw_ptr<TestTaskTracker, DanglingUntriaged> task_tracker_ = nullptr;
// Ensures destruction of lazy TaskRunners when this is destroyed.
std::unique_ptr<base::internal::ScopedLazyTaskRunnerListForTesting>

@ -227,7 +227,8 @@ class CheckForLeakedGlobals : public testing::EmptyTestEventListener {
}
private:
raw_ptr<FeatureList> feature_list_set_before_test_ = nullptr;
raw_ptr<FeatureList, DanglingUntriaged> feature_list_set_before_test_ =
nullptr;
raw_ptr<FeatureList> feature_list_set_before_case_ = nullptr;
raw_ptr<ThreadPoolInstance> thread_pool_set_before_test_ = nullptr;
raw_ptr<ThreadPoolInstance> thread_pool_set_before_case_ = nullptr;

@ -162,7 +162,7 @@ class CC_ANIMATION_EXPORT ScrollOffsetAnimationCurve
static absl::optional<double> animation_duration_for_testing_;
raw_ptr<Target> target_ = nullptr;
raw_ptr<Target, DanglingUntriaged> target_ = nullptr;
};
} // namespace cc

@ -75,7 +75,7 @@ class CC_EXPORT PictureLayer : public Layer {
PictureLayerInputs();
~PictureLayerInputs();
raw_ptr<ContentLayerClient> client = nullptr;
raw_ptr<ContentLayerClient, DanglingUntriaged> client = nullptr;
bool nearest_neighbor = false;
bool is_backdrop_filter_mask = false;
scoped_refptr<DisplayItemList> display_list;

@ -134,7 +134,8 @@ class BaseScrollbarLayerTest : public testing::Test {
}
protected:
raw_ptr<FakeResourceTrackingUIResourceManager> fake_ui_resource_manager_;
raw_ptr<FakeResourceTrackingUIResourceManager, DanglingUntriaged>
fake_ui_resource_manager_;
FakeLayerTreeHostClient fake_client_;
StubLayerTreeHostSingleThreadClient single_thread_client_;
TestTaskGraphRunner task_graph_runner_;

@ -1451,7 +1451,7 @@ class SoftwareTextureLayerTest : public LayerTreeTest {
scoped_refptr<Layer> root_;
scoped_refptr<SolidColorLayer> solid_color_layer_;
scoped_refptr<TextureLayer> texture_layer_;
raw_ptr<TestLayerTreeFrameSink> frame_sink_ = nullptr;
raw_ptr<TestLayerTreeFrameSink, DanglingUntriaged> frame_sink_ = nullptr;
int num_frame_sinks_created_ = 0;
};
@ -1932,7 +1932,7 @@ class SoftwareTextureLayerLoseFrameSinkTest : public SoftwareTextureLayerTest {
scoped_refptr<CrossThreadSharedBitmap> bitmap_;
// Keeps a pointer value of the first frame sink, which will be removed
// from the host and destroyed.
raw_ptr<void> first_frame_sink_;
raw_ptr<void, DanglingUntriaged> first_frame_sink_;
};
SINGLE_AND_MULTI_THREAD_TEST_F(SoftwareTextureLayerLoseFrameSinkTest);

@ -166,7 +166,8 @@ class CC_EXPORT CompositorTimingHistory {
std::unique_ptr<UMAReporter> uma_reporter_;
// Owned by LayerTreeHost and is destroyed when LayerTreeHost is destroyed.
raw_ptr<RenderingStatsInstrumentation> rendering_stats_instrumentation_;
raw_ptr<RenderingStatsInstrumentation, DanglingUntriaged>
rendering_stats_instrumentation_;
};
} // namespace cc

@ -305,7 +305,7 @@ class FrameSequenceTrackerTest : public testing::Test {
std::unique_ptr<CompositorFrameReportingController>
compositor_frame_reporting_controller_;
FrameSequenceTrackerCollection collection_;
raw_ptr<FrameSequenceTracker> tracker_;
raw_ptr<FrameSequenceTracker, DanglingUntriaged> tracker_;
};
// Tests that the tracker works correctly when the source-id for the

@ -175,7 +175,7 @@ class CC_PAINT_EXPORT ServiceImageTransferCacheEntry final
bool fits_on_gpu() const;
private:
raw_ptr<GrDirectContext> gr_context_ = nullptr;
raw_ptr<GrDirectContext, DanglingUntriaged> gr_context_ = nullptr;
raw_ptr<skgpu::graphite::Recorder> graphite_recorder_ = nullptr;
sk_sp<SkImage> image_;

@ -83,7 +83,7 @@ class SkottieMRUResourceProviderTest : public ::testing::Test {
FrameDataStub frame_data_stub_;
sk_sp<SkottieMRUResourceProvider> provider_;
raw_ptr<skresources::ResourceProvider> provider_base_;
raw_ptr<skresources::ResourceProvider, DanglingUntriaged> provider_base_;
};
TEST_F(SkottieMRUResourceProviderTest, ProvidesMostRecentFrameDataForAsset) {

@ -145,7 +145,7 @@ class CC_EXPORT GpuRasterBufferProvider : public RasterBufferProvider {
const viz::SharedImageFormat tile_format_;
const gfx::Size max_tile_size_;
const raw_ptr<RasterQueryQueue> pending_raster_queries_;
const raw_ptr<RasterQueryQueue, DanglingUntriaged> pending_raster_queries_;
const double raster_metric_probability_;
// Accessed with the worker context lock acquired.

@ -55,7 +55,8 @@ class CC_EXPORT RasterQueryQueue {
virtual bool CheckRasterFinishedQueries();
private:
const raw_ptr<viz::RasterContextProvider> worker_context_provider_;
const raw_ptr<viz::RasterContextProvider, DanglingUntriaged>
worker_context_provider_;
// Note that this lock should never be acquired while holding the raster
// context lock.

@ -75,7 +75,7 @@ class ResourcePoolTest : public testing::Test {
}
viz::TestSharedBitmapManager shared_bitmap_manager_;
raw_ptr<MockContextSupport> context_support_;
raw_ptr<MockContextSupport, DanglingUntriaged> context_support_;
scoped_refptr<viz::TestContextProvider> context_provider_;
std::unique_ptr<viz::ClientResourceProvider> resource_provider_;
scoped_refptr<base::TestMockTimeTaskRunner> test_task_runner_;

@ -46,7 +46,7 @@ class CC_EXPORT ScopedUIResource : public UIResourceClient {
const UIResourceBitmap& bitmap);
UIResourceBitmap bitmap_;
raw_ptr<UIResourceManager> ui_resource_manager_;
raw_ptr<UIResourceManager, DanglingUntriaged> ui_resource_manager_;
UIResourceId id_;
};

@ -298,7 +298,7 @@ class FakeSchedulerClient : public SchedulerClient,
viz::BeginFrameAck last_begin_frame_ack_;
base::TimeTicks posted_begin_impl_frame_deadline_;
std::vector<const char*> actions_;
raw_ptr<TestScheduler> scheduler_ = nullptr;
raw_ptr<TestScheduler, DanglingUntriaged> scheduler_ = nullptr;
base::TimeDelta frame_interval_;
absl::optional<FrameSkippedReason> last_frame_skipped_reason_;
};

@ -135,7 +135,8 @@ class COMPONENT_EXPORT(CC_SLIM) FrameSinkImpl
mojo::AssociatedRemote<viz::mojom::CompositorFrameSink> frame_sink_remote_;
// Separate from AssociatedRemote above for testing.
raw_ptr<viz::mojom::CompositorFrameSink> frame_sink_ = nullptr;
raw_ptr<viz::mojom::CompositorFrameSink, DanglingUntriaged> frame_sink_ =
nullptr;
mojo::Receiver<viz::mojom::CompositorFrameSinkClient> client_receiver_{this};
scoped_refptr<viz::ContextProvider> context_provider_;
raw_ptr<FrameSinkImplClient> client_ = nullptr;

@ -27,7 +27,7 @@ class FakeLayerTreeHostClient : public StubLayerTreeHostClient {
private:
bool software_comp_ = true;
raw_ptr<LayerTreeHost> host_ = nullptr;
raw_ptr<LayerTreeHost, DanglingUntriaged> host_ = nullptr;
};
} // namespace cc

@ -72,8 +72,8 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient {
std::unique_ptr<TileManager> tile_manager_;
scoped_refptr<RasterSource> raster_source_;
gfx::Size tile_size_;
raw_ptr<PictureLayerTilingSet> twin_set_;
raw_ptr<PictureLayerTiling> twin_tiling_;
raw_ptr<PictureLayerTilingSet, DanglingUntriaged> twin_set_;
raw_ptr<PictureLayerTiling, DanglingUntriaged> twin_tiling_;
gfx::Rect text_rect_;
Region invalidation_;
bool has_valid_tile_priorities_;

@ -674,7 +674,7 @@ class LayerTreeTestLayerTreeFrameSinkClient
private:
raw_ptr<TestHooks> hooks_;
raw_ptr<TaskRunnerProvider> task_runner_provider_;
raw_ptr<TaskRunnerProvider, DanglingUntriaged> task_runner_provider_;
};
LayerTreeTest::LayerTreeTest(viz::RendererType renderer_type)

@ -85,9 +85,9 @@ class TestLayerTreeHostBase : public testing::Test {
std::unique_ptr<LayerTreeFrameSink> layer_tree_frame_sink_;
std::unique_ptr<FakeLayerTreeHostImpl> host_impl_;
raw_ptr<FakePictureLayerImpl> pending_layer_;
raw_ptr<FakePictureLayerImpl> active_layer_;
raw_ptr<FakePictureLayerImpl> old_pending_layer_;
raw_ptr<FakePictureLayerImpl, DanglingUntriaged> pending_layer_;
raw_ptr<FakePictureLayerImpl, DanglingUntriaged> active_layer_;
raw_ptr<FakePictureLayerImpl, DanglingUntriaged> old_pending_layer_;
const int root_id_;
int next_layer_id_;
};

@ -63,7 +63,7 @@ class TransferCacheTestHelper : public TransferCacheDeserializeHelper,
std::set<EntryKey> locked_entries_;
EntryKey last_added_entry_ = {TransferCacheEntryType::kRawMemory, ~0};
raw_ptr<GrDirectContext> context_ = nullptr;
raw_ptr<GrDirectContext, DanglingUntriaged> context_ = nullptr;
sk_sp<GrDirectContext> owned_context_;
size_t cached_items_limit_ = std::numeric_limits<size_t>::max();
};

@ -130,7 +130,7 @@ class FakeDiscardableManager {
std::map<GLuint, int32_t> textures_;
size_t live_textures_count_ = 0;
size_t cached_textures_limit_ = std::numeric_limits<size_t>::max();
raw_ptr<viz::TestGLES2Interface> gl_ = nullptr;
raw_ptr<viz::TestGLES2Interface, DanglingUntriaged> gl_ = nullptr;
};
class FakeGPUImageDecodeTestGLES2Interface : public viz::TestGLES2Interface,

@ -351,8 +351,12 @@ class DamageTrackerTest : public LayerTreeImplTestBase, public testing::Test {
host_impl()->active_tree()->DetachLayersKeepingRootLayerForTesting();
host_impl()->active_tree()->property_trees()->clear();
child_layers_.clear();
child1_ = child2_ = grand_child1_ = grand_child2_ = grand_child3_ =
grand_child4_ = nullptr;
child1_ = nullptr;
child2_ = nullptr;
grand_child1_ = nullptr;
grand_child2_ = nullptr;
grand_child3_ = nullptr;
grand_child4_ = nullptr;
}
// Stores result of CreateTestTreeWithOneSurface().
@ -361,8 +365,8 @@ class DamageTrackerTest : public LayerTreeImplTestBase, public testing::Test {
// Store result of CreateTestTreeWithTwoSurfaces().
raw_ptr<TestLayerImpl> child1_ = nullptr;
raw_ptr<TestLayerImpl> child2_ = nullptr;
raw_ptr<TestLayerImpl> grand_child1_ = nullptr;
raw_ptr<TestLayerImpl> grand_child2_ = nullptr;
raw_ptr<TestLayerImpl, DanglingUntriaged> grand_child1_ = nullptr;
raw_ptr<TestLayerImpl, DanglingUntriaged> grand_child2_ = nullptr;
raw_ptr<TestLayerImpl> grand_child3_ = nullptr;
raw_ptr<TestLayerImpl> grand_child4_ = nullptr;
};

@ -626,8 +626,8 @@ class LayerTreeHostContextCacheTest : public LayerTreeHostTest {
void(bool aggressively_free_resources));
};
raw_ptr<MockContextSupport> mock_main_context_support_;
raw_ptr<MockContextSupport> mock_worker_context_support_;
raw_ptr<MockContextSupport, DanglingUntriaged> mock_main_context_support_;
raw_ptr<MockContextSupport, DanglingUntriaged> mock_worker_context_support_;
};
// Test if the LTH successfully frees resources on the main/worker
@ -1498,7 +1498,7 @@ class LayerTreeHostTestLayerListSurfaceDamage : public LayerTreeHostTest {
}
private:
raw_ptr<Layer> root_;
raw_ptr<Layer, DanglingUntriaged> root_;
scoped_refptr<Layer> child_a_;
scoped_refptr<Layer> child_b_;
scoped_refptr<Layer> child_c_;
@ -5995,8 +5995,8 @@ class LayerTreeHostTestElasticOverscroll : public LayerTreeHostTest {
private:
FakeContentLayerClient client_;
raw_ptr<Layer> root_layer_;
raw_ptr<ScrollElasticityHelper> scroll_elasticity_helper_;
raw_ptr<Layer, DanglingUntriaged> root_layer_;
raw_ptr<ScrollElasticityHelper, DanglingUntriaged> scroll_elasticity_helper_;
int content_layer_id_;
int num_draws_;
};
@ -6672,8 +6672,8 @@ class LayerTreeHostTestGpuRasterizationDisabled : public LayerTreeHostTest {
}
FakeContentLayerClient layer_client_;
raw_ptr<FakePictureLayer> layer_;
raw_ptr<FakeRecordingSource> recording_source_;
raw_ptr<FakePictureLayer, DanglingUntriaged> layer_;
raw_ptr<FakeRecordingSource, DanglingUntriaged> recording_source_;
};
MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationDisabled);
@ -6724,8 +6724,8 @@ class LayerTreeHostTestGpuRasterizationSupportedButDisabled
}
FakeContentLayerClient layer_client_;
raw_ptr<FakePictureLayer> layer_;
raw_ptr<FakeRecordingSource> recording_source_;
raw_ptr<FakePictureLayer, DanglingUntriaged> layer_;
raw_ptr<FakeRecordingSource, DanglingUntriaged> recording_source_;
};
MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationSupportedButDisabled);
@ -6773,8 +6773,8 @@ class LayerTreeHostTestGpuRasterizationEnabled : public LayerTreeHostTest {
}
FakeContentLayerClient layer_client_;
raw_ptr<FakePictureLayer> layer_;
raw_ptr<FakeRecordingSource> recording_source_;
raw_ptr<FakePictureLayer, DanglingUntriaged> layer_;
raw_ptr<FakeRecordingSource, DanglingUntriaged> recording_source_;
};
SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationEnabled);
@ -6839,8 +6839,8 @@ class LayerTreeHostTestGpuRasterizationEnabledWithMSAA : public LayerTreeTest {
}
FakeContentLayerClient layer_client_;
raw_ptr<FakePictureLayer> layer_;
raw_ptr<FakeRecordingSource> recording_source_;
raw_ptr<FakePictureLayer, DanglingUntriaged> layer_;
raw_ptr<FakeRecordingSource, DanglingUntriaged> recording_source_;
};
MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationEnabledWithMSAA);
@ -10671,7 +10671,7 @@ class LayerTreeHostTestBeginFramePausedChanged : public LayerTreeHostTest {
}
private:
raw_ptr<TestLayerTreeFrameSink> layer_tree_frame_sink_;
raw_ptr<TestLayerTreeFrameSink, DanglingUntriaged> layer_tree_frame_sink_;
};
MULTI_THREAD_TEST_F(LayerTreeHostTestBeginFramePausedChanged);

@ -163,8 +163,8 @@ class LayerTreeHostContextTest : public LayerTreeTest {
// Protects use of gl_ so LoseContext and
// CreateDisplayLayerTreeFrameSink can both use it on different threads.
base::Lock gl_lock_;
raw_ptr<viz::TestGLES2Interface> gl_ = nullptr;
raw_ptr<viz::TestSharedImageInterface> sii_ = nullptr;
raw_ptr<viz::TestGLES2Interface, DanglingUntriaged> gl_ = nullptr;
raw_ptr<viz::TestSharedImageInterface, DanglingUntriaged> sii_ = nullptr;
int times_to_fail_create_;
int times_to_lose_during_commit_;
@ -698,7 +698,7 @@ class LayerTreeHostContextTestLostContextAndEvictTextures
protected:
bool lose_after_evict_;
FakeContentLayerClient client_;
raw_ptr<LayerTreeHostImpl> impl_host_;
raw_ptr<LayerTreeHostImpl, DanglingUntriaged> impl_host_;
int num_commits_;
bool lost_context_;
};

@ -611,7 +611,7 @@ class LayerTreeHostTestHiddenSurfaceNotAllocatedForSubtreeCopyRequest
viz::AggregatedRenderPassId parent_render_pass_id;
viz::AggregatedRenderPassId copy_layer_render_pass_id;
raw_ptr<TestLayerTreeFrameSink> frame_sink_ = nullptr;
raw_ptr<TestLayerTreeFrameSink, DanglingUntriaged> frame_sink_ = nullptr;
bool did_swap_ = false;
FakeContentLayerClient client_;
scoped_refptr<FakePictureLayer> root_;

@ -751,8 +751,8 @@ class LayerTreeHostScrollTestCaseWithChild : public LayerTreeHostScrollTest {
gfx::PointF final_scroll_offset_;
scoped_refptr<Layer> child_layer_;
raw_ptr<Layer> expected_scroll_layer_;
raw_ptr<Layer> expected_no_scroll_layer_;
raw_ptr<Layer, DanglingUntriaged> expected_scroll_layer_;
raw_ptr<Layer, DanglingUntriaged> expected_no_scroll_layer_;
};
TEST_F(LayerTreeHostScrollTestCaseWithChild, DeviceScaleFactor1_ScrollChild) {
@ -2401,7 +2401,7 @@ class LayerTreeHostScrollTestElasticOverscroll
// These values should be used on the impl thread only.
int num_begin_main_frames_impl_thread_;
MockInputHandlerClient input_handler_client_;
raw_ptr<ScrollElasticityHelper> scroll_elasticity_helper_;
raw_ptr<ScrollElasticityHelper, DanglingUntriaged> scroll_elasticity_helper_;
// These values should be used on the main thread only.
int num_begin_main_frames_main_thread_;

@ -837,7 +837,7 @@ class CC_EXPORT LayerTreeImpl {
int source_frame_number_;
uint64_t trace_id_ = 0;
int is_first_frame_after_commit_tracker_;
raw_ptr<HeadsUpDisplayLayerImpl> hud_layer_;
raw_ptr<HeadsUpDisplayLayerImpl, DanglingUntriaged> hud_layer_;
PropertyTrees property_trees_;
SkColor4f background_color_;

@ -62,7 +62,7 @@ class CC_EXPORT OcclusionTracker {
struct StackObject {
StackObject() : target(nullptr) {}
explicit StackObject(const RenderSurfaceImpl* target) : target(target) {}
raw_ptr<const RenderSurfaceImpl> target;
raw_ptr<const RenderSurfaceImpl, DanglingUntriaged> target;
SimpleEnclosedRegion occlusion_from_outside_target;
SimpleEnclosedRegion occlusion_from_inside_target;
bool ignores_parent_occlusion = false;

@ -234,7 +234,7 @@ class UkmManagerTest : public testing::Test {
return breakdown;
}
raw_ptr<ukm::TestUkmRecorder> test_ukm_recorder_;
raw_ptr<ukm::TestUkmRecorder, DanglingUntriaged> test_ukm_recorder_;
std::unique_ptr<UkmManager> manager_;
base::SimpleTestTickClock test_tick_clock_;
};

@ -473,7 +473,8 @@ class PublisherTest : public extensions::ExtensionServiceTestBase {
base::test::ScopedFeatureList scoped_feature_list_;
private:
raw_ptr<web_app::TestWebAppUrlLoader> url_loader_ = nullptr;
raw_ptr<web_app::TestWebAppUrlLoader, DanglingUntriaged> url_loader_ =
nullptr;
#if BUILDFLAG(IS_CHROMEOS_ASH)
std::unique_ptr<crosapi::FakeBrowserManager> browser_manager_;
#endif // BUILDFLAG(IS_CHROMEOS_ASH)

@ -292,7 +292,7 @@ class BackgroundModeManagerWithExtensionsTest : public testing::Test {
std::unique_ptr<TestingProfileManager> profile_manager_;
// Test profile used by all tests - this is owned by profile_manager_.
raw_ptr<TestingProfile> profile_;
raw_ptr<TestingProfile, DanglingUntriaged> profile_;
private:
// Required for extension service.

@ -177,11 +177,11 @@ class BadgeManager : public KeyedService, public blink::mojom::BadgeService {
void SetBadge(blink::mojom::BadgeValuePtr value) override;
void ClearBadge() override;
const raw_ptr<Profile> profile_;
const raw_ptr<Profile, DanglingUntriaged> profile_;
raw_ptr<const base::Clock> clock_;
raw_ptr<web_app::WebAppSyncBridge> sync_bridge_;
raw_ptr<web_app::WebAppSyncBridge, DanglingUntriaged> sync_bridge_;
// All the mojo receivers for the BadgeManager. Keeps track of the
// render_frame the binding is associated with, so as to not have to rely

@ -35,7 +35,7 @@ class BadgeManagerDelegate {
private:
// The profile the badge manager delegate is associated with.
raw_ptr<Profile> profile_;
raw_ptr<Profile, DanglingUntriaged> profile_;
// The badge manager that owns this delegate.
raw_ptr<BadgeManager> badge_manager_;
};

@ -95,8 +95,8 @@ class BadgeManagerUnittest : public ::testing::Test {
web_app::WebAppProvider& provider() { return *provider_; }
private:
raw_ptr<TestBadgeManagerDelegate> delegate_;
raw_ptr<web_app::FakeWebAppProvider> provider_;
raw_ptr<TestBadgeManagerDelegate, DanglingUntriaged> delegate_;
raw_ptr<web_app::FakeWebAppProvider, DanglingUntriaged> provider_;
content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<TestingProfile> profile_;

@ -87,7 +87,7 @@ class BrowserSwitcherNavigationThrottleTest
Decision go() { return {kGo, kSitelist, bogus_rule_.get()}; }
private:
raw_ptr<MockBrowserSwitcherSitelist> sitelist_;
raw_ptr<MockBrowserSwitcherSitelist, DanglingUntriaged> sitelist_;
std::unique_ptr<Rule> bogus_rule_ =
CanonicalizeRule("//example.com/", ParsingMode::kDefault);

@ -54,8 +54,9 @@ class ChromeBrowsingDataModelDelegate : public BrowsingDataModel::Delegate {
ChromeBrowsingDataModelDelegate(Profile* profile,
content::StoragePartition* storage_partition);
const raw_ptr<Profile> profile_;
const raw_ptr<content::StoragePartition> storage_partition_;
const raw_ptr<Profile, DanglingUntriaged> profile_;
const raw_ptr<content::StoragePartition, DanglingUntriaged>
storage_partition_;
};
#endif // CHROME_BROWSER_BROWSING_DATA_CHROME_BROWSING_DATA_MODEL_DELEGATE_H_

@ -42,7 +42,7 @@ class CartDiscountServiceDelegate {
virtual void UpdateFreeListingCoupons(const CouponService::CouponsMap& map);
private:
raw_ptr<CartService> cart_service_;
raw_ptr<CartService, DanglingUntriaged> cart_service_;
};
// This is used to fetch discounts for active Carts in cart_db. It starts
@ -96,7 +96,8 @@ class FetchDiscountWorker {
// This is used to fetch the oauth token.
std::unique_ptr<const signin::PrimaryAccountAccessTokenFetcher>
access_token_fetcher_;
const raw_ptr<variations::VariationsClient> chrome_variations_client_;
const raw_ptr<variations::VariationsClient, DanglingUntriaged>
chrome_variations_client_;
// This is run in the UI thread, it loads all active carts.
void PrepareToFetch();

@ -71,7 +71,7 @@ class TaskTabHelperUnitTest : public ChromeRenderViewHostTestHarness {
return web_contents()->GetController().GetLastCommittedEntry();
}
raw_ptr<MockTaskTabHelper> task_tab_helper_;
raw_ptr<MockTaskTabHelper, DanglingUntriaged> task_tab_helper_;
};
TEST_F(TaskTabHelperUnitTest, TestGetCurrentTaskId) {

@ -186,7 +186,8 @@ class SubresourceFilterComponentInstallerTest : public PlatformTest {
std::unique_ptr<SubresourceFilterComponentInstallerPolicy> policy_;
TestingPrefServiceSimple pref_service_;
raw_ptr<TestRulesetService> test_ruleset_service_ = nullptr;
raw_ptr<TestRulesetService, DanglingUntriaged> test_ruleset_service_ =
nullptr;
};
TEST_F(SubresourceFilterComponentInstallerTest,

@ -109,7 +109,7 @@ class SoundContentSettingObserverTest : public ChromeRenderViewHostTestHarness {
#endif
private:
raw_ptr<HostContentSettingsMap> host_content_settings_map_;
raw_ptr<HostContentSettingsMap, DanglingUntriaged> host_content_settings_map_;
std::unique_ptr<ukm::TestUkmRecorder> test_ukm_recorder_;
base::test::ScopedFeatureList scoped_feature_list_;
};

@ -211,7 +211,7 @@ class DeviceOAuth2TokenServiceTest : public testing::Test {
std::unique_ptr<DeviceOAuth2TokenService, TokenServiceDeleter>
oauth2_service_;
TestingOAuth2AccessTokenManagerConsumer consumer_;
raw_ptr<MockDeviceOAuth2TokenStore> token_store_;
raw_ptr<MockDeviceOAuth2TokenStore, DanglingUntriaged> token_store_;
};
void DeviceOAuth2TokenServiceTest::ReturnOAuthUrlFetchResults(

@ -270,8 +270,9 @@ class DIPSServiceStateRemovalTest : public testing::Test {
base::SimpleTestClock clock_;
std::unique_ptr<TestingProfile> profile_;
raw_ptr<content_settings::CookieSettings> cookie_settings_ = nullptr;
raw_ptr<DIPSService> service_ = nullptr;
raw_ptr<content_settings::CookieSettings, DanglingUntriaged>
cookie_settings_ = nullptr;
raw_ptr<DIPSService, DanglingUntriaged> service_ = nullptr;
};
TEST_F(DIPSServiceStateRemovalTest,

@ -52,7 +52,7 @@ class DownloadBubblePrefsTest : public testing::Test {
}
protected:
raw_ptr<TestingProfile> profile_;
raw_ptr<TestingProfile, DanglingUntriaged> profile_;
base::test::ScopedFeatureList feature_list_;
void ExpectFeatureFlagEnabledStatus(bool expect_enabled) {

@ -118,7 +118,7 @@ class DownloadBubbleUIController {
raw_ptr<Browser, DanglingUntriaged> browser_;
raw_ptr<Profile, DanglingUntriaged> profile_;
raw_ptr<DownloadBubbleUpdateService> update_service_;
raw_ptr<DownloadBubbleUpdateService, DanglingUntriaged> update_service_;
raw_ptr<OfflineItemModelManager, DanglingUntriaged> offline_manager_;
// DownloadDisplayController and DownloadBubbleUIController have the same

@ -343,7 +343,7 @@ class DownloadBubbleUIControllerTest : public testing::Test {
second_display_controller_;
std::vector<std::unique_ptr<StrictMockDownloadItem>> items_;
OfflineItemList offline_items_;
raw_ptr<NiceMock<content::MockDownloadManager>> manager_;
raw_ptr<NiceMock<content::MockDownloadManager>, DanglingUntriaged> manager_;
TestingProfileManager testing_profile_manager_;
std::unique_ptr<
NiceMock<offline_items_collection::MockOfflineContentProvider>>

@ -285,15 +285,17 @@ class DownloadBubbleUpdateServiceTest : public testing::Test {
base::test::ScopedFeatureList feature_list_;
content::BrowserTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
raw_ptr<NiceMock<content::MockDownloadManager>> download_manager_ = nullptr;
raw_ptr<NiceMock<content::MockDownloadManager>, DanglingUntriaged>
download_manager_ = nullptr;
std::vector<std::unique_ptr<NiceMockDownloadItem>> download_items_;
std::vector<offline_items_collection::OfflineItem> offline_items_;
TestingProfileManager testing_profile_manager_;
raw_ptr<TestingProfile> profile_ = nullptr;
raw_ptr<TestingProfile, DanglingUntriaged> profile_ = nullptr;
std::unique_ptr<
NiceMock<offline_items_collection::MockOfflineContentProvider>>
offline_content_provider_;
raw_ptr<DownloadBubbleUpdateService> update_service_ = nullptr;
raw_ptr<DownloadBubbleUpdateService, DanglingUntriaged> update_service_ =
nullptr;
};
TEST_F(DownloadBubbleUpdateServiceTest, PopulatesCaches) {
@ -904,11 +906,12 @@ class DownloadBubbleUpdateServiceIncognitoTest
}
protected:
raw_ptr<Profile> incognito_profile_ = nullptr;
raw_ptr<NiceMock<content::MockDownloadManager>> incognito_download_manager_ =
nullptr;
raw_ptr<Profile, DanglingUntriaged> incognito_profile_ = nullptr;
raw_ptr<NiceMock<content::MockDownloadManager>, DanglingUntriaged>
incognito_download_manager_ = nullptr;
std::vector<std::unique_ptr<NiceMockDownloadItem>> incognito_download_items_;
raw_ptr<DownloadBubbleUpdateService> incognito_update_service_ = nullptr;
raw_ptr<DownloadBubbleUpdateService, DanglingUntriaged>
incognito_update_service_ = nullptr;
};
// Tests that initializing an update service for an incognito profile sets both

@ -176,7 +176,7 @@ class DownloadDisplayController : public FullscreenObserver,
// DownloadDisplayController and DownloadBubbleUIController have the same
// lifetime. Both are owned, constructed together, and destructed together by
// DownloadToolbarButtonView. If one is valid, so is the other.
raw_ptr<DownloadBubbleUIController> bubble_controller_;
raw_ptr<DownloadBubbleUIController, DanglingUntriaged> bubble_controller_;
base::WeakPtrFactory<DownloadDisplayController> weak_factory_{this};
};

@ -110,7 +110,7 @@ class FakeDownloadDisplay : public DownloadDisplay {
bool detail_shown_ = false;
bool is_fullscreen_ = false;
bool should_show_exclusive_access_bubble_ = true;
raw_ptr<DownloadDisplayController> controller_ = nullptr;
raw_ptr<DownloadDisplayController, DanglingUntriaged> controller_ = nullptr;
};
// TODO(chlily): Pull this and the very similar class in

@ -338,7 +338,7 @@ class ChromeDownloadManagerDelegate
const base::FilePath& target_path);
#endif
raw_ptr<Profile> profile_;
raw_ptr<Profile, DanglingUntriaged> profile_;
#if BUILDFLAG(IS_ANDROID)
std::unique_ptr<DownloadDialogBridge> download_dialog_bridge_;

@ -339,7 +339,8 @@ class ChromeDownloadManagerDelegateTest
private:
base::FilePath test_download_dir_;
raw_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_;
raw_ptr<sync_preferences::TestingPrefServiceSyncable, DanglingUntriaged>
pref_service_;
std::unique_ptr<content::MockDownloadManager> download_manager_;
std::unique_ptr<TestChromeDownloadManagerDelegate> delegate_;
MockWebContentsDelegate web_contents_delegate_;

@ -501,9 +501,10 @@ class DownloadHistoryTest : public testing::Test {
content::BrowserTaskEnvironment task_environment_;
std::vector<std::unique_ptr<StrictMockDownloadItem>> items_;
std::unique_ptr<NiceMock<content::MockDownloadManager>> manager_;
raw_ptr<FakeHistoryAdapter> history_ = nullptr;
raw_ptr<FakeHistoryAdapter, DanglingUntriaged> history_ = nullptr;
std::unique_ptr<DownloadHistory> download_history_;
raw_ptr<content::DownloadManager::Observer> manager_observer_ = nullptr;
raw_ptr<content::DownloadManager::Observer, DanglingUntriaged>
manager_observer_ = nullptr;
size_t download_created_index_ = 0;
base::test::ScopedFeatureList feature_list_;
TestingProfile profile_;

@ -96,7 +96,7 @@ class TestDownloadCoreService : public DownloadCoreServiceImpl {
ChromeDownloadManagerDelegate* GetDownloadManagerDelegate() override;
raw_ptr<ChromeDownloadManagerDelegate> delegate_;
raw_ptr<ChromeDownloadManagerDelegate, DanglingUntriaged> delegate_;
};
TestDownloadCoreService::TestDownloadCoreService(Profile* profile)

@ -205,7 +205,7 @@ class DownloadStatusUpdaterTest : public testing::Test {
// Pointer so we can verify that destruction triggers appropriate
// changes.
raw_ptr<TestDownloadStatusUpdater> updater_;
raw_ptr<TestDownloadStatusUpdater, DanglingUntriaged> updater_;
// Thread so that the DownloadManager (which is a DeleteOnUIThread
// object) can be deleted.

@ -161,7 +161,7 @@ class DownloadUIControllerTest : public ChromeRenderViewHostTestHarness {
RAW_PTR_EXCLUSION download::DownloadItem* notified_item_;
base::WeakPtrFactory<download::DownloadItem*> notified_item_receiver_factory_;
raw_ptr<HistoryAdapter> history_adapter_;
raw_ptr<HistoryAdapter, DanglingUntriaged> history_adapter_;
};
// static

@ -126,7 +126,7 @@ class ImportantSitesUtilTest : public ChromeRenderViewHostTestHarness {
}
private:
raw_ptr<BookmarkModel> model_ = nullptr;
raw_ptr<BookmarkModel, DanglingUntriaged> model_ = nullptr;
};
TEST_F(ImportantSitesUtilTest, TestNoImportantSites) {

@ -280,7 +280,7 @@ class SiteEngagementServiceTest : public ChromeRenderViewHostTestHarness {
}
base::ScopedTempDir temp_dir_;
raw_ptr<SiteEngagementService> service_;
raw_ptr<SiteEngagementService, DanglingUntriaged> service_;
base::SimpleTestClock clock_;
};

@ -78,7 +78,7 @@ class DesktopAttestationService : public AttestationService {
// Owned by the CBCMController, which is eventually owned by the browser
// process. Since the current service is owned at the profile level, this
// respects the browser shutdown sequence.
raw_ptr<DeviceTrustKeyManager> key_manager_;
raw_ptr<DeviceTrustKeyManager, DanglingUntriaged> key_manager_;
// Used for retrieving a managed devices customer ID.
const raw_ptr<policy::CloudPolicyStore> browser_cloud_policy_store_;

@ -166,7 +166,8 @@ class DeviceTrustKeyManagerImplTest : public testing::Test {
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
raw_ptr<StrictMock<MockKeyRotationLauncher>> mock_launcher_;
raw_ptr<StrictMock<MockKeyRotationLauncher>, DanglingUntriaged>
mock_launcher_;
std::unique_ptr<DeviceTrustKeyManagerImpl> key_manager_;
};

@ -115,7 +115,8 @@ class KeyRotationLauncherTest : public testing::Test {
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
base::HistogramTester histogram_tester_;
network::TestURLLoaderFactory test_url_loader_factory_;
raw_ptr<testing::StrictMock<test::MockKeyRotationCommand>> mock_command_;
raw_ptr<testing::StrictMock<test::MockKeyRotationCommand>, DanglingUntriaged>
mock_command_;
ScopedKeyRotationCommandFactory scoped_command_factory_;
policy::FakeBrowserDMTokenStorage fake_dm_token_storage_;
testing::StrictMock<policy::MockJobCreationHandler> job_creation_handler_;

@ -207,11 +207,13 @@ class KeyRotationManagerTest : public testing::Test {
std::unique_ptr<base::HistogramTester> histogram_tester_;
std::unique_ptr<crypto::UnexportableKeyProvider> key_provider_;
raw_ptr<StrictMock<MockKeyNetworkDelegate>> mock_network_delegate_;
raw_ptr<StrictMock<MockKeyPersistenceDelegate>> mock_persistence_delegate_;
raw_ptr<StrictMock<MockKeyNetworkDelegate>, DanglingUntriaged>
mock_network_delegate_;
raw_ptr<StrictMock<MockKeyPersistenceDelegate>, DanglingUntriaged>
mock_persistence_delegate_;
raw_ptr<SigningKeyPair> old_key_pair_;
raw_ptr<SigningKeyPair> new_key_pair_;
raw_ptr<SigningKeyPair, DanglingUntriaged> old_key_pair_;
raw_ptr<SigningKeyPair, DanglingUntriaged> new_key_pair_;
absl::optional<std::string> captured_upload_body_;
std::unique_ptr<KeyRotationManager> key_rotation_manager_;

@ -88,8 +88,9 @@ class RotateUtilTest : public testing::Test {
return command_line;
}
raw_ptr<MockKeyNetworkDelegate> mock_network_delegate_;
raw_ptr<MockKeyPersistenceDelegate> mock_persistence_delegate_;
raw_ptr<MockKeyNetworkDelegate, DanglingUntriaged> mock_network_delegate_;
raw_ptr<MockKeyPersistenceDelegate, DanglingUntriaged>
mock_persistence_delegate_;
std::unique_ptr<KeyRotationManager> key_rotation_manager_;
test::ScopedKeyPersistenceDelegateFactory scoped_factory_;
base::test::TaskEnvironment task_environment_;

@ -235,7 +235,7 @@ class DeviceTrustNavigationThrottleTest : public testing::Test {
mock_user_permission_service_;
std::unique_ptr<FakeDeviceTrustConnectorService> fake_connector_;
base::HistogramTester histogram_tester_;
raw_ptr<MockConsentRequester> mock_consent_requester_;
raw_ptr<MockConsentRequester, DanglingUntriaged> mock_consent_requester_;
};
TEST_F(DeviceTrustNavigationThrottleTest, ExpectHeaderDeviceTrustOnRequest) {

@ -238,7 +238,8 @@ class ClearBrowsingDataAction : public Action,
}
base::flat_set<ActionType> action_types_;
raw_ptr<content::BrowsingDataRemover> browsing_data_remover_for_testing_;
raw_ptr<content::BrowsingDataRemover, DanglingUntriaged>
browsing_data_remover_for_testing_;
base::ScopedObservation<content::BrowsingDataRemover,
content::BrowsingDataRemover::Observer>
observation_{this};

@ -112,7 +112,8 @@ class ActionFactory {
ActionFactory();
raw_ptr<content::BrowsingDataRemover> browsing_data_remover_for_testing_;
raw_ptr<content::BrowsingDataRemover, DanglingUntriaged>
browsing_data_remover_for_testing_;
};
IdleDialog::ActionSet ActionsToActionSet(

@ -45,7 +45,7 @@ class ProfileReportGeneratorDelegateBase
policy::MachineLevelUserCloudPolicyManager* GetCloudPolicyManager() final;
protected:
raw_ptr<Profile> profile_;
raw_ptr<Profile, DanglingUntriaged> profile_;
};
} // namespace enterprise_reporting

@ -331,12 +331,13 @@ class ReportSchedulerTest : public ::testing::Test {
ReportingDelegateFactoryDesktop report_delegate_factory_;
#endif // BUILDFLAG(IS_ANDROID)
std::unique_ptr<ReportScheduler> scheduler_;
raw_ptr<policy::MockCloudPolicyClient> client_;
raw_ptr<MockReportGenerator> generator_;
raw_ptr<MockReportUploader> uploader_;
raw_ptr<MockRealTimeReportGenerator> real_time_generator_;
raw_ptr<MockRealTimeUploader> extension_request_uploader_;
raw_ptr<MockChromeProfileRequestGenerator> profile_request_generator_;
raw_ptr<policy::MockCloudPolicyClient, DanglingUntriaged> client_;
raw_ptr<MockReportGenerator, DanglingUntriaged> generator_;
raw_ptr<MockReportUploader, DanglingUntriaged> uploader_;
raw_ptr<MockRealTimeReportGenerator, DanglingUntriaged> real_time_generator_;
raw_ptr<MockRealTimeUploader, DanglingUntriaged> extension_request_uploader_;
raw_ptr<MockChromeProfileRequestGenerator, DanglingUntriaged>
profile_request_generator_;
#if !BUILDFLAG(IS_CHROMEOS_ASH)
policy::FakeBrowserDMTokenStorage storage_;
#endif

@ -118,7 +118,7 @@ class ClientCertificateFetcherTest : public testing::Test {
private:
content::BrowserTaskEnvironment task_environment_;
raw_ptr<TestingProfile> profile_;
raw_ptr<TestingProfile, DanglingUntriaged> profile_;
std::unique_ptr<TestingProfileManager> profile_manager_;
std::vector<scoped_refptr<net::X509Certificate>> client_certs_;

@ -160,7 +160,7 @@ class AutoSelectCertificateTest : public testing::Test {
scoped_refptr<net::X509Certificate> client_1_;
scoped_refptr<net::X509Certificate> client_2_;
raw_ptr<TestingProfile> profile_;
raw_ptr<TestingProfile, DanglingUntriaged> profile_;
std::unique_ptr<TestingProfileManager> profile_manager_;
};

@ -150,7 +150,7 @@ class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
}
private:
raw_ptr<ActivityDatabaseTestPolicy> db_delegate_;
raw_ptr<ActivityDatabaseTestPolicy, DanglingUntriaged> db_delegate_;
};
// Check that the database is initialized properly.

@ -282,7 +282,7 @@ class ActivityLogTest : public ChromeRenderViewHostTestHarness {
}
}
raw_ptr<ExtensionService> extension_service_;
raw_ptr<ExtensionService, DanglingUntriaged> extension_service_;
};
TEST_F(ActivityLogTest, Construct) {

@ -381,7 +381,7 @@ class CountingPolicyTest : public testing::Test {
protected:
base::SimpleTestClock mock_clock_;
raw_ptr<ExtensionService> extension_service_;
raw_ptr<ExtensionService, DanglingUntriaged> extension_service_;
std::unique_ptr<TestingProfile> profile_;
content::BrowserTaskEnvironment task_environment_;

@ -326,7 +326,7 @@ class FullStreamUIPolicyTest : public testing::Test {
}
protected:
raw_ptr<ExtensionService> extension_service_;
raw_ptr<ExtensionService, DanglingUntriaged> extension_service_;
std::unique_ptr<TestingProfile> profile_;
content::BrowserTaskEnvironment task_environment_;

@ -37,7 +37,7 @@ class TestPredicate : public ContentPredicate {
}
private:
raw_ptr<ContentPredicateEvaluator> evaluator_;
raw_ptr<ContentPredicateEvaluator, DanglingUntriaged> evaluator_;
};
class TestPredicateEvaluator : public ContentPredicateEvaluator {

@ -88,7 +88,7 @@ class DevicePermissionsManagerTest : public testing::Test {
void TearDown() override { env_.reset(nullptr); }
std::unique_ptr<extensions::TestExtensionEnvironment> env_;
raw_ptr<const extensions::Extension> extension_;
raw_ptr<const extensions::Extension, DanglingUntriaged> extension_;
device::FakeUsbDeviceManager fake_usb_manager_;
device::mojom::UsbDeviceInfoPtr device0_;
device::mojom::UsbDeviceInfoPtr device1_;

@ -1313,7 +1313,8 @@ class UserContextGatedTest : public ExtensionApiUnittest {
enterprise_signals::features::kNewEvSignalsEnabled);
}
raw_ptr<device_signals::MockSignalsAggregator> mock_aggregator_;
raw_ptr<device_signals::MockSignalsAggregator, DanglingUntriaged>
mock_aggregator_;
base::test::ScopedFeatureList scoped_features_;
base::HistogramTester histogram_tester_;
};

@ -340,10 +340,11 @@ class PasswordsPrivateDelegateImplTest : public WebAppTest {
}
protected:
raw_ptr<extensions::TestEventRouter> event_router_ = nullptr;
raw_ptr<extensions::TestEventRouter, DanglingUntriaged> event_router_ =
nullptr;
scoped_refptr<TestPasswordStore> profile_store_;
scoped_refptr<TestPasswordStore> account_store_;
raw_ptr<ui::TestClipboard> test_clipboard_;
raw_ptr<ui::TestClipboard, DanglingUntriaged> test_clipboard_;
scoped_refptr<device_reauth::MockDeviceAuthenticator>
biometric_authenticator_;

@ -293,7 +293,7 @@ class ExtensionSettingsSyncTest : public testing::Test {
std::unique_ptr<MockSyncChangeProcessor> sync_processor_;
std::unique_ptr<syncer::SyncChangeProcessorWrapperForTest>
sync_processor_wrapper_;
raw_ptr<SyncValueStoreCache> sync_cache_;
raw_ptr<SyncValueStoreCache, DanglingUntriaged> sync_cache_;
};
// Get a semblance of coverage for both EXTENSION_SETTINGS and APP_SETTINGS

@ -143,7 +143,7 @@ class TabsUpdateFunction : public ExtensionFunction {
std::string* error);
ResponseValue GetResult();
raw_ptr<content::WebContents> web_contents_;
raw_ptr<content::WebContents, DanglingUntriaged> web_contents_;
private:
ResponseAction Run() override;

@ -318,7 +318,7 @@ class WebstorePrivateBeginInstallWithManifest3Test
ExtensionService* extension_service() { return service_; }
private:
raw_ptr<ExtensionService> service_ = nullptr;
raw_ptr<ExtensionService, DanglingUntriaged> service_ = nullptr;
};
TEST_F(WebstorePrivateBeginInstallWithManifest3Test,

@ -607,8 +607,8 @@ class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
protected:
// Weak references, for convenience.
raw_ptr<Extension> app1_;
raw_ptr<Extension> app2_;
raw_ptr<Extension, DanglingUntriaged> app1_;
raw_ptr<Extension, DanglingUntriaged> app2_;
private:
scoped_refptr<Extension> app1_scoped_;

@ -124,7 +124,7 @@ class CorruptedExtensionReinstaller {
base::TimeDelta GetNextFireDelay();
void ScheduleNextReinstallAttempt();
const raw_ptr<content::BrowserContext> context_ = nullptr;
const raw_ptr<content::BrowserContext, DanglingUntriaged> context_ = nullptr;
// A set of extension ids that are being reinstalled due to corruption, mapped
// to the time we detected the corruption.

@ -173,7 +173,7 @@ class ExtensionActionIconFactoryTest
content::BrowserTaskEnvironment task_environment_;
bool quit_in_icon_updated_;
std::unique_ptr<TestingProfile> profile_;
raw_ptr<ExtensionService> extension_service_;
raw_ptr<ExtensionService, DanglingUntriaged> extension_service_;
#if BUILDFLAG(IS_CHROMEOS_ASH)
ash::ScopedCrosSettingsTestHelper cros_settings_test_helper_;

@ -87,7 +87,8 @@ class ExtensionActionRunnerUnitTest : public ChromeRenderViewHostTestHarness {
void SetUp() override;
// The associated ExtensionActionRunner.
raw_ptr<ExtensionActionRunner> extension_action_runner_ = nullptr;
raw_ptr<ExtensionActionRunner, DanglingUntriaged> extension_action_runner_ =
nullptr;
// The map of observed executions, keyed by extension id.
std::map<std::string, int> extension_executions_;

@ -173,7 +173,7 @@ class ExtensionContextMenuModel : public ui::SimpleMenuModel,
// The extension action of the extension we are displaying the menu for (if
// it has one, otherwise NULL).
raw_ptr<ExtensionAction> extension_action_;
raw_ptr<ExtensionAction, DanglingUntriaged> extension_action_;
const raw_ptr<Browser> browser_;

@ -197,7 +197,7 @@ class ExtensionGlobalError : public GlobalErrorWithStandardBubble {
}
raw_ptr<ExtensionErrorUI::Delegate> delegate_;
raw_ptr<ManagementPolicy> management_policy_;
raw_ptr<ManagementPolicy, DanglingUntriaged> management_policy_;
int app_count_ = 0;
int extension_count_ = 0;
bool item_blocked_by_policy_exists_ = false;

@ -355,7 +355,7 @@ class ExtensionInstallPrompt {
// install and returns true. Otherwise returns false.
bool AutoConfirmPromptIfEnabled();
raw_ptr<Profile> profile_;
raw_ptr<Profile, DanglingUntriaged> profile_;
base::ThreadChecker ui_thread_checker_;

@ -57,7 +57,7 @@ class ExtensionInstallPromptShowParams {
bool WasParentDestroyed();
private:
raw_ptr<Profile> profile_;
raw_ptr<Profile, DanglingUntriaged> profile_;
base::WeakPtr<content::WebContents> parent_web_contents_;

@ -205,7 +205,7 @@ class ExtensionMessageBubbleController : public BrowserListObserver,
void OnClose();
// A weak pointer to the Browser we are associated with. Not owned by us.
const raw_ptr<Browser> browser_;
const raw_ptr<Browser, DanglingUntriaged> browser_;
// The associated ToolbarActionsModel. Not owned.
raw_ptr<ToolbarActionsModel> model_;

@ -186,7 +186,7 @@ class FakeExtensionMessageBubble {
bool is_closed_;
ExtensionBubbleAction action_;
raw_ptr<ExtensionMessageBubbleController> controller_;
raw_ptr<ExtensionMessageBubbleController, DanglingUntriaged> controller_;
};
class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {
@ -425,7 +425,7 @@ class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {
}
protected:
raw_ptr<ExtensionService> service_;
raw_ptr<ExtensionService, DanglingUntriaged> service_;
private:
std::unique_ptr<base::CommandLine> command_line_;

@ -216,7 +216,7 @@ class ExtensionServiceTestBase : public testing::Test {
// The ExtensionService, whose lifetime is managed by |profile|'s
// ExtensionSystem.
raw_ptr<ExtensionService> service_;
raw_ptr<ExtensionService, DanglingUntriaged> service_;
ScopedTestingLocalState testing_local_state_;
private:
@ -233,7 +233,7 @@ class ExtensionServiceTestBase : public testing::Test {
content::InProcessUtilityThreadHelper in_process_utility_thread_helper_;
// The associated ExtensionRegistry, for convenience.
raw_ptr<extensions::ExtensionRegistry> registry_;
raw_ptr<extensions::ExtensionRegistry, DanglingUntriaged> registry_;
#if BUILDFLAG(IS_CHROMEOS_ASH)
ash::ScopedCrosSettingsTestHelper cros_settings_test_helper_;

@ -166,7 +166,7 @@ class ExtensionServiceTestWithInstall : public ExtensionServiceUserTestBase,
int creation_flags);
extensions::ExtensionList loaded_extensions_;
raw_ptr<const Extension> installed_extension_;
raw_ptr<const Extension, DanglingUntriaged> installed_extension_;
bool was_update_;
std::string old_name_;
std::string unloaded_id_;

@ -45,7 +45,7 @@ class ExtensionUtilUnittest : public ExtensionServiceTestBase {
}
protected:
raw_ptr<TestingProfile> signin_profile_;
raw_ptr<TestingProfile, DanglingUntriaged> signin_profile_;
private:
std::unique_ptr<TestingProfileManager> testing_profile_manager_;

@ -71,7 +71,7 @@ class ExtensionWebUITest : public testing::Test {
}
std::unique_ptr<TestingProfile> profile_;
raw_ptr<ExtensionService> extension_service_;
raw_ptr<ExtensionService, DanglingUntriaged> extension_service_;
content::BrowserTaskEnvironment task_environment_;
#if BUILDFLAG(IS_CHROMEOS_ASH)

@ -110,7 +110,8 @@ class ExternalInstallManager : public ExtensionRegistryObserver {
std::set<ExtensionId> shown_ids_;
// The error that is currently showing an alert dialog/bubble.
raw_ptr<ExternalInstallError> currently_visible_install_alert_;
raw_ptr<ExternalInstallError, DanglingUntriaged>
currently_visible_install_alert_;
base::ScopedObservation<ExtensionRegistry, ExtensionRegistryObserver>
extension_registry_observation_{this};

Some files were not shown because too many files have changed in this diff Show More