0

FaceGaze: Address TODO in mediapipe test

There was a TODO in the FaceGazeMediaPipeTest suite to allow messages
emitted by the mediapipe wasm. However after investigation, some of
these messages are variable based on the time the tests are run. As a
result, we cannot fully address the TODO.

Instead, we remove the TODO and provide commentary on why we allow
console messages.

Bug: 309121742
Change-Id: I8ecfc7eeab8884afa5e4782c8cd5e938b215410f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5971557
Reviewed-by: Jesulayomi Kupoluyi <lkupo@google.com>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1374675}
This commit is contained in:
Akihiro Ota
2024-10-28 16:43:35 +00:00
committed by Chromium LUCI CQ
parent 8882b4ebb3
commit e9cec515b1

@ -15,8 +15,10 @@ FaceGazeMediaPipeTest = class extends FaceGazeTestBase {
/** @override */
testGenPreamble() {
super.testGenPreamble();
// TODO(b/309121742): change `failOnConsoleError` to true and specify
// allowed messages from mediapipe wasm.
// The mediapipe wasm emits console messages when the FaceLandmarker is
// initialized. Some of these messages are variable because they include
// information about time, so we cannot set a static list of allowed
// messages. As a result, we set `failOnConsoleError` to false.
super.testGenPreambleCommon(
/*extensionIdName=*/ 'kAccessibilityCommonExtensionId',
/*failOnConsoleError=*/ false);