0

Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again.

Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions.

Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall.

BUG=504347

Review-Url: https://codereview.chromium.org/2727913006
Cr-Commit-Position: refs/heads/master@{#454922}
This commit is contained in:
jam
2017-03-06 11:45:02 -08:00
committed by Commit bot
parent 11a3425fff
commit ebeb36a0ed
2 changed files with 48 additions and 1 deletions

@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/run_loop.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/test/browser_test.h"
#include "headless/public/devtools/domains/network.h"
#include "headless/public/devtools/domains/page.h"
@ -168,11 +170,24 @@ class ProtocolHandlerRequestIdCorrelationTest
public page::Observer {
public:
void RunDevTooledTest() override {
if (content::IsBrowserSideNavigationEnabled()) {
// TODO: get this working with PlzNavigate.
// See discussion on https://codereview.chromium.org/2695923010/
FinishAsynchronousTest();
return;
}
EXPECT_TRUE(embedded_test_server()->Start());
devtools_client_->GetPage()->AddObserver(this);
devtools_client_->GetPage()->Enable();
base::RunLoop run_loop;
devtools_client_->GetNetwork()->AddObserver(this);
devtools_client_->GetNetwork()->Enable();
devtools_client_->GetNetwork()->Enable(run_loop.QuitClosure());
base::MessageLoop::ScopedNestableTaskAllower nest_loop(
base::MessageLoop::current());
run_loop.Run();
devtools_client_->GetPage()->Navigate("http://foo.com/index.html");
}

@ -2950,6 +2950,16 @@
},
"test": "headless_browsertests"
},
{
"args": [
"--enable-browser-side-navigation"
],
"name": "browser_side_navigation_headless_browsertests",
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "headless_browsertests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
@ -3611,6 +3621,28 @@
},
"test": "gpu_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "headless_browsertests"
},
{
"args": [
"--enable-browser-side-navigation"
],
"name": "browser_side_navigation_headless_browsertests",
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "headless_browsertests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "headless_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true,