0

Enable toolchains to define extra asm flags

Currently running into a problem with compiling chromecast source with
aarch64 toolchain. Since I can't provide asm flags, the CC looks for an
assembler to compile with in my PATH, which ends up picking my host
assembler, which doesn't work.

Need to pass -B/path/to/toolchain so the CC may find the proper -as

BUG= None
TEST=Build

Change-Id: Ifa3790954e7779e44272f48f46521295f57422d0
Reviewed-on: https://chromium-review.googlesource.com/646733
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502304}
This commit is contained in:
Mina Almasry
2017-09-15 18:05:55 +00:00
committed by Commit Bot
parent a5c648fab6
commit ed4edf011b

@ -45,6 +45,8 @@ analyzer_wrapper =
# "CXX" (which follows).
# - extra_cxxflags
# Extra flags to be appended when compiling C++ files (but not C files).
# - extra_asmflags
# Extra flags to be appended when compiling assembly.
# - extra_ldflags
# Extra flags to be appended when linking
#
@ -251,6 +253,12 @@ template("gcc_toolchain") {
extra_cxxflags = ""
}
if (defined(invoker.extra_asmflags) && invoker.extra_asmflags != "") {
extra_asmflags = " " + invoker.extra_asmflags
} else {
extra_asmflags = ""
}
if (defined(invoker.extra_ldflags) && invoker.extra_ldflags != "") {
extra_ldflags = " " + invoker.extra_ldflags
} else {
@ -306,7 +314,7 @@ template("gcc_toolchain") {
tool("asm") {
# For GCC we can just use the C compiler to compile assembly.
depfile = "{{output}}.d"
command = "$asm -MMD -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{asmflags}} -c {{source}} -o {{output}}"
command = "$asm -MMD -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{asmflags}}${extra_asmflags} -c {{source}} -o {{output}}"
depsformat = "gcc"
description = "ASM {{output}}"
outputs = [