0

PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1816563002

Cr-Commit-Position: refs/heads/master@{#382833}
This commit is contained in:
clamy
2016-03-23 05:31:47 -07:00
committed by Commit bot
parent b9f18314c2
commit eeb96fdeec
2 changed files with 1 additions and 1 deletions

@@ -554,6 +554,7 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest, MismatchedOriginOnCommit) {
exit_observer.Wait();
EXPECT_FALSE(exit_observer.did_exit_normally());
ResourceDispatcherHost::Get()->SetDelegate(nullptr);
}
} // namespace content

@@ -6,7 +6,6 @@
-RenderViewImplTest.GetCompositionCharacterBoundsTest
-RenderViewImplTest.OnNavigationHttpPost
-RenderViewImplTest.TestBackForward
-SecurityExploitBrowserTest.MismatchedOriginOnCommit
-ServiceWorkerBrowserTest.FetchPageWithSaveData
-ServiceWorkerBrowserTest.FetchPageWithSaveDataPassThroughOnFetch
-SessionHistoryTest.FrameBackForward