chromium/src
0
Fork 0
Code Activity

[TEST ONLY] Add missing aggregateWinSignals check in bidder worklet's

Browse Source 
unittest

Change-Id: Ifaf4ee8211cc2e2478b8354f4c31976d12301dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119682
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
Reviewed-by: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1401860}
This commit is contained in:
Youssef Bourouphael
2025-01-03 09:35:13 -08:00
committed by Chromium LUCI CQ
parent 47e7d9dbef
commit f1126dcbff
1 changed files with 4 additions and 2 deletions

6
content/services/auction_worklet/bidder_worklet_unittest.cc

@ -551,6 +551,8 @@ class BidderWorkletTest : public testing::Test {
blink::PrintableAdCurrency(bids_[i]->bid_currency));
EXPECT_EQ(expected_bid->ad_descriptor.url, bids_[i]->ad_descriptor.url);
EXPECT_EQ(expected_bid->ad_descriptor.size, bids_[i]->ad_descriptor.size);
EXPECT_EQ(expected_bid->aggregate_win_signals,
bids_[i]->aggregate_win_signals);
if (!expected_bid->ad_component_descriptors) {
EXPECT_FALSE(bids_[i]->ad_component_descriptors);
} else {
@ -2498,7 +2500,7 @@ TEST_F(PrivateModelTrainingEnabledTest, GenerateBidAggregateWinSignals) {
/*modeling_signals=*/
std::nullopt,
/*aggregate_win_signals=*/
R"({"test_array":[1,2,3],"test_number":1.0,"test_string":"hello"})",
R"({"test_array":[1,2,3],"test_number":1,"test_string":"hello"})",
base::TimeDelta()));
}
@ -2526,7 +2528,7 @@ class PrivateModelTrainingDisabledTest : public BidderWorkletTest {
};
TEST_F(PrivateModelTrainingDisabledTest,
GenerateBidModelingSignalsNotAffected) {
GenerateBidAggregateWinSignalsNotAffected) {
const std::string kGenerateBidBody =
R"({bid:1, render:"https://response.test/",
aggregateWinSignals: {