0

Fix _CheckNoDISABLETypoInTests when test file is deleted.

TBR=jochen@chromium.org

Bug: 888425
Change-Id: I8ff979ae3d969ccff7ca9cbb1ec1deb86f65535a
Reviewed-on: https://chromium-review.googlesource.com/1241956
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593847}
This commit is contained in:
Katie D
2018-09-25 07:33:44 +00:00
committed by Commit Bot
parent fb6c96410a
commit f13948e30b
2 changed files with 10 additions and 1 deletions

@ -877,7 +877,7 @@ def _CheckNoDISABLETypoInTests(input_api, output_api):
r'^\s*TEST[^(]*\([a-zA-Z0-9_]+,\s*DISABLE_[a-zA-Z0-9_]+\)',
input_api.re.MULTILINE)
for f in input_api.AffectedFiles():
for f in input_api.AffectedFiles(False):
if not 'test' in f.LocalPath() or not f.LocalPath().endswith('.cc'):
continue

@ -2072,6 +2072,15 @@ class DISABLETypoInTest(unittest.TestCase):
MockOutputApi())
self.assertEqual(0, len(results))
def testIngoreDeletedFiles(self):
mock_input_api = MockInputApi()
mock_input_api.files = [
MockFile('some/path/foo.cc', 'TEST_F(FoobarTest, Foo)', action='D'),
]
results = PRESUBMIT._CheckNoDISABLETypoInTests(mock_input_api,
MockOutputApi())
self.assertEqual(0, len(results))
if __name__ == '__main__':
unittest.main()