0

[Extensions] Clean up dependencies in extensions/browser/api. (1a)

This a reland of f3df55ae2d. It adds
an explicit public_dep to the automationInternal API that's needed
for a fuzzer test.

This is the first in a series of CLS to clean up the dependencies in
the various API implementations.

Bug: 40593486
Change-Id: I00bb1fdbab85778caa7eae228e048332610626c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090029
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395196}
This commit is contained in:
David Bertoni
2024-12-11 17:18:30 -08:00
committed by Chromium LUCI CQ
parent 2ef4dd1e5a
commit f15f0b58c0
11 changed files with 84 additions and 45 deletions
extensions/browser/api
alarms
app_current_window_internal
app_runtime
app_window
audio
automation_internal
bluetooth
bluetooth_low_energy
bluetooth_socket
cec_private
content_settings

@ -19,11 +19,10 @@ source_set("alarms") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//extensions/browser:browser_sources",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [ "//extensions/browser:browser_sources" ]
}

@ -15,11 +15,15 @@ source_set("app_current_window_internal") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
"//content/public/browser",
"//extensions/common",
"//extensions/common/api",
public_deps = [
"//base",
"//extensions/browser:browser_sources",
]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//extensions/common",
"//extensions/common/api",
"//skia",
"//ui/gfx/geometry",
]
}

@ -15,12 +15,16 @@ source_set("app_runtime") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//extensions/browser:browser_sources",
"//extensions/common/api",
"//url",
]
allow_circular_includes_from = [ "//extensions/browser:browser_sources" ]
}

@ -15,12 +15,19 @@ source_set("app_window") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//base",
"//build:chromeos_buildflags",
"//content/public/browser",
"//content/public/common",
"//extensions/common",
"//extensions/common:mojom",
"//extensions/common/api",
"//skia",
"//ui/base/mojom:ui_base_types",
"//ui/gfx/geometry",
"//url",
]
public_deps = [ "//extensions/browser:browser_sources" ]
}

@ -21,14 +21,14 @@ source_set("audio") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//components/prefs",
"//extensions/common",
public_deps = [
"//base",
"//extensions/browser:browser_sources",
"//extensions/common/api",
]
deps = [ "//components/prefs" ]
if (!is_chromeos) {
sources += [ "audio_service.cc" ]
} else {
@ -37,9 +37,11 @@ source_set("audio") {
"audio_service_utils.cc",
"audio_service_utils.h",
]
public_deps += [ "//chromeos/crosapi/mojom" ]
deps += [
"//chromeos/ash/components/audio",
"//chromeos/crosapi/mojom",
"//content/public/browser",
]
}

@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//build/config/ui.gni")
import("//extensions/buildflags/buildflags.gni")
assert(enable_extensions,
@ -21,16 +22,23 @@ source_set("automation_internal") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
public_deps = [
"//base",
"//content/public/browser",
"//extensions/browser:browser_sources",
"//extensions/browser/api/app_runtime:app_runtime",
"//extensions/common",
"//extensions/common:mojom",
"//extensions/common/api",
"//services/accessibility/public/mojom:automation",
"//ui/accessibility:ax_base",
]
deps = [
"//build:chromeos_buildflags",
"//components/prefs",
"//content/public/browser",
"//extensions/common",
"//extensions/common/api",
"//third_party/blink/public/common",
]
if (use_aura) {
deps += [ "//ui/aura" ]
}
}

@ -25,13 +25,17 @@ source_set("bluetooth") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//build:chromeos_buildflags",
"//components/device_event_log",
"//content/public/browser",
"//device/bluetooth",
"//extensions/browser:browser_sources",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//components/device_event_log",
"//content/public/browser",
]
}

@ -25,15 +25,18 @@ source_set("bluetooth_low_energy") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//content/public/browser",
"//device/bluetooth",
"//device/bluetooth/public/cpp",
"//extensions/browser:browser_sources",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [
"//content/public/browser",
"//extensions/browser:browser_sources",
deps = [
"//extensions/browser/kiosk",
"//net",
]
}

@ -19,11 +19,15 @@ source_set("bluetooth_socket") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//content/public/browser",
"//device/bluetooth",
"//device/bluetooth/public/cpp",
"//extensions/browser:browser_sources",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [ "//net" ]
}

@ -14,19 +14,19 @@ source_set("cec_private") {
"cec_private_api.cc",
"cec_private_api.h",
"cec_private_delegate.h",
"cec_private_delegate_ash.cc",
]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
"//extensions/common",
public_deps = [
"//base",
"//extensions/browser:browser_sources",
"//extensions/common/api",
]
if (is_chromeos) {
sources += [ "cec_private_delegate_ash.cc" ]
deps += [ "//chromeos/ash/components/dbus/cec_service" ]
}
public_deps = [ "//extensions/browser:browser_sources" ]
deps = [
"//chromeos/ash/components/dbus/cec_service",
"//extensions/common",
]
}

@ -18,14 +18,18 @@ source_set("content_settings") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
public_deps = [
"//base",
"//components/content_settings/core/browser",
"//components/content_settings/core/common",
"//components/permissions:permissions_common",
"//content/public/browser",
"//content/public/common",
"//extensions/common",
"//extensions/common/api",
]
deps = [
"//components/permissions:permissions_common",
"//content/public/browser",
"//content/public/common",
"//url",
]
}