chromium/src
0
Fork 0
Code Activity

Modify markdown to satisfy Windows Defender

Browse Source 
debugging_gpu_related_code.md explains how to use a Chrome command-line
switch which has been used for arbitrary code execution. Windows
Defender therefore treats it as malware. This means that some Windows
Chromium developers will get anti-virus warnings (with mandatory
quarantining of the file). If Chrome is in a directory that is
excluded from scanning then they will avoid warnings but will hit
problems if they try to use Windows backup.

This is all very silly since there is no way - short of manually
following the steps, modify to be malicious - to activate this payload.
Windows Defender even complains about the file created by this:

  > echo --no-sandbox --gpu-launcher="x" >foo.txt

But, sometimes it's not worth arguing.

This also fixes a typo.

R=kainino@chromium.org
BUG=851562

Change-Id: I85403a1cb1667f45784684179927119058608d40
Reviewed-on: https://chromium-review.googlesource.com/1096311
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566245}
This commit is contained in:
Bruce Dawson
2018-06-12 01:47:03 +00:00
committed by Commit Bot
parent 7ab55fe0db
commit f17419f416
1 changed files with 7 additions and 5 deletions

12
docs/gpu/debugging_gpu_related_code.md

@ -188,7 +188,7 @@ This will print the name of each GPU command before it is executed.
### Debugging in the GPU Process
Given the multi-processness of chromium it can be hard to debug both sides.
Turing on all the logging and having a small test case is useful. One minor
Turning on all the logging and having a small test case is useful. One minor
suggestion, if you have some idea where the bug is happening a call to some
obscure gl function like `glHint()` can give you a place to catch a command
being processed in the GPU process (put a break point on
@ -197,15 +197,17 @@ after that. All of them go through `gpu::gles2::GLES2DecoderImpl::DoCommand`.
To actually debug the GPU process:
On Linux this works for me:
On Linux this works for me (the quotes around launcher can be omitted - they are
there to stop Windows Defender from complaining about this file):
* `out/Debug/chromium --no-sandbox --gpu-launcher="xterm -e gdb --args"
* `out/Debug/chromium --no-sandbox --gpu-"launcher"="xterm -e gdb --args"
http://localhost:8000/page-to-repro.html`
On OSX this works for me:
On OSX this works for me (the quotes around launcher can be omitted - they are
there to stop Windows Defender from complaining about this file):
* `out/Debug/Chromium.app/Contents/MacOSX/Chromium --no-sandbox
--gpu-launcher="xterm -e gdb --args"
--gpu-"launcher"="xterm -e gdb --args"
http://localhost:8000/page-to-repro.html`
On Windows I use `--gpu-startup-dialog` and then connect to the listed process.