chromium/src
0
Fork 0
Code Activity

[CrOS Hotspot] Fixing UI strings based on dogfood feedback

Browse Source 
This change fixes the following strings:
  Title and subtext on the sticky notification displayed when hotspot is
on.
  Sublabel in quick settings when Hotspot is on and no devices are
connected.
  Subtext in network settings when hotspot is turning on.

Bug: b/304410547
Change-Id: I2b4510d057174902595263a19ce452ecf9ce43ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4944745
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jason Zhang <jiajunz@google.com>
Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com>
Cr-Commit-Position: refs/heads/main@{#1211193}
This commit is contained in:
Nikhil Nayunigari
2023-10-17 23:51:02 +00:00
committed by Chromium LUCI CQ
parent 6df4aa0bc8
commit f22b83db41
11 changed files with 16 additions and 16 deletions

12
ash/ash_strings.grd

@ -3000,7 +3000,7 @@ Some features are limited to increase battery life.
This setting is managed by your administrator
</message>
<message name="IDS_ASH_HOTSPOT_DETAILED_VIEW_ON_NO_CONNECTED_DEVICES" desc="The subtext in the hotspot detailed view when hotspot is on and no devices connected to it.">
On, no devices connected
No devices connected
</message>
<message name="IDS_ASH_HOTSPOT_DETAILED_VIEW_TITLE" desc="The label in the hotspot detailed view for the Chromebook Hotspot.">
<ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot
@ -3024,7 +3024,7 @@ Some features are limited to increase battery life.
<ph name="DEVICE_NAME">$1<ex>Chromebook</ex></ph> hotspot is on, no devices connected
</message>
<message name="IDS_ASH_HOTSPOT_ON_TITLE" desc="Title used for the system notification shown when the hotspot is turned on.">
Hotspot is on
With hotspot on, Wi-Fi is off
</message>
<message name="IDS_ASH_HOTSPOT_ON_MESSAGE_MULTIPLE_CONNECTED_DEVICES" desc="Message displayed in the notification when hotspot is turned on and multiple devices are connected.">
<ph name="DEVICECOUNT">$1</ph> devices connected
@ -3033,16 +3033,16 @@ Some features are limited to increase battery life.
1 device connected
</message>
<message name="IDS_ASH_HOTSPOT_ON_MESSAGE_NO_CONNECTED_DEVICES_NOTIFICATION" desc="Message displayed in the notification when hotspot is turned on and no devices are connected.">
No devices connected. WiFi will be turned off to start using Hotspot.
No devices connected. While using hotspot, Wi-Fi will stay off.
</message>
<message name="IDS_ASH_HOTSPOT_ON_MESSAGE_MULTIPLE_CONNECTED_DEVICES_NOTIFICATION" desc="Message displayed in the notification when hotspot is turned on and multiple devices are connected.">
<ph name="DEVICECOUNT">$1</ph> devices connected. WiFi will be turned off to start using Hotspot.
<ph name="DEVICECOUNT">$1</ph> devices connected. While using hotspot, Wi-Fi will stay off.
</message>
<message name="IDS_ASH_HOTSPOT_ON_MESSAGE_ONE_CONNECTED_DEVICE_NOTIFICATION" desc="Message displayed in the notification when hotspot is turned on and one device is connected.">
1 device connected. WiFi will be turned off to start using Hotspot.
1 device connected. While using hotspot, Wi-Fi will stay off.
</message>
<message name="IDS_ASH_TURN_OFF_HOTSPOT_LABEL" desc="The label for button used to turn off hotspot.">
Turn off
Turn off hotspot
</message>
<message name="IDS_ASH_HOTSPOT_OFF_TITLE" desc="Title used for the system notification shown when the hotspot is turned off.">
Hotspot is off

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_DETAILED_VIEW_ON_NO_CONNECTED_DEVICES.png.sha1

@ -1 +1 @@
449aee573419661208ece4448484059f0f93c781
c9099b288aa0ba092dd758db95ff609cf869f02d

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_ON_MESSAGE_MULTIPLE_CONNECTED_DEVICES_NOTIFICATION.png.sha1

@ -1 +1 @@
f2493be3f05b34ae8b2f5bf11a0ce78de5793a21
3e5b948d216121a750c047e6ba20d33fe76f0ddd

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_ON_MESSAGE_NO_CONNECTED_DEVICES_NOTIFICATION.png.sha1

@ -1 +1 @@
378ba35d98490cd74ab6a449ded68735d296f58c
167bbace32f85db9c014f9b837dd3a1b97b427f5

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_ON_MESSAGE_ONE_CONNECTED_DEVICE_NOTIFICATION.png.sha1

@ -1 +1 @@
14e10a123990d633cdc0c0c01b3e9d921605ed6a
fee146bfb5d14f0f25b81894d90a11a865615937

2
ash/ash_strings_grd/IDS_ASH_HOTSPOT_ON_TITLE.png.sha1

@ -1 +1 @@
dad69cfe3fea482fe4f8016432a7f3f4abeccc50
167bbace32f85db9c014f9b837dd3a1b97b427f5

2
ash/ash_strings_grd/IDS_ASH_TURN_OFF_HOTSPOT_LABEL.png.sha1

@ -1 +1 @@
a821d35b75651ddc38241482c5293a34e6c2105b
167bbace32f85db9c014f9b837dd3a1b97b427f5

2
ash/system/hotspot/hotspot_detailed_view_controller_unittest.cc

@ -142,7 +142,7 @@ TEST_F(HotspotDetailedViewControllerTest, NotifiesWhenHotspotInfoChanges) {
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(toggle->GetIsOn());
AssertSubtextLabel(u"On, no devices connected");
AssertSubtextLabel(u"No devices connected");
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed,
/*client_count=*/1);

2
ash/system/hotspot/hotspot_detailed_view_unittest.cc

@ -191,7 +191,7 @@ TEST_F(HotspotDetailedViewTest, HotspotEnabledUI) {
ASSERT_TRUE(hotspot_detailed_view_);
AssertTextLabel(kHotspotTitle);
AssertSubtextLabel(u"On, no devices connected");
AssertSubtextLabel(u"No devices connected");
AssertEntryRowEnabled();
AssertToggleOn(/*expected_toggle_on=*/true,
/**expected_toggle_enabled=*/true);

2
chrome/app/os_settings_strings.grdp

@ -3894,7 +3894,7 @@ Press an assigned switch or key to remove assignment.
On
</message>
<message name="IDS_SETTINGS_INTERNET_HOTSPOT_SUMMARY_STATE_TURNING_ON" desc="Sublabel for Hotspot summary row, when Hotspot is turning on.">
Turning On...
Turning on...
</message>
<message name="IDS_SETTINGS_INTERNET_HOTSPOT_SUMMARY_STATE_OFF" desc="Sublabel for Hotspot summary row, when Hotspot is off.">
Off

2
chrome/app/os_settings_strings_grdp/IDS_SETTINGS_INTERNET_HOTSPOT_SUMMARY_STATE_TURNING_ON.png.sha1

@ -1 +1 @@
c70e5edbf19b8330c1176b5d3527a3b253a5a9dd
6d6b665e0d402fe049ca8e26d2b4a0af3a853d32