chromium/src
0
Fork 0
Code Activity

Rename and clarify ManagedUsers.SafeSitesDelay metric

Browse Source 
The name and description of the histogram are inaccurate: supervised
user filtering does not use this endpoint; only Enterprise filtering
uses it.

I have renamed the histogram and updated the histogram description.
In passing I think the ownership of both the code and histograms
should move to the Enterprise team.

OBSOLETE_HISTOGRAM[ManagedUsers.SafeSitesDelay]=Renamed to Enterprise.SafeSites.Latency

Bug: b/299088120
Change-Id: Ib92700d03e9a0a1b63700d84d20706cc9899267c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4898199
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Sébastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: James Lee <ljjlee@google.com>
Auto-Submit: James Lee <ljjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1204557}
This commit is contained in:
James Lee
2023-10-03 10:28:41 +00:00
committed by Chromium LUCI CQ
parent cf287b716e
commit f234769a2f
4 changed files with 17 additions and 15 deletions
components/safe_search_api
OWNERS
safe_search
safe_search_url_checker_client.cc
tools/metrics/histograms/metadata
enterprise
histograms.xml
families
histograms.xml

2
components/safe_search_api/OWNERS

@ -1,2 +1,2 @@
treib@chromium.org
agawronska@chromium.org
agawronska@chromium.org

7
components/safe_search_api/safe_search/safe_search_url_checker_client.cc

@ -8,7 +8,7 @@
#include "base/functional/callback.h"
#include "base/json/json_reader.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/histogram_functions.h"
#include "base/strings/escape.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
@ -147,9 +147,8 @@ void SafeSearchURLCheckerClient::OnSimpleLoaderComplete(
: ClientClassification::kAllowed;
}
// TODO(msramek): Consider moving this to SupervisedUserResourceThrottle.
UMA_HISTOGRAM_TIMES("ManagedUsers.SafeSitesDelay",
base::TimeTicks::Now() - check->start_time);
base::UmaHistogramTimes("Enterprise.SafeSites.Latency",
base::TimeTicks::Now() - check->start_time);
std::move(check->callback).Run(check->url, classification);
}

13
tools/metrics/histograms/metadata/enterprise/histograms.xml

@ -2685,6 +2685,19 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Enterprise.SafeSites.Latency" units="ms"
expires_after="2024-02-11">
<owner>ftirelo@chromium.org</owner>
<owner>ljjlee@google.com</owner>
<owner>cbe-eng@google.com</owner>
<summary>
The latency of the request to the SafeSites API to classify URLs for users
with the SafeSitesFilterBehavior policy. This is measured once per
classified URL that requires a network request (URLs returned from the cache
are not recorded).
</summary>
</histogram>
<histogram
name="Enterprise.SecondaryGoogleAccountUsage.PolicyFetch.ResponseLatency"
units="ms" expires_after="2023-10-04">

10
tools/metrics/histograms/metadata/families/histograms.xml

@ -785,16 +785,6 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="ManagedUsers.SafeSitesDelay" units="ms"
expires_after="2024-02-11">
<owner>agawronska@chromium.org</owner>
<owner>cros-families-eng@google.com</owner>
<summary>
The extra page load delays introduced by network requests due to the
supervised user SafeSites feature, measured once per page load.
</summary>
</histogram>
<histogram name="SupervisedUsers.ExtensionEnablement"
enum="SupervisedUserExtensionEnablement" expires_after="2024-02-11">
<owner>courtneywong@chromium.org</owner>