chromium/src
0
Fork 0
Code Activity

customization: Use finalized strings for peripheral notification

Browse Source 
https://screenshot.googleplex.com/8QnUS6ZcT2yGZp9
https://screenshot.googleplex.com/BtnWu3c7gVTwVEJ

Bug: b:241965717
Change-Id: I19f9d5301b7f041ceb4f2a0feb2d0bc86e042125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283105
Reviewed-by: Danny Wang <wangdanny@google.com>
Commit-Queue: David Padlipsky <dpad@google.com>
Cr-Commit-Position: refs/heads/main@{#1258847}
This commit is contained in:
David Padlipsky
2024-02-10 02:15:40 +00:00
committed by Chromium LUCI CQ
parent 16127241ef
commit f342c00b00
6 changed files with 15 additions and 13 deletions

11
ash/ash_strings.grd

@ -7519,14 +7519,17 @@ To shut down the device, press and hold the power button on the device again.
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_ALT_RIGHT_CLICK" desc="The message shown to notify a user that the shortcut used to simulate a right-click using touchpad and keyboard has changed.">
The right-click shortcut is updated to <ph name="LAUNCHER_KEY_NAME">$1<ex>launcher</ex></ph> key + click from alt + click
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE" desc="Notification title to tell users that the peripheral is customizable.">
Customize your <ph name="PERIPHERAL_NAME">$1<ex>MX Anywhere</ex></ph>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE" desc="Notification title to tell users that the mouse is customizable.">
Customize your mouse
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_GRAPHICS_TABLET_TITLE" desc="Notification title to tell users that the graphics tablet is customizable.">
Customize your tablet
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_MOUSE_CUSTOMIZATION" desc="The message shown to notify a user that the mouse is customizable in settings.">
<ph name="PERIPHERAL_NAME">$1<ex>MX Anywhere</ex></ph> is connected and ready to use. You can customize your mouse in Settings.
You can personalize button actions, cursor speed, and more for your <ph name="PERIPHERAL_NAME">$1<ex>MX Anywhere</ex></ph>
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_GRAPHICS_TABLET_CUSTOMIZATION" desc="The message shown to notify a user that the graphics tablet is customizable in settings.">
<ph name="PERIPHERAL_NAME">$1<ex>MX Anywhere</ex></ph> is connected and ready to use. You can customize your graphics tablet in Settings.
You can personalize button actions for your <ph name="PERIPHERAL_NAME">$1<ex>MX Anywhere</ex></ph>
</message>
<message name="IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_OPEN_SETTINGS_BUTTON" desc="Notification button text, if the user clicks on the button it will redirect them to the Settings App.">
Open Settings

2
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_GRAPHICS_TABLET_CUSTOMIZATION.png.sha1

@ -1 +1 @@
c5e6e072c6af948a2842fe3095549fa1bd62ac80
bec3b7701c3321e168443bfcc33fd591d8b5840b

2
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_MOUSE_CUSTOMIZATION.png.sha1

@ -1 +1 @@
c15b9eb1d83ba8063a0c05de7c5f7082fe5e6e7f
5bdc853df0a74efdcf5dfcecd49bc39c80fc1d02

1
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_GRAPHICS_TABLET_TITLE.png.sha1 Normal file

@ -0,0 +1 @@
7dbace45747dd768d63636692dd679ec355237a3

2
ash/ash_strings_grd/IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE.png.sha1

@ -1 +1 @@
c15b9eb1d83ba8063a0c05de7c5f7082fe5e6e7f
3412cb8df10d2ec6f6bbff9cfbd75d4d19cda76a

10
ash/system/input_device_settings/input_device_settings_notification_controller.cc

@ -588,9 +588,8 @@ void InputDeviceSettingsNotificationController::NotifyMouseIsCustomizable(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_OPEN_SETTINGS_BUTTON));
auto notification = CreateSystemNotificationPtr(
message_center::NOTIFICATION_TYPE_SIMPLE, notification_id,
l10n_util::GetStringFUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE,
peripheral_name),
l10n_util::GetStringUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE),
l10n_util::GetStringFUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_MOUSE_CUSTOMIZATION,
peripheral_name),
@ -618,9 +617,8 @@ void InputDeviceSettingsNotificationController::
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_OPEN_SETTINGS_BUTTON));
auto notification = CreateSystemNotificationPtr(
message_center::NOTIFICATION_TYPE_SIMPLE, notification_id,
l10n_util::GetStringFUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_TITLE,
peripheral_name),
l10n_util::GetStringUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_PERIPHERAL_CUSTOMIZATION_GRAPHICS_TABLET_TITLE),
l10n_util::GetStringFUTF16(
IDS_ASH_DEVICE_SETTINGS_NOTIFICATIONS_GRAPHICS_TABLET_CUSTOMIZATION,
peripheral_name),