0

Split out tast_control so we can watch changes to tast_disabled_tests.

Bug: 1157356
Change-Id: Ic6762bfa9c1e3f1978ff0a8197f0f80f4800eec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643678
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847490}
This commit is contained in:
Nicholas Verne
2021-01-27 04:08:05 +00:00
committed by Chromium LUCI CQ
parent 07c3583ce7
commit f4b76305d5
5 changed files with 56 additions and 35 deletions

@ -807,6 +807,9 @@
'ui/chromeos/network/|'\
'ui/webui/resources/cr_components/chromeos/network/'
},
'chromeos_tast_control': {
'filepath': 'chromeos/tast_control.gni',
},
'chromeos_timezone': {
'filepath': 'chromeos/timezone/',
},
@ -2409,6 +2412,8 @@
'jonmann+watch-network@chromium.org',
'stevenjb+watch-network@chromium.org',
'vecore+watch-network@google.com'],
'chromeos_tast_control': ['chromeos-engprod+watch@google.com',
'bpastene+watch@chromium.org'],
'chromeos_timezone': ['alemate+watch@chromium.org'],
'chromeos_webui': ['alemate+watch@chromium.org'],
'chromeos_wifi_sync': ['jonmann+watch@chromium.org',

@ -8,6 +8,7 @@ import("//build/config/ui.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
import("//testing/test.gni")
import("//third_party/protobuf/proto_library.gni")
import("./tast_control.gni")
assert(is_chromeos, "Non-Chrome-OS builds must not depend on //chromeos")
@ -260,40 +261,10 @@ if (is_chromeos_device) {
# Tast test sources live in the Chromium OS repository.
# To diagnose tast failures or disable tests, see go/tast-failures
tast_test("chrome_all_tast_tests") {
# To disable a specific test, add it the following list and cite a bug.
tast_disabled_tests = [
# crbug.com/1162346
"ui.WindowControl",
# crbug.com/1167243
"ui.ChromeLogin",
# crbug.com/1115622
"ui.ChromeLoginGAIA",
# crbug.com/1099695
"platform.Drivefs",
# crbug.com/1131496
"apps.LaunchHelpApp.clamshell_oobe_stable",
"apps.LaunchHelpApp.tablet_oobe_stable",
# crbug.com/1148036
"ui.ExistingUserLogin",
"ui.SigninProfileExtension",
# crbug.com/1154794
"policy.DefaultGeolocationSetting",
# crbug.com/1115622
"inputs.VirtualKeyboardOOBE",
# crbug.com/1156006
"filemanager.DragDrop",
# crbug.com/1158051
"policy.AllowDinosaurEasterEgg",
]
# To disable a specific test, add it to the
# tast_disabled_tests_from_chrome_all list in "tast_control.gni" and cite
# a bug.
tast_disabled_tests = tast_disabled_tests_from_chrome_all
}
tast_test("chrome_all_tast_tests_informational") {

@ -8,6 +8,8 @@ per-file BUILD.gn=*
per-file *.xtb=file://tools/translation/TRANSLATION_OWNERS
# Strings
per-file chromeos_strings.grd=*
# Tast test control
per-file tast_control.gni=*
# PST
achuith@chromium.org

43
chromeos/tast_control.gni Normal file

@ -0,0 +1,43 @@
# Copyright 2021 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# WARNING: if you wish to disable a tast test that runs in a ChromeOS SDK
# build, this is the wrong file to edit. You need to mark those tests as
# "informational" in their source .go files.
# To disable a specific test in chrome_all_tast_tests, add it the following
# list and cite a bug.
tast_disabled_tests_from_chrome_all = [
# crbug.com/1162346
"ui.WindowControl",
# crbug.com/1167243
"ui.ChromeLogin",
# crbug.com/1115622
"ui.ChromeLoginGAIA",
# crbug.com/1099695
"platform.Drivefs",
# crbug.com/1131496
"apps.LaunchHelpApp.clamshell_oobe_stable",
"apps.LaunchHelpApp.tablet_oobe_stable",
# crbug.com/1148036
"ui.ExistingUserLogin",
"ui.SigninProfileExtension",
# crbug.com/1154794
"policy.DefaultGeolocationSetting",
# crbug.com/1115622
"inputs.VirtualKeyboardOOBE",
# crbug.com/1156006
"filemanager.DragDrop",
# crbug.com/1158051
"policy.AllowDinosaurEasterEgg",
]

@ -123,7 +123,7 @@ To run a Tast test the same way it's ran on Chrome's builders:
[tests/ui.WindowControl/messages]: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=baefbcfd24c02b3ada4617d259dc6b4220b413b9&as=messages
[system_logs/chrome/chrome_20201029-195153]: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=272166c85f190c336a9885f0267cbdea912e31da&as=chrome_20201029-195153
[Tast attributes]: https://chromium.googlesource.com/chromiumos/platform/tast/+/HEAD/docs/test_attributes.md
[this list]: https://codesearch.chromium.org/chromium/src/chromeos/BUILD.gn?rcl=7b0393a9091fd02edc9ae773739124f7be5a0782&l=242
[this list]: https://codesearch.chromium.org/chromium/src/chromeos/tast_control.gni
[Simple Chrome]: https://chromium.googlesource.com/chromiumos/docs/+/master/simple_chrome_workflow.md
[deploy_chrome.py]: https://chromium.googlesource.com/chromiumos/docs/+/master/simple_chrome_workflow.md#Deploying-Chrome-to-the-device
[here]: https://chromium.googlesource.com/chromiumos/docs/+/master/cros_vm.md#in-simple-chrome