0

[gin] Remove JS feature flags that no longer exist

Bug: 42203505, 42203503, 42204122
Change-Id: If36f6943a6656ecebe0a1685f0cb2fe9ce11811b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6363259
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434247}
This commit is contained in:
Shu-yu Guo
2025-03-18 10:52:26 -07:00
committed by Chromium LUCI CQ
parent baed267377
commit f5899c7e5e
3 changed files with 0 additions and 26 deletions

@ -269,16 +269,6 @@ BASE_FEATURE(kV8IntelJCCErratumMitigation,
// JavaScript language features.
// Enables the iterator helpers proposal.
BASE_FEATURE(kJavaScriptIteratorHelpers,
("kJavaScriptIteratorHelpers"),
kFeatureDefaultStateControlledByV8);
// Enables the Promise.withResolvers proposal.
BASE_FEATURE(kJavaScriptPromiseWithResolvers,
("JavaScriptPromiseWithResolvers"),
kFeatureDefaultStateControlledByV8);
// Enables the RegExp modifiers proposal.
BASE_FEATURE(kJavaScriptRegExpModifiers,
("JavaScriptRegExpModifiers"),
@ -289,11 +279,6 @@ BASE_FEATURE(kJavaScriptImportAttributes,
("JavaScriptImportAttributes"),
kFeatureDefaultStateControlledByV8);
// Enables the set methods proposal.
BASE_FEATURE(kJavaScriptSetMethods,
("JavaScriptSetMethods"),
kFeatureDefaultStateControlledByV8);
// Enables the RegExp duplicate named capture groups proposal.
BASE_FEATURE(kJavaScriptRegExpDuplicateNamedGroups,
("JavaScriptRegExpDuplicateNamedGroups"),

@ -84,11 +84,8 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kV8UseLibmTrigFunctions);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8UseOriginalMessageForStackTrace);
GIN_EXPORT extern const base::FeatureParam<base::TimeDelta>
kV8MemoryReducerStartDelay;
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptIteratorHelpers);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptPromiseWithResolvers);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRegExpModifiers);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptImportAttributes);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptSetMethods);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRegExpDuplicateNamedGroups);
GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptPromiseTry);
GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyDeopt);

@ -513,19 +513,11 @@ void SetFeatureFlags() {
"--no-use-original-message-for-stack-trace");
// JavaScript language features.
SetV8FlagsIfOverridden(features::kJavaScriptIteratorHelpers,
"--harmony-iterator-helpers",
"--no-harmony-iterator-helpers");
SetV8FlagsIfOverridden(features::kJavaScriptPromiseWithResolvers,
"--js-promise-withresolvers",
"--no-js-promise-withresolvers");
SetV8FlagsIfOverridden(features::kJavaScriptRegExpModifiers,
"--js-regexp-modifiers", "--no-js-regexp-modifiers");
SetV8FlagsIfOverridden(features::kJavaScriptImportAttributes,
"--harmony-import-attributes",
"--no-harmony-import-attributes");
SetV8FlagsIfOverridden(features::kJavaScriptSetMethods,
"--harmony-set-methods", "--no-harmony-set-methods");
SetV8FlagsIfOverridden(features::kJavaScriptRegExpDuplicateNamedGroups,
"--js-regexp-duplicate-named-groups",
"--no-js-duplicate-named-groups");