0

Use NOTREACHED_IN_MIGRATION() in chromecast/

This was generated by replacing "  NOTREACHED()" with
"  NOTREACHED_IN_MIGRATION()" and running git cl format.

This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.

Bug: 40580068
Change-Id: I4454fc467ce3c7905837ef442d01642593552e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540127
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300963}
This commit is contained in:
Peter Boström
2024-05-14 23:14:39 +00:00
committed by Chromium LUCI CQ
parent 070ab7809b
commit f66bbc9aa2
46 changed files with 107 additions and 99 deletions

@ -16,7 +16,8 @@ void CastCrashUploaderDefault::UploadDumps(
const std::string& uuid,
const std::string& application_feedback,
const bool can_send_usage_stats) {
NOTREACHED() << "TODO(b/258269114): Move non-android implementations of "
"crash reporting here.";
NOTREACHED_IN_MIGRATION()
<< "TODO(b/258269114): Move non-android implementations of "
"crash reporting here.";
}
} // namespace chromecast

@ -314,7 +314,8 @@ void DeviceCapabilitiesImpl::SetPublicValidatedValue(const std::string& path,
bool is_private = all_data_->dictionary().Find(path) &&
!public_data_->dictionary().Find(path);
if (is_private) {
NOTREACHED() << "Cannot make a private capability '" << path << "' public.";
NOTREACHED_IN_MIGRATION()
<< "Cannot make a private capability '" << path << "' public.";
return;
}
@ -372,7 +373,8 @@ void DeviceCapabilitiesImpl::SetPrivateValidatedValue(const std::string& path,
// We cannot change the privacy of an already existing capability.
const auto* is_public = public_data_->dictionary().Find(path);
if (is_public) {
NOTREACHED() << "Cannot make a public capability '" << path << "' private.";
NOTREACHED_IN_MIGRATION()
<< "Cannot make a public capability '" << path << "' private.";
return;
}

@ -49,7 +49,7 @@ uint64_t HashGUID64(const std::string& guid) {
DCHECK_EQ(hex.size(), 32u);
if (base::HexStringToUInt64(hex.substr(0, 16), &output))
return output;
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 0;
}

@ -249,7 +249,8 @@ class ObservableInternals
}
}
NOTREACHED() << "Tried to remove observer from unknown task runner";
NOTREACHED_IN_MIGRATION()
<< "Tried to remove observer from unknown task runner";
}
private:

@ -188,7 +188,7 @@ void RegisterClosureOnSignal(base::OnceClosure closure) {
for (int sig : kSignalsToRunClosure) {
struct sigaction sa_old;
if (sigaction(sig, &sa_new, &sa_old) == -1) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
} else {
DCHECK_EQ(sa_old.sa_handler, SIG_DFL);
}
@ -214,13 +214,13 @@ void RegisterKillOnAlarm(int timeout_seconds) {
struct sigaction sa_old;
if (sigaction(SIGALRM, &sa_new, &sa_old) == -1) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
} else {
DCHECK_EQ(sa_old.sa_handler, SIG_DFL);
}
if (alarm(timeout_seconds) > 0)
NOTREACHED() << "Previous alarm() was cancelled";
NOTREACHED_IN_MIGRATION() << "Previous alarm() was cancelled";
}
void DeregisterKillOnAlarm() {
@ -235,7 +235,7 @@ void DeregisterKillOnAlarm() {
struct sigaction sa_old;
if (sigaction(SIGALRM, &sa_new, &sa_old) == -1) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
} else {
DCHECK_EQ(sa_old.sa_handler, KillOnAlarm);
}
@ -704,7 +704,7 @@ void CastBrowserMainParts::WillRunMainMessageLoop(
std::unique_ptr<base::RunLoop>& run_loop) {
#if BUILDFLAG(IS_ANDROID)
// Android does not use native main MessageLoop.
NOTREACHED();
NOTREACHED_IN_MIGRATION();
#elif !BUILDFLAG(IS_FUCHSIA)
// Fuchsia doesn't have signals.
RegisterClosureOnSignal(run_loop->QuitClosure());
@ -727,7 +727,7 @@ void CastBrowserMainParts::PostMainMessageLoopRun() {
#if BUILDFLAG(IS_ANDROID)
// Android does not use native main MessageLoop.
NOTREACHED();
NOTREACHED_IN_MIGRATION();
#else
#if defined(USE_AURA)

@ -328,7 +328,7 @@ media::MediaCapsImpl* CastContentBrowserClient::media_caps() {
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_FUCHSIA)
scoped_refptr<device::BluetoothAdapterCast>
CastContentBrowserClient::CreateBluetoothAdapter() {
NOTREACHED() << "Bluetooth Adapter is not supported!";
NOTREACHED_IN_MIGRATION() << "Bluetooth Adapter is not supported!";
return nullptr;
}
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_FUCHSIA)

@ -360,7 +360,7 @@ void CastNetworkContexts::OnProxyConfigChanged(
net::ProxyConfigWithAnnotation::CreateDirect());
break;
case net::ProxyConfigService::CONFIG_PENDING:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
break;
}
}

@ -67,7 +67,7 @@ void CastStabilityMetricsProvider::LogExternalCrash(
else if (crash_type == "uncleanshutdown")
IncrementPrefValue(prefs::kStabilitySystemUncleanShutdownCount);
else
NOTREACHED() << "Unexpected crash type " << crash_type;
NOTREACHED_IN_MIGRATION() << "Unexpected crash type " << crash_type;
// Wake up metrics logs sending if necessary now that new
// log data is available.

@ -35,7 +35,7 @@ struct EnumTraits<chromecast::mojom::VisibilityType,
CASE_TRANSLATE_ENUM(TILE);
CASE_TRANSLATE_ENUM(TRANSIENTLY_HIDDEN);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return chromecast::mojom::VisibilityType::UNKNOWN;
}
@ -51,7 +51,7 @@ struct EnumTraits<chromecast::mojom::VisibilityType,
CASE_TRANSLATE_MOJOM_ENUM(TILE);
CASE_TRANSLATE_MOJOM_ENUM(TRANSIENTLY_HIDDEN);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
*out = chromecast::VisibilityType::UNKNOWN;
return false;
}
@ -73,7 +73,7 @@ struct EnumTraits<chromecast::mojom::VisibilityPriority,
CASE_TRANSLATE_ENUM(HIDDEN);
CASE_TRANSLATE_ENUM(HIDDEN_STICKY);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return chromecast::mojom::VisibilityPriority::DEFAULT;
}
@ -94,7 +94,7 @@ struct EnumTraits<chromecast::mojom::VisibilityPriority,
CASE_TRANSLATE_MOJOM_ENUM(HIDDEN);
CASE_TRANSLATE_MOJOM_ENUM(HIDDEN_STICKY);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
*out = chromecast::VisibilityPriority::DEFAULT;
return false;
}

@ -33,7 +33,7 @@ struct EnumTraits<chromecast::mojom::PageState, chromecast::PageState> {
CASE_TRANSLATE_ENUM(DESTROYED);
CASE_TRANSLATE_ENUM(ERROR);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return chromecast::mojom::PageState::IDLE;
}
@ -49,7 +49,7 @@ struct EnumTraits<chromecast::mojom::PageState, chromecast::PageState> {
CASE_TRANSLATE_MOJOM_ENUM(DESTROYED);
CASE_TRANSLATE_MOJOM_ENUM(ERROR);
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
*out = chromecast::PageState::IDLE;
return false;
}

@ -163,7 +163,7 @@ std::string GrpcResourceDataSource::GetMimeType(const GURL& url) {
return kMimeTypeHtml;
}
NOTREACHED() << "Unknown Mime type of file " << path;
NOTREACHED_IN_MIGRATION() << "Unknown Mime type of file " << path;
return std::string();
}

@ -372,7 +372,7 @@ void RuntimeApplicationServiceImpl::SetTouchInput(
case cast::common::TouchInput::UNDEFINED:
break;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
}
@ -388,7 +388,7 @@ void RuntimeApplicationServiceImpl::SetVisibility(
case cast::common::Visibility::UNDEFINED:
break;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
}
@ -407,7 +407,7 @@ void RuntimeApplicationServiceImpl::SetMediaBlocking(
case cast::common::MediaState::UNDEFINED:
break;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
}

@ -47,7 +47,7 @@ base::FilePath CastResourceDelegate::GetPathForLocalePack(
const std::string& locale) {
base::FilePath product_dir;
if (!base::PathService::Get(base::DIR_ASSETS, &product_dir)) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
return product_dir.
Append(FILE_PATH_LITERAL("chromecast_locales")).

@ -147,7 +147,7 @@ bool MinidumpUploader::DoWork() {
LOG(INFO) << "OptInStats is false, removing crash dump";
ignore_and_erase_dump = true;
} else if (IsDumpObsolete(dump)) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
LOG(INFO) << "DumpInfo belongs to older version, removing crash dump";
ignore_and_erase_dump = true;
}

@ -434,7 +434,7 @@ void GattClientManagerImpl::OnGetServices(
if (pending_connect_requests_.empty() ||
addr != pending_connect_requests_.front().addr ||
!pending_connect_requests_.front().is_connect) {
NOTREACHED() << "Unexpected call to " << __func__;
NOTREACHED_IN_MIGRATION() << "Unexpected call to " << __func__;
return;
}

@ -21,7 +21,7 @@ bool GraphicsPropertiesShlib::IsSupported(
case Resolution::kUHDTV:
return false;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return false;
}
}

@ -108,7 +108,7 @@ bool CaptureServiceReceiver::Socket::SendRequest() {
void CaptureServiceReceiver::Socket::OnSendUnblocked() {
// The request is the first buffer sent, so it should be always accepted by
// the socket.
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void CaptureServiceReceiver::Socket::ReportErrorAndStop() {

@ -79,7 +79,7 @@ audio_service::ContentType ConvertContentType(AudioContentType content_type) {
case AudioContentType::kCommunication:
return audio_service::CONTENT_TYPE_COMMUNICATION;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return audio_service::CONTENT_TYPE_MEDIA;
}
}

@ -111,7 +111,7 @@ class FakeAudioDecoder : public CmaBackend::AudioDecoder {
delegate_->OnDecoderError();
return CmaBackend::BufferStatus::kBufferSuccess;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return CmaBackend::BufferStatus::kBufferFailed;
}
}
@ -177,7 +177,7 @@ class FakeCmaBackend : public CmaBackend {
return audio_decoder_.get();
}
VideoDecoder* CreateVideoDecoder() override {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}

@ -26,40 +26,40 @@ bool ExternalAudioPipelineShlib::IsSupported() {
void ExternalAudioPipelineShlib::AddExternalMediaVolumeChangeRequestObserver(
ExternalMediaVolumeChangeRequestObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::RemoveExternalMediaVolumeChangeRequestObserver(
ExternalMediaVolumeChangeRequestObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::SetExternalMediaVolume(float level) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::SetExternalMediaMuted(bool muted) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::AddExternalLoopbackAudioObserver(
LoopbackAudioObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::RemoveExternalLoopbackAudioObserver(
LoopbackAudioObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::AddExternalMediaMetadataChangeObserver(
ExternalMediaMetadataChangeObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void ExternalAudioPipelineShlib::RemoveExternalMediaMetadataChangeObserver(
ExternalMediaMetadataChangeObserver* observer) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
std::unique_ptr<MixerOutputStream>

@ -59,7 +59,7 @@ AudioChannel ConvertChannelSelection(int channel_selection) {
case 1:
return AudioChannel::kRight;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return AudioChannel::kAll;
}
}

@ -25,7 +25,7 @@ media::SampleFormat ConvertSampleFormat(SampleFormat format) {
case SAMPLE_FORMAT_FLOAT_P:
return kSampleFormatPlanarF32;
default:
NOTREACHED() << "Unknown sample format " << format;
NOTREACHED_IN_MIGRATION() << "Unknown sample format " << format;
}
return kSampleFormatS16;
}
@ -45,7 +45,7 @@ SampleFormat ConvertSampleFormat(media::SampleFormat format) {
case kSampleFormatPlanarF32:
return SAMPLE_FORMAT_FLOAT_P;
default:
NOTREACHED() << "Unhandled sample format " << format;
NOTREACHED_IN_MIGRATION() << "Unhandled sample format " << format;
}
return SAMPLE_FORMAT_INT16_I;
}

@ -59,7 +59,7 @@ chromecast::media::VideoPlane::Transform ConvertTransform(
case gfx::OVERLAY_TRANSFORM_ROTATE_CLOCKWISE_270:
return chromecast::media::VideoPlane::ROTATE_270;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return chromecast::media::VideoPlane::TRANSFORM_NONE;
}
}
@ -81,7 +81,7 @@ chromecast::media::VideoPlane::Transform ConvertTransform(
return chromecast::media::VideoPlane::FLIP_HORIZONTAL;
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return chromecast::media::VideoPlane::TRANSFORM_NONE;
}

@ -88,7 +88,7 @@ int HdcpVersionX10(::media::HdcpVersion hdcp_version) {
return 23;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 0;
}
}

@ -74,8 +74,8 @@ void ToFixedPoint(const float* input,
input, frames, reinterpret_cast<int32_t*>(dest_buffer));
break;
default:
NOTREACHED() << "Unsupported bytes per sample encountered: "
<< bytes_per_sample;
NOTREACHED_IN_MIGRATION()
<< "Unsupported bytes per sample encountered: " << bytes_per_sample;
}
}

@ -67,22 +67,22 @@ MediaPipelineBackend* CastMediaShlib::CreateMediaPipelineBackend(
}
double CastMediaShlib::GetMediaClockRate() {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 0.0;
}
double CastMediaShlib::MediaClockRatePrecision() {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 0.0;
}
void CastMediaShlib::MediaClockRateRange(double* minimum_rate,
double* maximum_rate) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
bool CastMediaShlib::SetMediaClockRate(double new_rate) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return false;
}

@ -88,7 +88,7 @@ void VolumeControlAndroid::SetVolume(VolumeChangeSource source,
AudioContentType type,
float level) {
if (type == AudioContentType::kOther) {
NOTREACHED() << "Can't set volume for content type kOther";
NOTREACHED_IN_MIGRATION() << "Can't set volume for content type kOther";
return;
}
@ -111,7 +111,7 @@ void VolumeControlAndroid::SetMuted(VolumeChangeSource source,
AudioContentType type,
bool muted) {
if (type == AudioContentType::kOther) {
NOTREACHED() << "Can't set mute state for content type kOther";
NOTREACHED_IN_MIGRATION() << "Can't set mute state for content type kOther";
return;
}
@ -123,7 +123,8 @@ void VolumeControlAndroid::SetMuted(VolumeChangeSource source,
void VolumeControlAndroid::SetOutputLimit(AudioContentType type, float limit) {
if (type == AudioContentType::kOther) {
NOTREACHED() << "Can't set output limit for content type kOther";
NOTREACHED_IN_MIGRATION()
<< "Can't set output limit for content type kOther";
return;
}

@ -75,7 +75,7 @@ int ToPlayoutChannel(AudioChannel audio_channel) {
case AudioChannel::kRight:
return 1;
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return kChannelAll;
}

@ -72,11 +72,13 @@ struct Parameters {
std::string ReadInputFile(const Parameters& params) {
if (!base::PathExists(params.input_file_path)) {
NOTREACHED() << "File " << params.input_file_path << " does not exist.";
NOTREACHED_IN_MIGRATION()
<< "File " << params.input_file_path << " does not exist.";
}
std::string wav_data;
if (!base::ReadFileToString(params.input_file_path, &wav_data)) {
NOTREACHED() << "Unable to open wav file, " << params.input_file_path;
NOTREACHED_IN_MIGRATION()
<< "Unable to open wav file, " << params.input_file_path;
}
return wav_data;
}

@ -68,7 +68,7 @@ class VolumeControlInternal {
AudioContentType type,
float level) {
if (type == AudioContentType::kOther) {
NOTREACHED() << "Can't set volume for content type kOther";
NOTREACHED_IN_MIGRATION() << "Can't set volume for content type kOther";
return;
}
@ -87,7 +87,8 @@ class VolumeControlInternal {
AudioContentType type,
bool muted) {
if (type == AudioContentType::kOther) {
NOTREACHED() << "Can't set mute state for content type kOther";
NOTREACHED_IN_MIGRATION()
<< "Can't set mute state for content type kOther";
return;
}

@ -538,7 +538,7 @@ bool MixerInputConnection::HandleAudioData(char* data,
memcpy(dest, data, size);
break;
default:
NOTREACHED() << "Unhandled sample format " << sample_format_;
NOTREACHED_IN_MIGRATION() << "Unhandled sample format " << sample_format_;
}
WritePcm(std::move(buffer));

@ -76,7 +76,7 @@ void MultizoneAudioDecoderProxyImpl::LogicalResume() {
int64_t MultizoneAudioDecoderProxyImpl::GetCurrentPts() const {
CheckCalledOnCorrectThread();
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 0;
}
@ -120,7 +120,7 @@ void MultizoneAudioDecoderProxyImpl::GetStatistics(Statistics* statistics) {
void MultizoneAudioDecoderProxyImpl::OnError() {
CheckCalledOnCorrectThread();
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
void MultizoneAudioDecoderProxyImpl::OnPipelineStateChange(

@ -34,7 +34,7 @@ CmaProxyHandler::PipelineState ToClientTypes(
PIPELINE_STATE_PAUSED:
return CmaProxyHandler::PipelineState::kPaused;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return CmaProxyHandler::PipelineState::kUninitialized;
}
}
@ -67,7 +67,7 @@ cast::media::AudioConfiguration_AudioCodec ToGrpcTypes(AudioCodec codec) {
return cast::media::
AudioConfiguration_AudioCodec_AUDIO_CODEC_MPEG_H_AUDIO;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return cast::media::AudioConfiguration_AudioCodec_AUDIO_CODEC_UNKNOWN;
}
}
@ -93,7 +93,7 @@ cast::media::AudioConfiguration_ChannelLayout ToGrpcTypes(
return cast::media::
AudioConfiguration_ChannelLayout_CHANNEL_LAYOUT_DISCRETE;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return cast::media::
AudioConfiguration_ChannelLayout_CHANNEL_LAYOUT_UNSUPPORTED;
}
@ -124,7 +124,7 @@ cast::media::AudioConfiguration_SampleFormat ToGrpcTypes(
case kSampleFormatS24:
return cast::media::AudioConfiguration_SampleFormat_SAMPLE_FORMAT_S24;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return cast::media::AudioConfiguration_SampleFormat_SAMPLE_FORMAT_UNKNOWN;
}
}
@ -341,7 +341,7 @@ void ProxyCallTranslator::HandlePushBufferResponse(
void ProxyCallTranslator::HandleGetMediaTimeResponse(
std::optional<MediaTime> time,
CastRuntimeAudioChannelBroker::StatusCode status) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
bool ProxyCallTranslator::HandleError(

@ -286,7 +286,7 @@ class VolumeControlInternal : public SystemVolumeControl::Delegate {
DCHECK(thread_.task_runner()->BelongsToCurrentThread());
DCHECK_NE(AudioContentType::kOther, type);
#if BUILDFLAG(SYSTEM_OWNS_VOLUME)
NOTREACHED();
NOTREACHED_IN_MIGRATION();
#else
volume_multipliers_[type] = multiplier;
float scale =

@ -103,9 +103,9 @@ static const char* StateToString(BufferingState::State state) {
case BufferingState::kEosReached:
return "kEosReached";
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return "";
}

@ -83,7 +83,7 @@ SampleFormat ToSampleFormat(const ::media::SampleFormat sample_format) {
case ::media::kSampleFormatPlanarS32:
return kSampleFormatPlanarS32;
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return kUnknownSampleFormat;
}
@ -110,7 +110,7 @@ SampleFormat ToSampleFormat(const ::media::SampleFormat sample_format) {
case kSampleFormatPlanarS32:
return ::media::kSampleFormatPlanarS32;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return ::media::kUnknownSampleFormat;
}
}
@ -160,7 +160,7 @@ EncryptionScheme ToEncryptionScheme(::media::EncryptionScheme scheme) {
case ::media::EncryptionScheme::kCbcs:
return EncryptionScheme::kAesCbc;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return EncryptionScheme::kUnencrypted;
}
}
@ -174,7 +174,7 @@ EncryptionScheme ToEncryptionScheme(::media::EncryptionScheme scheme) {
case EncryptionScheme::kAesCbc:
return ::media::EncryptionScheme::kCbcs;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return ::media::EncryptionScheme::kUnencrypted;
}
}
@ -200,7 +200,7 @@ ChannelLayout DecoderConfigAdapter::ToChannelLayout(
return ChannelLayout::DISCRETE;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return ChannelLayout::UNSUPPORTED;
}
}
@ -223,7 +223,7 @@ ChannelLayout DecoderConfigAdapter::ToChannelLayout(
return ::media::ChannelLayout::CHANNEL_LAYOUT_DISCRETE;
default:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return ::media::ChannelLayout::CHANNEL_LAYOUT_UNSUPPORTED;
}
}

@ -46,7 +46,7 @@ void DemuxerStreamForTest::Read(uint32_t count, ReadCB read_cb) {
}
::media::AudioDecoderConfig DemuxerStreamForTest::audio_decoder_config() {
NOTREACHED() << "DemuxerStreamForTest is a video DemuxerStream";
NOTREACHED_IN_MIGRATION() << "DemuxerStreamForTest is a video DemuxerStream";
return ::media::AudioDecoderConfig();
}

@ -283,7 +283,7 @@ class CastAudioDecoderImpl : public CastAudioDecoder {
ptr += num_frames;
}
} else {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
result->set_duration(
@ -343,7 +343,7 @@ int CastAudioDecoder::OutputFormatSizeInBytes(
case CastAudioDecoder::OutputFormat::kOutputPlanarFloat:
return 4;
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return 1;
}

@ -198,7 +198,7 @@ void AudioDecoderSoftwareWrapper::OnKeyStatusChanged(const std::string& key_id,
}
void AudioDecoderSoftwareWrapper::OnVideoResolutionChanged(const Size& size) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
} // namespace media

@ -38,7 +38,7 @@ std::ostream& operator<<(std::ostream& stream,
case ::chromecast::media::kCodecMpegHAudio:
return stream << "MPEG-H Audio";
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return stream << "UNKNOWN";
}
@ -66,6 +66,6 @@ std::ostream& operator<<(std::ostream& stream,
case ::chromecast::media::kSampleFormatPlanarU8:
return stream << "planar unsigned 8-bit int";
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return stream << "UNKNOWN";
}

@ -64,12 +64,12 @@ class RevokedMediaPipelineBackendWrapper : public DecoderCreatorCmaBackend {
// CmaBackend implementation:
CmaBackend::AudioDecoder* CreateAudioDecoder() override {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}
CmaBackend::VideoDecoder* CreateVideoDecoder() override {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}
@ -182,13 +182,13 @@ ActiveMediaPipelineBackendWrapper::~ActiveMediaPipelineBackendWrapper() {
CmaBackend::AudioDecoder*
ActiveMediaPipelineBackendWrapper::CreateAudioDecoder() {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}
CmaBackend::VideoDecoder*
ActiveMediaPipelineBackendWrapper::CreateVideoDecoder() {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}

@ -62,7 +62,7 @@ std::unique_ptr<::media::Renderer> CastMojoMediaClient::CreateRenderer(
// TODO(guohuideng): CastMojoMediaClient is used only when build flag
// ENABLE_CAST_RENDERER is set. We can get rid of a number of related macros
// and the [[maybe_unused]].
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}

@ -179,7 +179,7 @@ bool CastMetricsServiceClient::GetBrand(std::string* brand_code) {
case CastSysInfo::BUILD_PRODUCTION:
return ::metrics::SystemProfileProto::CHANNEL_STABLE;
}
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return ::metrics::SystemProfileProto::CHANNEL_UNKNOWN;
#else
// Use the system (or signed) release channel here to avoid the noise in the

@ -169,7 +169,7 @@ class DummyEventBuilder : public CastEventBuilder {
}
::metrics::CastLogsProto_CastEventProto* Build() override {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}
};

@ -27,7 +27,7 @@ void FakeSharedURLLoaderFactory::CreateLoaderAndStart(
std::unique_ptr<network::PendingSharedURLLoaderFactory>
FakeSharedURLLoaderFactory::Clone() {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return nullptr;
}

@ -105,7 +105,7 @@ void ScreenPowerControllerAura::TriggerPendingTask() {
switch (pending_task_) {
case PendingTask::kOn:
if (screen_on_) {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
} else if (screen_power_on_) {
SetScreenBrightnessOn(true);
pending_task_ = PendingTask::kNone;
@ -130,11 +130,11 @@ void ScreenPowerControllerAura::TriggerPendingTask() {
} else if (screen_power_on_) {
SetScreenPowerOff();
} else {
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
return;
case PendingTask::kNone:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
}
}
@ -182,7 +182,7 @@ void ScreenPowerControllerAura::OnScreenPoweredOn(bool succeeded) {
TriggerPendingTask();
return;
case PendingTask::kNone:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return;
}
}
@ -204,7 +204,7 @@ void ScreenPowerControllerAura::OnScreenPoweredOff(bool succeeded) {
pending_task_ = PendingTask::kNone;
return;
case PendingTask::kNone:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return;
}
}
@ -219,7 +219,7 @@ void ScreenPowerControllerAura::OnDisplayOnTimeoutCompleted() {
TriggerPendingTask();
return;
case PendingTask::kNone:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return;
}
}
@ -238,7 +238,7 @@ void ScreenPowerControllerAura::OnDisplayOffTimeoutCompleted() {
weak_factory_.GetWeakPtr()));
return;
case PendingTask::kNone:
NOTREACHED();
NOTREACHED_IN_MIGRATION();
return;
}
}