0

Revert "Create a feature flag for PDF portfolio"

This reverts commit 747748b355.

Reason for revert: bot failure on:

https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/6352/test-results?sortby=&groupby=

TL;DR:

Policy id 1128 was found in src/tools/metrics/histograms/enums.xml, but no policy with this id exists in policy_templates.json. To regenerate the policy part of enums.xml, run:
python tools/metrics/histograms/update_policies.py

Original change's description:
> Create a feature flag for PDF portfolio
>
> Creates a feature flag `pdf-portfolio` which will be an indicator that
> portfolio feature is enabled in the PDF viewer. Currently this flag is
> a dummy flag that has not been linked to the actual feature yet.
>
> Bug: 177188
> Change-Id: Ief14cbdad785bad405bf402d3cb57b22314a07c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651500
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Nigi <nigi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1164297}

Bug: 177188
Change-Id: I5d70af7a47ad3502bdc2820c73a46b6a4a647bd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4657917
Auto-Submit: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Frank Liberato <liberato@google.com>
Cr-Commit-Position: refs/heads/main@{#1164394}
This commit is contained in:
Frank Liberato
2023-06-29 22:46:03 +00:00
committed by Chromium LUCI CQ
parent a646c8a4d5
commit f722ccb9ce
7 changed files with 0 additions and 21 deletions

@ -6744,10 +6744,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAccessiblePDFFormDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kAccessiblePDFForm)},
{"pdf-portfolio", flag_descriptions::kPdfPortfolioName,
flag_descriptions::kPdfPortfolioDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfPortfolio)},
{"pdf-use-skia-renderer", flag_descriptions::kPdfUseSkiaRendererName,
flag_descriptions::kPdfUseSkiaRendererDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfUseSkiaRenderer)},

@ -6303,11 +6303,6 @@
"owners": [ "rhalavati", "//ui/accessibility/OWNERS" ],
"expiry_milestone": 120
},
{
"name": "pdf-portfolio",
"owners": [ "nigi", "//pdf/OWNERS" ],
"expiry_milestone": 130
},
{
"name": "pdf-use-skia-renderer",
"owners": [ "nigi", "//pdf/OWNERS" ],

@ -40,9 +40,6 @@ const char kAccessiblePDFFormName[] = "Accessible PDF Forms";
const char kAccessiblePDFFormDescription[] =
"Enables accessibility support for PDF forms.";
const char kPdfPortfolioName[] = "PDF portfolio";
const char kPdfPortfolioDescription[] = "Enable PDF portfolio feature.";
const char kPdfUseSkiaRendererName[] =
"Use Skia Renderer. This flag will have no effect if the renderer choice "
"is controlled by an enterprise policy.";

@ -55,9 +55,6 @@ extern const char kAcceleratedVideoEncodeDescription[];
extern const char kAccessiblePDFFormName[];
extern const char kAccessiblePDFFormDescription[];
extern const char kPdfPortfolioName[];
extern const char kPdfPortfolioDescription[];
extern const char kPdfUseSkiaRendererName[];
extern const char kPdfUseSkiaRendererDescription[];
#endif

@ -23,8 +23,6 @@ BASE_FEATURE(kPdfPartialLoading,
"PdfPartialLoading",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kPdfPortfolio, "PdfPortfolio", base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kPdfUseSkiaRenderer,
"PdfUseSkiaRenderer",
base::FEATURE_DISABLED_BY_DEFAULT);

@ -16,7 +16,6 @@ namespace features {
BASE_DECLARE_FEATURE(kAccessiblePDFForm);
BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
BASE_DECLARE_FEATURE(kPdfPartialLoading);
BASE_DECLARE_FEATURE(kPdfPortfolio);
BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);
BASE_DECLARE_FEATURE(kPdfXfaSupport);

@ -33825,7 +33825,6 @@ Called by update_document_policy_enum.py.-->
<int value="1125" label="ArcVmDataMigrationStrategy"/>
<int value="1126" label="AccessibilityPerformanceFilteringAllowed"/>
<int value="1127" label="RemoteAccessHostAllowEnterpriseFileTransfer"/>
<int value="1128" label="PdfPortfolioEnabled"/>
</enum>
<enum name="EnterprisePoliciesSources">
@ -62874,7 +62873,6 @@ from previous Chrome versions.
<int value="-526236814" label="WebAssemblyTiering:enabled"/>
<int value="-523155003" label="PhoneHubCameraRoll:disabled"/>
<int value="-523030434" label="EnableBackgroundBlur:enabled"/>
<int value="-522137246" label="PdfPortfolio:disabled"/>
<int value="-521251533" label="PrivacyGuideAndroid:enabled"/>
<int value="-520221221" label="UserDataSnapshot:enabled"/>
<int value="-520004021" label="WebXRHitTest:disabled"/>
@ -64334,7 +64332,6 @@ from previous Chrome versions.
label="enable-manual-fallback-for-password-saving:disabled"/>
<int value="238376121" label="AndroidImprovedBookmarks:disabled"/>
<int value="238738258" label="AndroidAppIntegration:enabled"/>
<int value="238843287" label="PdfPortfolio:enabled"/>
<int value="239330938" label="LauncherAppSort:enabled"/>
<int value="240856309" label="MimeHandlerViewInCrossProcessFrame:enabled"/>
<int value="241187301" label="BrowserTouchBar:disabled"/>