chromium/src
0
Fork 0
Code Activity

sunfish: update strings

Browse Source 
Bug: b:388898754, b:361850292
Change-Id: I3046ac946eb3bae9cd625abef994fbdf9d46d29a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6364674
Auto-Submit: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Elijah Hewer <hewer@chromium.org>
Commit-Queue: Elijah Hewer <hewer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436518}
This commit is contained in:
Xiaoqian Dai
2025-03-22 18:11:13 -07:00
committed by Chromium LUCI CQ
parent f490f64978
commit f748e8c7f2
9 changed files with 24 additions and 8 deletions

4
ash/app_list/views/search_box_view.cc

@ -567,8 +567,8 @@ SearchBoxView::SearchBoxView(SearchBoxViewDelegate* delegate,
views::ImageButton* sunfish_button = CreateSunfishButton(base::BindRepeating(
&SearchBoxView::SunfishButtonPressed, base::Unretained(this)));
sunfish_button->SetFlipCanvasOnPaintForRTLUI(false);
// TODO(http://b/361850292): Upload label for translation.
std::u16string sunfish_button_label(u"Select to search");
std::u16string sunfish_button_label(
l10n_util::GetStringUTF16(IDS_ASH_SUNFISH_SEARCH_BOX_BUTTON));
sunfish_button->GetViewAccessibility().SetName(sunfish_button_label);
sunfish_button->SetTooltipText(sunfish_button_label);
// Update the visibility based on the search box model.

12
ash/ash_strings.grd

@ -6869,6 +6869,9 @@ Here are some things you can try to get started.
<message name="IDS_ASH_SCREEN_CAPTURE_SUNFISH_ACTION_BUTTON_WINDOW_TITLE" desc="The title of the window that contains available action buttons after the user has selected a region on their screen of interest. Example actions include copy text or create a Google Doc.">
Actions
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_SUNFISH_SEARCH_BUTTON_TITLE" desc="The tile of the button that shows after the user selectes a region on their screen. ">
Search with Google
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_SUNFISH_CLOSE_BUTTON_ACCESSIBLE_NAME" desc="The accessible name of the close button for a screen capture mode, 'search my screen', where users can select a region on their screen to search.">
Close search my screen
</message>
@ -6884,6 +6887,15 @@ Here are some things you can try to get started.
<message name="IDS_ASH_SCREEN_CAPTURE_ACTION_ATTEMPTED_OFFLINE_ERROR" desc="The error message shown if the user is offline while attempting an action that requires an internet connection.">
Check your internet and try again
</message>
<message name="IDS_ASH_SUNFISH_SEARCH_DIALOG_CLOSE" desc="The accessible name of the close button of the search model dialog for the Sunfish feature. ">
Close Panel
</message>
<message name="IDS_ASH_SUNFISH_SEARCH_BOX_BUTTON" desc="The accessible name and tooltip of the search button for the Sunfish feature. ">
Search my screen with Google Lens
</message>
<message name="IDS_ASH_SUNFISH_EDUCATE_TOAST_MESSAGE" desc="The message shown in a toast window to educate the user about the Sunfish feature.">
Select anything on your screen to search, copy text, and more
</message>
<!-- Scanner -->
<message name="IDS_ASH_SCANNER_DISCLAIMER_TITLE" desc="Text shown as the title of the suggested actions when searching your screen disclaimer view.">

1
ash/ash_strings_grd/IDS_ASH_SCREEN_CAPTURE_SUNFISH_SEARCH_BUTTON_TITLE.png.sha1 Normal file

@ -0,0 +1 @@
1d1cb160356e5edff70a691c11e85493f82986be

1
ash/ash_strings_grd/IDS_ASH_SUNFISH_EDUCATE_TOAST_MESSAGE.png.sha1 Normal file

@ -0,0 +1 @@
2dc5b5b3d34756c046178073fb956c948e597257

1
ash/ash_strings_grd/IDS_ASH_SUNFISH_SEARCH_BOX_BUTTON.png.sha1 Normal file

@ -0,0 +1 @@
2ec7f9757622ae92af3c8d4107ea58fd053b2bbd

1
ash/ash_strings_grd/IDS_ASH_SUNFISH_SEARCH_DIALOG_CLOSE.png.sha1 Normal file

@ -0,0 +1 @@
383ea06e6e0a47bbfcbc0b2520897ed82dd2c418

6
ash/capture_mode/capture_mode_session.cc

@ -3749,12 +3749,12 @@ CaptureModeSession::ShowDefaultActionButtonsOrPerformSearch() {
IDS_ASH_SCREEN_CAPTURE_MORE_ACTIONS_UNAVAILABLE_OFFLINE_ERROR));
} else {
RecordSearchButtonShown();
// TODO(crbug.com/388898754): Finalize and translate the search button
// text.
capture_mode_util::AddActionButton(
base::BindRepeating(&CaptureModeSession::OnSearchButtonPressed,
weak_ptr_factory_.GetWeakPtr()),
u"Search with Lens", &kLensIcon,
l10n_util::GetStringUTF16(
IDS_ASH_SCREEN_CAPTURE_SUNFISH_SEARCH_BUTTON_TITLE),
&kLensIcon,
ActionButtonRank(ActionButtonType::kSunfish, /*weight=*/1),
ActionButtonViewID::kSearchButton);
}

3
ash/capture_mode/capture_mode_toast_controller.cc

@ -34,11 +34,10 @@ constexpr base::TimeDelta kDelayToDismissToast = base::Seconds(6);
std::u16string GetCaptureToastTextOnToastType(
CaptureToastType capture_toast_type) {
// TODO: crbug.com/388898754 - Upload string for translation.
return capture_toast_type == CaptureToastType::kCameraPreview
? l10n_util::GetStringUTF16(
IDS_ASH_SCREEN_CAPTURE_SURFACE_TOO_SMALL_USER_NUDGE)
: u"Select anything on your screen to search, copy text, and more";
: l10n_util::GetStringUTF16(IDS_ASH_SUNFISH_EDUCATE_TOAST_MESSAGE);
}
// Returns the init params that will be used for the toast widget.

3
ash/capture_mode/search_results_panel.cc

@ -203,7 +203,8 @@ SearchResultsPanel::SearchResultsPanel() {
IconButton::Builder()
.SetType(IconButton::Type::kSmallFloating)
.SetVectorIcon(&kMediumOrLargeCloseButtonIcon)
.SetAccessibleName(u"Close Panel")
.SetAccessibleName(l10n_util::GetStringUTF16(
IDS_ASH_SUNFISH_SEARCH_DIALOG_CLOSE))
.Build())
.CopyAddressTo(&close_button_)
.SetCallback(base::BindRepeating(