Enable the consistently passing tests in AdAuctionServiceImpl
This change is part of the effort to re-enable consistently passing tests across the entire chromium. If the tests are reasonable, please LGTM and I will proceed to submit the change. If the tests are unreasonable, please let me know and I will remove them. I do not inspect each individual test case, the idea is to run the disabled tests on reviver builders https://ci.chromium.org/ui/p/chromium/g/reviver/builders and use the aggregated results to decide if a previously disabled test is now consistently passing. To inspect the result of the runs, you may choose a platform you are interested, e.g. chromium/reviver/lacros-coordinator. [link: https://ci.chromium.org/p/chromium/builders/reviver/lacros-coordinator] In the baseline builder / buildbucket.schedule step, e.g. chromium/ci/linux-lacros-builder-rel - buildbucket.schedule, there will be a luci run link. [ex: https://ci.chromium.org/ui/p/chromium/builders/reviver/runner/b8776966777608450081/overview] Meanwhile, the aggregated results are used to create the change. And the following list shows how many times the changed tests were *consistently* passing on the relevant builders. content/test:content_unittests/AdAuctionServiceImplPrivateAggregationDisabledTest.PrivateAggregationNotExposed 127 fuchsia-fyi-arm64-dbg 150 fuchsia-fyi-x64-dbg 192 fuchsia-x64-rel 110 linux-lacros-tester-rel content/test:content_unittests/AdAuctionServiceImplPrivateAggregationDisabledTest.PrivateAggregationUseCounterNotLogged 127 fuchsia-fyi-arm64-dbg 150 fuchsia-fyi-x64-dbg 192 fuchsia-x64-rel 110 linux-lacros-tester-rel content/test:content_unittests/AdAuctionServiceImplPrivateAggregationEnabledTest.PrivateAggregationUseCountersNotLoggedOnFailedInvocation 127 fuchsia-fyi-arm64-dbg 150 fuchsia-fyi-x64-dbg 192 fuchsia-x64-rel 110 linux-lacros-tester-rel content/test:content_unittests/AdAuctionServiceImplSharedStorageDisabledTest.SharedStorageNotDefined 127 fuchsia-fyi-arm64-dbg 150 fuchsia-fyi-x64-dbg 192 fuchsia-x64-rel 110 linux-lacros-tester-rel data version: 2023-06-28 16:45:51 Bug: 1380293 Fixed: 1408576 Change-Id: I28fe9f9dbdf4b64685e459d3f18398694b222cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4655389 Commit-Queue: Zijie He <zijiehe@google.com> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1164812}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
f374dd0118
commit
f994e9a823
@ -6991,9 +6991,7 @@ class AdAuctionServiceImplSharedStorageDisabledTest
|
||||
base::test::ScopedFeatureList feature_list_;
|
||||
};
|
||||
|
||||
// TODO(crbug.com/1408576): Flaky.
|
||||
TEST_F(AdAuctionServiceImplSharedStorageDisabledTest,
|
||||
DISABLED_SharedStorageNotDefined) {
|
||||
TEST_F(AdAuctionServiceImplSharedStorageDisabledTest, SharedStorageNotDefined) {
|
||||
constexpr char kBiddingScript[] = R"(
|
||||
function generateBid(
|
||||
interestGroup, auctionSignals, perBuyerSignals, trustedBiddingSignals,
|
||||
@ -7427,9 +7425,8 @@ function scoreAd(
|
||||
}
|
||||
|
||||
// TODO(crbug.com/1356654): Update when use counter coverage is improved.
|
||||
// TODO(crbug.com/1408576): Flaky.
|
||||
TEST_F(AdAuctionServiceImplPrivateAggregationEnabledTest,
|
||||
DISABLED_PrivateAggregationUseCountersNotLoggedOnFailedInvocation) {
|
||||
PrivateAggregationUseCountersNotLoggedOnFailedInvocation) {
|
||||
constexpr char kBiddingScript[] = R"(
|
||||
function generateBid(
|
||||
interestGroup, auctionSignals, perBuyerSignals, trustedBiddingSignals,
|
||||
@ -7566,9 +7563,7 @@ class AdAuctionServiceImplPrivateAggregationDisabledTest
|
||||
base::test::ScopedFeatureList feature_list_;
|
||||
};
|
||||
|
||||
// TODO(crbug.com/1408576): Flaky.
|
||||
TEST_F(AdAuctionServiceImplPrivateAggregationDisabledTest,
|
||||
DISABLED_PrivateAggregationNotExposed) {
|
||||
TEST_F(AdAuctionServiceImplPrivateAggregationDisabledTest, PrivateAggregationNotExposed) {
|
||||
constexpr char kBiddingScript[] = R"(
|
||||
function generateBid(
|
||||
interestGroup, auctionSignals, perBuyerSignals, trustedBiddingSignals,
|
||||
@ -7609,9 +7604,8 @@ function scoreAd(
|
||||
EXPECT_EQ(auction_result, absl::nullopt);
|
||||
}
|
||||
|
||||
// TODO(crbug.com/1408576): Flaky.
|
||||
TEST_F(AdAuctionServiceImplPrivateAggregationDisabledTest,
|
||||
DISABLED_PrivateAggregationUseCounterNotLogged) {
|
||||
PrivateAggregationUseCounterNotLogged) {
|
||||
constexpr char kBiddingScript[] = R"(
|
||||
function generateBid(
|
||||
interestGroup, auctionSignals, perBuyerSignals, trustedBiddingSignals,
|
||||
|
Reference in New Issue
Block a user