chromium/src
0
Fork 0
Code Activity

Stop mentioning wired headphone in Sidetone Bubble

Browse Source 
CL:5856520 makes sidetone no longer limited to wired headphone.
We need to modify the success strings that mention wired headphone,
and also rephrase sidetone with mic test.

Bug: 366107569
Change-Id: If30f94c8840c4b031f0c54ab48c803c1f01f953e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856342
Reviewed-by: Li-Yu Yu <aaronyu@google.com>
Reviewed-by: Ching Yun Chang <whalechang@google.com>
Commit-Queue: Norman Bintang <normanbt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354954}
This commit is contained in:
Norman Bintang
2024-09-13 02:27:04 +00:00
committed by Chromium LUCI CQ
parent b6f5203a46
commit fb4ea2f6c2
5 changed files with 8 additions and 8 deletions

8
ash/ash_strings.grd

@ -1827,7 +1827,7 @@ You can also use the keyboard shortcut. First, highlight text, then press <ph na
Video call controls
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_BUBBLE_SIDETONE_TOGGLE_TOOLTIP" desc="Tooltip shown for a toggle to enable or disable sidetone.">
Toggle sidetone
Toggle mic test
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_PREFERENCE_STATE_ACCESSIBLE_NAME" desc="Text for screen readers describing the state of a Studio Look preference. The commas are significant as they will introduce a pause in the spoken text.">
<ph name="PREFERENCE_TITLE">$1<ex>Studio Look preference</ex></ph>, <ph name="EFFECT_NAME">$2<ex>Face retouch</ex></ph>, toggle button, <ph name="STATE">$3<ex>on</ex></ph>
@ -1851,10 +1851,10 @@ You can also use the keyboard shortcut. First, highlight text, then press <ph na
Privacy settings
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_SIDETONE_ENABLED_BUBBLE_TITLE" desc="The title of the bubble when sidetone is enabled.">
Listen to your mic sound
Test your mic sound
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_SIDETONE_ENABLED_BUBBLE_BODY" desc="The body of the bubble when sidetone is enabled.">
You can monitor your microphone sound from wired headphones. Close panel to stop.
You can test your microphone sound. Close panel to stop.
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_SIDETONE_NOT_SUPPORTED_BUBBLE_TITLE" desc="The title of the bubble when the active device doesn't support sidetone.">
Connect wired headphone
@ -1863,7 +1863,7 @@ You can also use the keyboard shortcut. First, highlight text, then press <ph na
To avoid echo, you can listen to your mic only with wired headphone.
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_SIDETONE_BUBBLE_ANNOUNCEMENT" desc="Accessibility announcement that notifies whether sidetone is supported after user presses the toggle.">
<ph name="TITLE">$1<ex>Listen to your mic sound</ex></ph>. <ph name="DESCRIPTION">$2<ex>You can monitor your microphone sound from wired headphones. Close panel to stop.</ex></ph>
<ph name="TITLE">$1<ex>Test your mic sound</ex></ph>. <ph name="DESCRIPTION">$2<ex>You can test your microphone sound. Close panel to stop.</ex></ph>
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_SIDETONE_BUBBLE_DISMISS_BUTTON" desc="The dismiss button of the bubble when sidetone is enabled.">
Dismiss

2
ash/ash_strings_grd/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_SIDETONE_TOGGLE_TOOLTIP.png.sha1

@ -1 +1 @@
49c4ca21e77d6b6f229c4bfb0318b82817c99adb
8ed3e3c4995d5803c96807695595314d4432d571

2
ash/ash_strings_grd/IDS_ASH_VIDEO_CONFERENCE_SIDETONE_BUBBLE_ANNOUNCEMENT.png.sha1

@ -1 +1 @@
393ccca1aae754ebdec3f0c5a067a3a7e7c943a7
9967243859d4a37c214f407821cd7a13eda06d46

2
ash/ash_strings_grd/IDS_ASH_VIDEO_CONFERENCE_SIDETONE_ENABLED_BUBBLE_BODY.png.sha1

@ -1 +1 @@
a040ff7beb5002a0c05ecf6c97762f9fe860cd82
b982f41bb5a3728c3bb10db3303c842c79dde072

2
ash/ash_strings_grd/IDS_ASH_VIDEO_CONFERENCE_SIDETONE_ENABLED_BUBBLE_TITLE.png.sha1

@ -1 +1 @@
e4bccb33befd6b01c385072702fdf30af77d7f30
d8022587c5d3fb1828f01079a5b17355410ae499