0

Update histogram summaries for Quota storage metrics

As part of the ongoing migration to partition the Quota storage APIs on
StorageKey instead of Origin, the semantics of some of the existing UMA
metrics now refer to StorageKeys instead of Origins.  However, in order
to preserve the historical data for these metrics, we won't be changing
the name, but rather just change the descriptive summary in the
histogram and in the code comments.

Bug: 1215208
Change-Id: I8af5e2236bf98eb5bac7b1db95b4148a1a0a1fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973064
Commit-Queue: Ali Beyad <abeyad@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894146}
This commit is contained in:
Ali Beyad
2021-06-21 04:47:49 +00:00
committed by Chromium LUCI CQ
parent 4af8ba2a07
commit fc8be8ed20
2 changed files with 24 additions and 9 deletions
storage/browser/quota
tools/metrics/histograms/histograms_xml/quota

@ -78,7 +78,10 @@ void QuotaTemporaryStorageEvictor::ReportPerRoundHistogram() {
UMA_HISTOGRAM_MBYTES("Quota.EvictedBytesPerRound",
round_statistics_.usage_on_beginning_of_round -
round_statistics_.usage_on_end_of_round);
// TODO(crbug.com/1215208): Change to NumberOfEvictedStorageKeysPerRound.
// Even though the metric now captures the number of evicted storage keys
// (instead of origins), we keep the metric identifier
// NumberOfEvictedOriginsPerRound so we don't lose historical data.
UMA_HISTOGRAM_COUNTS_1M("Quota.NumberOfEvictedOriginsPerRound",
round_statistics_.num_evicted_storage_keys_in_round);
}
@ -90,8 +93,8 @@ void QuotaTemporaryStorageEvictor::ReportPerHourHistogram() {
previous_statistics_ = statistics_;
// Even though the metric now captures the number of evicted storage keys
// (instead of origins), we keep the metric identifier
// Quota.EvictedOriginsPerHour so we don't lose historical data.
// (instead of origins), we keep the metric identifier EvictedOriginsPerHour
// so we don't lose historical data.
UMA_HISTOGRAM_COUNTS_1M("Quota.EvictedOriginsPerHour",
stats_in_hour.num_evicted_storage_keys);
UMA_HISTOGRAM_COUNTS_1M("Quota.EvictionRoundsPerHour",

@ -98,8 +98,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<owner>jarrydg@chromium.org</owner>
<owner>chrome-owp-storage@google.com</owner>
<summary>
The number of times the evicted origin was accessed. Logged when the origin
is evicted.
The number of times the evicted storage key was accessed. Logged when the
storage key is evicted. Prior to M93, evictions were based on the Origin,
not StorageKey, but we chose not to rename the metric in order to maintain
historical data.
</summary>
</histogram>
@ -108,8 +110,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<owner>jarrydg@chromium.org</owner>
<owner>chrome-owp-storage@google.com</owner>
<summary>
The number of days since the evicted origin was last accessed. Logged when
the origin is evicted.
The number of days since the evicted storage key was last accessed. Logged
when the storage key is evicted. Prior to M93, evictions were based on the
Origin, not StorageKey, but we chose not to rename the metric in order to
maintain historical data.
</summary>
</histogram>
@ -117,7 +121,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
expires_after="2021-09-05">
<owner>jarrydg@chromium.org</owner>
<owner>chrome-owp-storage@google.com</owner>
<summary>Number of evicted origins in an hour.</summary>
<summary>
Number of evicted storage keys in an hour. Prior to M93, evictions were
based on the Origin, not StorageKey, but we chose not to rename the metric
in order to maintain historical data.
</summary>
</histogram>
<histogram name="Quota.EvictionRoundsPerHour" units="units"
@ -152,7 +160,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
expires_after="2022-05-18">
<owner>jarrydg@chromium.org</owner>
<owner>chrome-owp-storage@google.com</owner>
<summary>Number of evicted origins per round.</summary>
<summary>
Number of evicted storage keys per round. Prior to M93, evictions were based
on the Origin, not StorageKey, but we chose not to rename the metric in
order to maintain historical data.
</summary>
</histogram>
<histogram name="Quota.OSAccomodationDelta" units="MB" expires_after="M85">