0

Orderfile: Bump allowed misordered symbols

Allow 80 misordered symbols, instead of 20.

The current pipeline reports about 60 misordered symbols, which
increased recently.  According to http://crbug.com/1117184#c14 it did
not make the orderfile quality noticeably worse.

Also print more examples of symbols.

Bug: 1117184, 1126878
Change-Id: Ib5e1c3c8ad0ca70a16b8f6ffec21773617e594cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403365
Commit-Queue: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805792}
This commit is contained in:
Egor Pasko
2020-09-10 16:41:14 +00:00
committed by Commit Bot
parent 2d8d3cf52e
commit fcc1378db5

@ -46,7 +46,7 @@ def _VerifySymbolOrder(orderfile_symbols, symbol_infos, threshold):
logging.warning('Missing symbols in verification: %d', missing_count)
if misorder_count:
logging.warning('%d misordered symbols:\n %s', misorder_count,
'\n '.join(str(x) for x in misordered_syms[:10]))
'\n '.join(str(x) for x in misordered_syms[:threshold]))
if misorder_count > threshold:
logging.error('%d misordered symbols over threshold %d, failing',
misorder_count, threshold)
@ -60,8 +60,11 @@ def main():
parser.add_option('--target-arch', action='store', dest='arch', default='arm',
choices=['arm', 'arm64', 'x86', 'x86_64', 'x64', 'mips'],
help='The target architecture for the binary.')
parser.add_option('--threshold', action='store', dest='threshold',
default=20, type=int,
parser.add_option('--threshold',
action='store',
dest='threshold',
default=80,
type=int,
help='The maximum allowed number of out-of-order symbols.')
options, argv = parser.parse_args(sys.argv)
if len(argv) != 3: