chromium/src
0
Fork 0
Code Activity

Fix webrtc & angle rollers failing new clang revision assert

Browse Source 
These clients still use a runhook, which appends the target_os to the
revision string.

Bug: 397998718
Change-Id: Id33a5632d3a3ef1f6596c51c02d49b3f249685f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6494302
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1453663}
This commit is contained in:
Andrew Grieve
2025-04-29 18:10:02 -07:00
committed by Chromium LUCI CQ
parent b83b6f836d
commit fdf4b08617
1 changed files with 8 additions and 1 deletions

9
build/config/compiler/BUILD.gn

@ -1666,8 +1666,15 @@ config("clang_revision") {
string_replace(_clang_version_lines[1], "CLANG_SUB_REVISION = ", "")
_expected_clang_revision = "$_py_revision-$_py_subrevision"
# TODO(agrieve): Change filter_include to _clang_revision ==
# _expected_clang_revision once angle & webrtc use a GCS DEPS entry
# rather than a update.py runhook.
assert(
_clang_revision == _expected_clang_revision,
filter_include([ _clang_revision ],
[
_expected_clang_revision,
"$_expected_clang_revision,*",
]) != [],
"clang_revision=\"$_clang_revision\" but update.py expected \"$_expected_clang_revision\". Did you forget to gclient sync?")
}
}