0

[ChromeVox] Add flag to switch between MV2 and MV3

Bug: 388867840
Change-Id: I15a54d0f5f82154d8bd62178c0e824fe40a0eb69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6386907
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1437893}
This commit is contained in:
Valerie Young
2025-03-25 19:13:29 -07:00
committed by Chromium LUCI CQ
parent 4be9d01a36
commit fdf4be882b
8 changed files with 39 additions and 4 deletions

@ -8210,6 +8210,11 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAccessibilityManifestV3BrailleImeDescription, kOsCrOS,
FEATURE_VALUE_TYPE(features::kAccessibilityManifestV3BrailleIme)},
{"enable-accessibility-manifest-v3-chromevox",
flag_descriptions::kAccessibilityManifestV3ChromeVoxName,
flag_descriptions::kAccessibilityManifestV3ChromeVoxDescription, kOsCrOS,
FEATURE_VALUE_TYPE(features::kAccessibilityManifestV3ChromeVox)},
{"enable-accessibility-manifest-v3-enhanced-network-tts",
flag_descriptions::kAccessibilityManifestV3EnhancedNetworkTtsName,
flag_descriptions::kAccessibilityManifestV3EnhancedNetworkTtsDescription,

@ -553,12 +553,16 @@ AccessibilityManager::AccessibilityManager() {
&AccessibilityManager::PostUnloadAccessibilityCommon,
weak_ptr_factory_.GetWeakPtr())));
const bool enable_chromevox_v3_manifest =
::features::IsAccessibilityManifestV3EnabledForChromeVox();
const base::FilePath::CharType* chromevox_manifest_filename =
enable_v3_manifest ? extension_misc::kChromeVoxManifestV3Filename
: extension_misc::kChromeVoxManifestFilename;
enable_v3_manifest || enable_chromevox_v3_manifest
? extension_misc::kChromeVoxManifestV3Filename
: extension_misc::kChromeVoxManifestFilename;
const base::FilePath::CharType* chromevox_guest_manifest_filename =
enable_v3_manifest ? extension_misc::kChromeVoxGuestManifestV3Filename
: extension_misc::kChromeVoxGuestManifestFilename;
enable_v3_manifest || enable_chromevox_v3_manifest
? extension_misc::kChromeVoxGuestManifestV3Filename
: extension_misc::kChromeVoxGuestManifestFilename;
chromevox_loader_ = base::WrapUnique(new AccessibilityExtensionLoader(
extension_misc::kChromeVoxExtensionId,

@ -2374,6 +2374,11 @@
"owners": [ "spectranaut@igalia.com", "akihiroota@chromium.org", "//ui/accessibility/OWNERS" ],
"expiry_milestone": 145
},
{
"name": "enable-accessibility-manifest-v3-chromevox",
"owners": [ "spectranaut@igalia.com", "akihiroota@chromium.org", "//ui/accessibility/OWNERS" ],
"expiry_milestone": 145
},
{
"name": "enable-accessibility-manifest-v3-enhanced-network-tts",
"owners": [ "spectranaut@igalia.com", "akihiroota@chromium.org", "//ui/accessibility/OWNERS" ],

@ -6616,6 +6616,11 @@ const char kAccessibilityManifestV3BrailleImeName[] =
const char kAccessibilityManifestV3BrailleImeDescription[] =
"Experimental migration of Braille IME from extension manifest v2 to v3.";
const char kAccessibilityManifestV3ChromeVoxName[] =
"Changes accessibility extension ChromeVox manifest v2 to v3.";
const char kAccessibilityManifestV3ChromeVoxDescription[] =
"Experimental migration of ChromeVox from extension manifest v2 to v3.";
const char kAccessibilityManifestV3EnhancedNetworkTtsName[] =
"Changes accessibility extension Enhanced Network TTS manifest v2 to v3.";
const char kAccessibilityManifestV3EnhancedNetworkTtsDescription[] =

@ -3887,6 +3887,9 @@ extern const char kExperimentalAccessibilityManifestV3Description[];
extern const char kAccessibilityManifestV3BrailleImeName[];
extern const char kAccessibilityManifestV3BrailleImeDescription[];
extern const char kAccessibilityManifestV3ChromeVoxName[];
extern const char kAccessibilityManifestV3ChromeVoxDescription[];
extern const char kAccessibilityManifestV3EnhancedNetworkTtsName[];
extern const char kAccessibilityManifestV3EnhancedNetworkTtsDescription[];

@ -9353,6 +9353,7 @@ from previous Chrome versions.
<int value="-1882649050" label="ProfilesReordering:enabled"/>
<int value="-1882427024" label="IwaControlledFrame:disabled"/>
<int value="-1882330924" label="NTPArticleSuggestions:enabled"/>
<int value="-1881210399" label="AccessibilityManifestV3ChromeVox:disabled"/>
<int value="-1880683127" label="UnrestrictedUsb:disabled"/>
<int value="-1880633355" label="CaptureModeAudioMixing:disabled"/>
<int value="-1880355454" label="disable-topchrome-md"/>
@ -15515,6 +15516,7 @@ from previous Chrome versions.
<int value="518908322" label="UseAndroidStagingSmds:enabled"/>
<int value="519140642" label="SendWebUIJavaScriptErrorReports:enabled"/>
<int value="519623921" label="SafeModeForCachedFlags:enabled"/>
<int value="520482092" label="AccessibilityManifestV3ChromeVox:enabled"/>
<int value="520738365" label="OmniboxPedalsBatch2NonEnglish:enabled"/>
<int value="520982116" label="BuiltInModuleAll:enabled"/>
<int value="521992655" label="LauncherPlayStoreSearch:disabled"/>

@ -291,6 +291,14 @@ bool IsAccessibilityManifestV3EnabledForBrailleIme() {
::features::kAccessibilityManifestV3BrailleIme);
}
BASE_FEATURE(kAccessibilityManifestV3ChromeVox,
"AccessibilityManifestV3ChromeVox",
base::FEATURE_DISABLED_BY_DEFAULT);
bool IsAccessibilityManifestV3EnabledForChromeVox() {
return base::FeatureList::IsEnabled(
::features::kAccessibilityManifestV3ChromeVox);
}
BASE_FEATURE(kAccessibilityManifestV3EnhancedNetworkTts,
"AccessibilityManifestV3EnhancedNetworkTts",
base::FEATURE_DISABLED_BY_DEFAULT);

@ -216,6 +216,9 @@ AX_BASE_EXPORT bool IsAccessibilitySlowKeysEnabled();
AX_BASE_EXPORT BASE_DECLARE_FEATURE(kAccessibilityManifestV3BrailleIme);
AX_BASE_EXPORT bool IsAccessibilityManifestV3EnabledForBrailleIme();
AX_BASE_EXPORT BASE_DECLARE_FEATURE(kAccessibilityManifestV3ChromeVox);
AX_BASE_EXPORT bool IsAccessibilityManifestV3EnabledForChromeVox();
AX_BASE_EXPORT BASE_DECLARE_FEATURE(kAccessibilityManifestV3EnhancedNetworkTts);
AX_BASE_EXPORT bool IsAccessibilityManifestV3EnabledForEnhancedNetworkTts();